René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Sporadic error when fetching related objects","articleBody":"## This issue is a (choose one):\r\n\r\n- [x] Problem/bug report.\r\n\r\n## Checklist before submitting:\r\n\r\n- [x] I've searched for an existing issue.\r\n- [x] I've asked my question on [Gitter](https://gitter.im/cerebris/jsonapi-resources) and have not received a satisfactory answer.\r\n- [x] I've included a complete [bug report template](https://github.com/cerebris/jsonapi-resources/blob/master/lib/bug_report_templates/rails_5_master.rb). This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.\r\n\r\n## Description\r\n\r\nRelationship objects are used as key in `@join_details` in [JoinManager](https://github.com/cerebris/jsonapi-resources/blob/7a2de3076fa30312ef8d4ed76bee02156e1455d0/lib/jsonapi/active_relation/join_manager.rb#L123) . This hash contains two types of objects: String and Relationship. In case of hash collisions in `@join_details` the method `Relationship#eql?` is called. It currently fails when comparing with a string key.\r\n\r\nReproducible script is here: https://gist.github.com/larskanis/16af0f9e37eac17f27800468a5a6acab\r\n\r\nIt must be started a hundred times but fails eventually with the following error:\r\n\r\n```ruby\r\nE, [2020-11-11T13:39:24.616237 #28095] ERROR -- : Internal Server Error: undefined method `relationship' for \"\":String /home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/path_segment.rb:33:in `eql?'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/active_relation/join_manager.rb:124:in `has_key?'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/active_relation/join_manager.rb:124:in `add_join_details'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/active_relation/join_manager.rb:185:in `block (2 levels) in perform_joins'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/active_relation/join_manager.rb:150:in `each'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/active_relation/join_manager.rb:150:in `block in perform_joins'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/active_relation/join_manager.rb:149:in `each'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/active_relation/join_manager.rb:149:in `perform_joins'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/active_relation/join_manager.rb:41:in `join'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/active_relation_resource.rb:720:in `apply_joins'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/active_relation_resource.rb:695:in `apply_request_settings_to_records'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/active_relation_resource.rb:400:in `find_related_monomorphic_fragments'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/active_relation_resource.rb:213:in `find_related_fragments'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/processor.rb:420:in `find_resource_id_tree_from_resource_relationship'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/processor.rb:380:in `find_related_resource_set'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/processor.rb:192:in `show_related_resources'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/processor.rb:34:in `block (2 levels) in process'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3.4/lib/active_support/callbacks.rb:101:in `run_callbacks'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/processor.rb:33:in `block in process'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3.4/lib/active_support/callbacks.rb:101:in `run_callbacks'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/processor.rb:32:in `process'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/operation.rb:12:in `process'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/acts_as_resource_controller.rb:140:in `process_operation'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/acts_as_resource_controller.rb:110:in `block (3 levels) in process_request'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/request_parser.rb:32:in `each'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/acts_as_resource_controller.rb:97:in `block (2 levels) in process_request'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3.4/lib/active_support/callbacks.rb:101:in `run_callbacks'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/acts_as_resource_controller.rb:96:in `block in process_request'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/acts_as_resource_controller.rb:132:in `process_operations'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/acts_as_resource_controller.rb:95:in `process_request'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/jsonapi-resources-0.10.2/lib/jsonapi/acts_as_resource_controller.rb:59:in `index_related_resources'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/abstract_controller/base.rb:195:in `process_action'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_controller/metal/rendering.rb:30:in `process_action'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/abstract_controller/callbacks.rb:42:in `block in process_action'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3.4/lib/active_support/callbacks.rb:101:in `run_callbacks'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/abstract_controller/callbacks.rb:41:in `process_action'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_controller/metal/rescue.rb:22:in `process_action'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_controller/metal/instrumentation.rb:33:in `block in process_action'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3.4/lib/active_support/notifications.rb:180:in `block in instrument'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3.4/lib/active_support/notifications/instrumenter.rb:24:in `instrument'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3.4/lib/active_support/notifications.rb:180:in `instrument'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_controller/metal/instrumentation.rb:32:in `process_action'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_controller/metal/params_wrapper.rb:245:in `process_action'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/abstract_controller/base.rb:136:in `process'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionview-6.0.3.4/lib/action_view/rendering.rb:39:in `process'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_controller/metal.rb:190:in `dispatch'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_controller/metal.rb:254:in `dispatch'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/routing/route_set.rb:50:in `dispatch'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/routing/route_set.rb:33:in `serve'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/journey/router.rb:49:in `block in serve'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/journey/router.rb:32:in `each'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/journey/router.rb:32:in `serve'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/routing/route_set.rb:834:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-2.2.3/lib/rack/tempfile_reaper.rb:15:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-2.2.3/lib/rack/etag.rb:27:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-2.2.3/lib/rack/conditional_get.rb:27:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-2.2.3/lib/rack/head.rb:12:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/http/content_security_policy.rb:18:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-2.2.3/lib/rack/session/abstract/id.rb:266:in `context'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-2.2.3/lib/rack/session/abstract/id.rb:260:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/middleware/cookies.rb:648:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/middleware/callbacks.rb:27:in `block in call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3.4/lib/active_support/callbacks.rb:101:in `run_callbacks'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/middleware/callbacks.rb:26:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/middleware/executor.rb:14:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/middleware/actionable_exceptions.rb:18:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/middleware/debug_exceptions.rb:32:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/railties-6.0.3.4/lib/rails/rack/logger.rb:37:in `call_app'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/railties-6.0.3.4/lib/rails/rack/logger.rb:28:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/middleware/remote_ip.rb:81:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/middleware/request_id.rb:27:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-2.2.3/lib/rack/method_override.rb:24:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-2.2.3/lib/rack/runtime.rb:22:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/activesupport-6.0.3.4/lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/middleware/executor.rb:14:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/middleware/static.rb:126:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-2.2.3/lib/rack/sendfile.rb:110:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/actionpack-6.0.3.4/lib/action_dispatch/middleware/host_authorization.rb:82:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/railties-6.0.3.4/lib/rails/engine.rb:527:in `call'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-test-1.1.0/lib/rack/mock_session.rb:29:in `request'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-test-1.1.0/lib/rack/test.rb:266:in `process_request'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-test-1.1.0/lib/rack/test.rb:129:in `custom_request'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/rack-test-1.1.0/lib/rack/test.rb:58:in `get'\r\n/home/local/COMCARD-NT/kanis/.rvm/rubies/ruby-2.7.1/lib/ruby/2.7.0/forwardable.rb:235:in `get'\r\ntest-error-hash.rb:126:in `block in test_index_your_models'\r\ntest-error-hash.rb:121:in `times'\r\ntest-error-hash.rb:121:in `test_index_your_models'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest/test.rb:98:in `block (3 levels) in run'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest/test.rb:195:in `capture_exceptions'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest/test.rb:95:in `block (2 levels) in run'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:272:in `time_it'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest/test.rb:94:in `block in run'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:367:in `on_signal'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest/test.rb:211:in `with_info_handler'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest/test.rb:93:in `run'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:1029:in `run_one_method'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:341:in `run_one_method'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:328:in `block (2 levels) in run'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:327:in `each'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:327:in `block in run'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:367:in `on_signal'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:354:in `with_info_handler'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:326:in `run'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:164:in `block in __run'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:164:in `map'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:164:in `__run'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:141:in `run'\r\n/home/local/COMCARD-NT/kanis/.rvm/gems/ruby-2.7.1/gems/minitest-5.14.2/lib/minitest.rb:68:in `block in autorun'\r\nI, [2020-11-11T13:39:24.622121 #28095]  INFO -- : Completed 500 Internal Server Error in 16ms (Views: 1.0ms | Allocations: 8220)\r\n```\r\n","author":{"url":"https://github.com/larskanis","@type":"Person","name":"larskanis"},"datePublished":"2020-11-11T13:18:18.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/1333/jsonapi-resources/issues/1333"}