Title: perf improvements: generate_iso_surface_vertices and generate_sparse_density_map · Issue #6 · InteractiveComputerGraphics/splashsurf · GitHub
Open Graph Title: perf improvements: generate_iso_surface_vertices and generate_sparse_density_map · Issue #6 · InteractiveComputerGraphics/splashsurf
X Title: perf improvements: generate_iso_surface_vertices and generate_sparse_density_map · Issue #6 · InteractiveComputerGraphics/splashsurf
Description: Hello! So as apart of investigation into potentially improving perf, I've collected some stats, and I've identified two target areas that appear to occupy largest portion of meshing budget: Reconstructed 11790 vertices (indices=64464) fr...
Open Graph Description: Hello! So as apart of investigation into potentially improving perf, I've collected some stats, and I've identified two target areas that appear to occupy largest portion of meshing budget: Reconst...
X Description: Hello! So as apart of investigation into potentially improving perf, I've collected some stats, and I've identified two target areas that appear to occupy largest portion of meshing budget:...
Opengraph URL: https://github.com/InteractiveComputerGraphics/splashsurf/issues/6
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"perf improvements: generate_iso_surface_vertices and generate_sparse_density_map","articleBody":"Hello! So as apart of investigation into potentially improving perf, I've collected some stats, and I've identified two target areas that appear to occupy largest portion of meshing budget:\r\n\r\n```\r\nReconstructed 11790 vertices (indices=64464) from 1000 particlces in 43.492334ms and pushed in 43.679657ms\r\nreconstruct_surface: 100.00%, 43.49ms/call @ 22.99Hz\r\n compute minimum enclosing aabb: 0.01%, 0.01ms/call @ 22.99Hz\r\n neighborhood_search: 11.67%, 5.07ms/call @ 22.99Hz\r\n parallel_generate_cell_to_particle_map: 26.25%, 1.33ms/call @ 22.99Hz\r\n get_cell_neighborhoods_par: 5.06%, 0.26ms/call @ 22.99Hz\r\n calculate_particle_neighbors_par: 64.24%, 3.26ms/call @ 22.99Hz\r\n parallel_compute_particle_densities: 0.47%, 0.21ms/call @ 22.99Hz\r\n parallel_generate_sparse_density_map: 41.18%, 17.91ms/call @ 22.99Hz\r\n triangulate_density_map: 46.62%, 20.28ms/call @ 22.99Hz\r\n interpolate_points_to_cell_data: 91.94%, 18.64ms/call @ 22.99Hz\r\n generate_iso_surface_vertices: 84.61%, 15.77ms/call @ 22.99Hz\r\n relative_to_threshold_postprocessing: 15.36%, 2.86ms/call @ 22.99Hz\r\n triangulate: 8.04%, 1.63ms/call @ 22.99Hz\r\n```\r\n\r\nSo for meshing every frame the 1k particles, it takes from 30-50ms; Ideally we can get this down somewhere close to 16ms, so that we could have a one-frame latency delay on generating the meshes for a realtime sim in 60fps.\r\n\r\nAs such, it looks like `generate_iso_surface_vertices` (15.7ms) and `parallel_generate_sparse_density_map` (17.9ms) are good candidates.\r\n\r\nI don't know much about fluid simulations, so I'll defer to you on matters here, but I have done a lot of work in perf and optimization; do you think there's any place to attack here, and if so, mind giving me a pointer so I could start/take a look? :)\r\n\r\nI'm also wondering perhaps is there any data structures we don't have to compute every frame? Perhaps the density map? Or similar to #4 we could perhaps reuse container structures to reduce allocation strain?\r\n\r\nThanks, and looking forward to your insights here :)","author":{"url":"https://github.com/whiterabbit42k","@type":"Person","name":"whiterabbit42k"},"datePublished":"2020-12-09T22:36:02Z","url":"https://github.com/InteractiveComputerGraphics/splashsurf/issues/6"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:1ba32267-a855-4c5c-1597-75b76df8a1a9 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A41E:15E965:31AFFF:45B979:6B005D49 |
| html-safe-nonce | c9316f5a165d8b3a02b54367bc9cb44f9d67ac73df154e141e62549125e61e9c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDFFOjE1RTk2NTozMUFGRkY6NDVCOTc5OjZCMDA1RDQ5IiwidmlzaXRvcl9pZCI6IjgyNTg3NjY1MDYxNjczOTM2MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 90a229c643010b4b1dcd35a6dc89ebbafe23258938e1b06c4bb8b1771b73a9bd |
| hovercard-subject-tag | issue:760724112 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/InteractiveComputerGraphics/splashsurf/6/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9cdd3a3b77ac5963b3103e8f922f9c874c2796fd2681d9b10d209ed6719a7eb3/InteractiveComputerGraphics/splashsurf/issues/6 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9cdd3a3b77ac5963b3103e8f922f9c874c2796fd2681d9b10d209ed6719a7eb3/InteractiveComputerGraphics/splashsurf/issues/6 |
| og:image:alt | Hello! So as apart of investigation into potentially improving perf, I've collected some stats, and I've identified two target areas that appear to occupy largest portion of meshing budget: Reconst... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | whiterabbit42k |
| hostname | github.com |
| expected-hostname | github.com |
| None | 29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73 |
| turbo-cache-control | no-preview |
| go-import | github.com/InteractiveComputerGraphics/splashsurf git https://github.com/InteractiveComputerGraphics/splashsurf.git |
| octolytics-dimension-user_id | 18286040 |
| octolytics-dimension-user_login | InteractiveComputerGraphics |
| octolytics-dimension-repository_id | 246888911 |
| octolytics-dimension-repository_nwo | InteractiveComputerGraphics/splashsurf |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 246888911 |
| octolytics-dimension-repository_network_root_nwo | InteractiveComputerGraphics/splashsurf |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | eacd927ba6112e3b01ba99c762bd699a4a4f5df7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width