René's URL Explorer Experiment


Title: perf improvements: generate_iso_surface_vertices and generate_sparse_density_map · Issue #6 · InteractiveComputerGraphics/splashsurf · GitHub

Open Graph Title: perf improvements: generate_iso_surface_vertices and generate_sparse_density_map · Issue #6 · InteractiveComputerGraphics/splashsurf

X Title: perf improvements: generate_iso_surface_vertices and generate_sparse_density_map · Issue #6 · InteractiveComputerGraphics/splashsurf

Description: Hello! So as apart of investigation into potentially improving perf, I've collected some stats, and I've identified two target areas that appear to occupy largest portion of meshing budget: Reconstructed 11790 vertices (indices=64464) fr...

Open Graph Description: Hello! So as apart of investigation into potentially improving perf, I've collected some stats, and I've identified two target areas that appear to occupy largest portion of meshing budget: Reconst...

X Description: Hello! So as apart of investigation into potentially improving perf, I've collected some stats, and I've identified two target areas that appear to occupy largest portion of meshing budget:...

Opengraph URL: https://github.com/InteractiveComputerGraphics/splashsurf/issues/6

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"perf improvements: generate_iso_surface_vertices and generate_sparse_density_map","articleBody":"Hello! So as apart of investigation into potentially improving perf, I've collected some stats, and I've identified two target areas that appear to occupy largest portion of meshing budget:\r\n\r\n```\r\nReconstructed 11790 vertices (indices=64464) from 1000 particlces in 43.492334ms and pushed in 43.679657ms\r\nreconstruct_surface: 100.00%, 43.49ms/call @ 22.99Hz\r\n  compute minimum enclosing aabb: 0.01%, 0.01ms/call @ 22.99Hz\r\n  neighborhood_search: 11.67%, 5.07ms/call @ 22.99Hz\r\n    parallel_generate_cell_to_particle_map: 26.25%, 1.33ms/call @ 22.99Hz\r\n    get_cell_neighborhoods_par: 5.06%, 0.26ms/call @ 22.99Hz\r\n    calculate_particle_neighbors_par: 64.24%, 3.26ms/call @ 22.99Hz\r\n  parallel_compute_particle_densities: 0.47%, 0.21ms/call @ 22.99Hz\r\n  parallel_generate_sparse_density_map: 41.18%, 17.91ms/call @ 22.99Hz\r\n  triangulate_density_map: 46.62%, 20.28ms/call @ 22.99Hz\r\n    interpolate_points_to_cell_data: 91.94%, 18.64ms/call @ 22.99Hz\r\n      generate_iso_surface_vertices: 84.61%, 15.77ms/call @ 22.99Hz\r\n      relative_to_threshold_postprocessing: 15.36%, 2.86ms/call @ 22.99Hz\r\n    triangulate: 8.04%, 1.63ms/call @ 22.99Hz\r\n```\r\n\r\nSo for meshing every frame the 1k particles, it takes from 30-50ms; Ideally we can get this down somewhere close to 16ms, so that we could have a one-frame latency delay on generating the meshes for a realtime sim in 60fps.\r\n\r\nAs such, it looks like `generate_iso_surface_vertices` (15.7ms) and `parallel_generate_sparse_density_map` (17.9ms) are good candidates.\r\n\r\nI don't know much about fluid simulations, so I'll defer to you on matters here, but I have done a lot of work in perf and optimization; do you think there's any place to attack here, and if so, mind giving me a pointer so I could start/take a look? :)\r\n\r\nI'm also wondering perhaps is there any data structures we don't have to compute every frame? Perhaps the density map? Or similar to #4 we could perhaps reuse container structures to reduce allocation strain?\r\n\r\nThanks, and looking forward to your insights here :)","author":{"url":"https://github.com/whiterabbit42k","@type":"Person","name":"whiterabbit42k"},"datePublished":"2020-12-09T22:36:02Z","url":"https://github.com/InteractiveComputerGraphics/splashsurf/issues/6"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1ba32267-a855-4c5c-1597-75b76df8a1a9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA41E:15E965:31AFFF:45B979:6B005D49
html-safe-noncec9316f5a165d8b3a02b54367bc9cb44f9d67ac73df154e141e62549125e61e9c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDFFOjE1RTk2NTozMUFGRkY6NDVCOTc5OjZCMDA1RDQ5IiwidmlzaXRvcl9pZCI6IjgyNTg3NjY1MDYxNjczOTM2MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac90a229c643010b4b1dcd35a6dc89ebbafe23258938e1b06c4bb8b1771b73a9bd
hovercard-subject-tagissue:760724112
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/InteractiveComputerGraphics/splashsurf/6/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9cdd3a3b77ac5963b3103e8f922f9c874c2796fd2681d9b10d209ed6719a7eb3/InteractiveComputerGraphics/splashsurf/issues/6
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9cdd3a3b77ac5963b3103e8f922f9c874c2796fd2681d9b10d209ed6719a7eb3/InteractiveComputerGraphics/splashsurf/issues/6
og:image:altHello! So as apart of investigation into potentially improving perf, I've collected some stats, and I've identified two target areas that appear to occupy largest portion of meshing budget: Reconst...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewhiterabbit42k
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-preview
go-importgithub.com/InteractiveComputerGraphics/splashsurf git https://github.com/InteractiveComputerGraphics/splashsurf.git
octolytics-dimension-user_id18286040
octolytics-dimension-user_loginInteractiveComputerGraphics
octolytics-dimension-repository_id246888911
octolytics-dimension-repository_nwoInteractiveComputerGraphics/splashsurf
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id246888911
octolytics-dimension-repository_network_root_nwoInteractiveComputerGraphics/splashsurf
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/InteractiveComputerGraphics/splashsurf/issues/6#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FInteractiveComputerGraphics%2Fsplashsurf%2Fissues%2F6
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FInteractiveComputerGraphics%2Fsplashsurf%2Fissues%2F6
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=InteractiveComputerGraphics%2Fsplashsurf
Reloadhttps://github.com/InteractiveComputerGraphics/splashsurf/issues/6
Reloadhttps://github.com/InteractiveComputerGraphics/splashsurf/issues/6
Reloadhttps://github.com/InteractiveComputerGraphics/splashsurf/issues/6
InteractiveComputerGraphicshttps://github.com/InteractiveComputerGraphics
splashsurfhttps://github.com/InteractiveComputerGraphics/splashsurf
Codehttps://github.com/InteractiveComputerGraphics/splashsurf
Issues5 (5)https://github.com/InteractiveComputerGraphics/splashsurf/issues
Pull requests3 (3)https://github.com/InteractiveComputerGraphics/splashsurf/pulls
Actionshttps://github.com/InteractiveComputerGraphics/splashsurf/actions
Projectshttps://github.com/InteractiveComputerGraphics/splashsurf/projects
Security and qualityhttps://github.com/InteractiveComputerGraphics/splashsurf/security
Insightshttps://github.com/InteractiveComputerGraphics/splashsurf/insights
https://github.com/InteractiveComputerGraphics/splashsurf
New issuehttps://github.com/login?return_to=https://github.com/InteractiveComputerGraphics/splashsurf/issues/6
New issuehttps://github.com/login?return_to=https://github.com/InteractiveComputerGraphics/splashsurf/issues/6
perf improvements: generate_iso_surface_vertices and generate_sparse_density_maphttps://github.com/InteractiveComputerGraphics/splashsurf/issues/6#top
enhancementNew feature or requesthttps://github.com/InteractiveComputerGraphics/splashsurf/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/whiterabbit42k
whiterabbit42khttps://github.com/whiterabbit42k
on Dec 9, 2020https://github.com/InteractiveComputerGraphics/splashsurf/issues/6#issue-760724112
#4https://github.com/InteractiveComputerGraphics/splashsurf/issues/4
https://github.com/w1th0utnam3
w1th0utnam3https://github.com/w1th0utnam3
on Dec 11, 2020https://github.com/InteractiveComputerGraphics/splashsurf/issues/6#issuecomment-743456429
lockfree rewritehttps://github.com/xacrimon/dashmap/pull/81
https://github.com/whiterabbit42k
whiterabbit42khttps://github.com/whiterabbit42k
on Dec 11, 2020https://github.com/InteractiveComputerGraphics/splashsurf/issues/6#issuecomment-743469392
https://github.com/w1th0utnam3
w1th0utnam3https://github.com/w1th0utnam3
on Dec 11, 2020https://github.com/InteractiveComputerGraphics/splashsurf/issues/6#issuecomment-743471271
https://github.com/whiterabbit42k
whiterabbit42khttps://github.com/whiterabbit42k
on Dec 11, 2020https://github.com/InteractiveComputerGraphics/splashsurf/issues/6#issuecomment-743479291
https://github.com/w1th0utnam3
w1th0utnam3https://github.com/w1th0utnam3
on Dec 16, 2020https://github.com/InteractiveComputerGraphics/splashsurf/issues/6#issuecomment-746415217
https://github.com/whiterabbit42k
whiterabbit42khttps://github.com/whiterabbit42k
on Dec 28, 2020https://github.com/InteractiveComputerGraphics/splashsurf/issues/6#issuecomment-751624192
https://github.com/whiterabbit42k
whiterabbit42khttps://github.com/whiterabbit42k
on Dec 29, 2020https://github.com/InteractiveComputerGraphics/splashsurf/issues/6#issuecomment-751984035
w1th0utnam3https://github.com/w1th0utnam3
enhancementNew feature or requesthttps://github.com/InteractiveComputerGraphics/splashsurf/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Dec 16, 2021https://github.com/InteractiveComputerGraphics/splashsurf/issues/6#event-5777652673
Sign up for freehttps://github.com/signup?return_to=https://github.com/InteractiveComputerGraphics/splashsurf/issues/6
Sign in to commenthttps://github.com/login?return_to=https://github.com/InteractiveComputerGraphics/splashsurf/issues/6
enhancementNew feature or requesthttps://github.com/InteractiveComputerGraphics/splashsurf/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.