Title: upload_from_path does not close the file · Issue #45 · Imgur/imgurpython · GitHub
Open Graph Title: upload_from_path does not close the file · Issue #45 · Imgur/imgurpython
X Title: upload_from_path does not close the file · Issue #45 · Imgur/imgurpython
Description: as can be seen from the following snippet: imgurpython/imgurpython/client.py Lines 582 to 596 in 534c2c8 def upload_from_path(self, path, config=None, anon=True): if not config: config = dict() fd = open(path, 'rb') contents = fd.read() ...
Open Graph Description: as can be seen from the following snippet: imgurpython/imgurpython/client.py Lines 582 to 596 in 534c2c8 def upload_from_path(self, path, config=None, anon=True): if not config: config = dict() fd ...
X Description: as can be seen from the following snippet: imgurpython/imgurpython/client.py Lines 582 to 596 in 534c2c8 def upload_from_path(self, path, config=None, anon=True): if not config: config = dict() fd ...
Opengraph URL: https://github.com/Imgur/imgurpython/issues/45
X: @github
Domain: github.com
IPv4 address: 140.82.112.4
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"upload_from_path does not close the file","articleBody":"as can be seen from the following snippet:\nhttps://github.com/Imgur/imgurpython/blob/534c2c8d346e7067b78036f7ece9a1d36a6be18e/imgurpython/client.py#L582-L596\n\nThe file needs to be closed after being opened. The code above can be easily changed into the following:\n\n``` python\ndef upload_from_path(self, path, config=None, anon=True):\n if not config:\n config = dict()\n\n with open(path, 'rb') as fd:\n contents = fd.read()\n b64 = base64.b64encode(contents)\n\n data = {\n 'image': b64,\n 'type': 'base64',\n }\n\n data.update({meta: config[meta] for meta in set(self.allowed_image_fields).intersection(config.keys())})\n return self.make_request('POST', 'upload', data, anon)\n```\n\nAnd the issue will be fixed. The issue is that a BufferedReader is left open and never closed.\n","author":{"url":"https://github.com/brenol","@type":"Person","name":"brenol"},"datePublished":"2015-10-15T02:55:34Z","url":"https://github.com/Imgur/imgurpython/issues/45"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:1ebb3fdc-6074-799d-a94b-25a6f587962b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CA7A:293912:2BC1CAD:39C2252:6B033411 |
| html-safe-nonce | 43f2efe62f0662d1bfeb958596b930b5c4698dc0ac37bf0e73d0089566680ff0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTdBOjI5MzkxMjoyQkMxQ0FEOjM5QzIyNTI6NkIwMzM0MTEiLCJ2aXNpdG9yX2lkIjoiODI5OTE4ODQ3Mzg4ODI0NTkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 90b65cb92838336f73a00fea1c388070f3448bd66380ebc468963a9b07e7d60a |
| hovercard-subject-tag | issue:111535668 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/Imgur/imgurpython/45/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a1c0ef1d9dc84bdf110b3c34c1dfe44cba618a720f64052dbb17febce532e845/Imgur/imgurpython/issues/45 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a1c0ef1d9dc84bdf110b3c34c1dfe44cba618a720f64052dbb17febce532e845/Imgur/imgurpython/issues/45 |
| og:image:alt | as can be seen from the following snippet: imgurpython/imgurpython/client.py Lines 582 to 596 in 534c2c8 def upload_from_path(self, path, config=None, anon=True): if not config: config = dict() fd ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | brenol |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/Imgur/imgurpython git https://github.com/Imgur/imgurpython.git |
| octolytics-dimension-user_id | 558067 |
| octolytics-dimension-user_login | Imgur |
| octolytics-dimension-repository_id | 13971811 |
| octolytics-dimension-repository_nwo | Imgur/imgurpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13971811 |
| octolytics-dimension-repository_network_root_nwo | Imgur/imgurpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
| Server | github.com |
| Content-Type | text/html; charset=utf-8 |
| Cache-Control | max-age=0, private, must-revalidate |
Viewport: width=device-width