René's URL Explorer Experiment


Title: Update dirty flag on modifying section values by naveenjr7 · Pull Request #61 · IABTechLab/iabgpp-java · GitHub

Open Graph Title: Update dirty flag on modifying section values by naveenjr7 · Pull Request #61 · IABTechLab/iabgpp-java

X Title: Update dirty flag on modifying section values by naveenjr7 · Pull Request #61 · IABTechLab/iabgpp-java

Description: Today when we make any changes to any section in Gppmodel object, its not getting reflected while we encoding back. And root cause for this issue is, dirty flag is not getting updated properly on setFieldValue method. @chuff could you please review this. Issue can be reproduced with below steps GppModel gppModel = new GppModel("DBABBg~BVoIgACY.QA"); // Ideally, this should cause validation failure // Reference: https://github.com/IABTechLab/iabgpp-java/blob/fcd606121f5795080620099a9dc51dac0482f46f/iabgpp-encoder/src/main/java/com/iab/gpp/encoder/segment/UsCaV1CoreSegment.java#L110-L115 gppModel.setFieldValue(UsCaV1.NAME, UsCaV1Field.SHARING_OPT_OUT_NOTICE, 0); gppModel.setFieldValue(UsCaV1.NAME, UsCaV1Field.SHARING_OPT_OUT, 1); String encodedString = gppModel.encode();

Open Graph Description: Today when we make any changes to any section in Gppmodel object, its not getting reflected while we encoding back. And root cause for this issue is, dirty flag is not getting updated properly on s...

X Description: Today when we make any changes to any section in Gppmodel object, its not getting reflected while we encoding back. And root cause for this issue is, dirty flag is not getting updated properly on s...

Opengraph URL: https://github.com/IABTechLab/iabgpp-java/pull/61

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f5fe3533-299e-fe84-2654-238eb19b7e4a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA12C:195800:3DD540:54F61B:6AF65C44
html-safe-nonce8f4664c242358e6eeff4e0e28435ab79b93355f90b58a1023fec8a0749cfb34e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTJDOjE5NTgwMDozREQ1NDA6NTRGNjFCOjZBRjY1QzQ0IiwidmlzaXRvcl9pZCI6IjM3NDY5NDYxMDg0OTkxMzkyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0d06ce7db4457aea8b0fdff8032cb8bece538b52cbd2b386ddeb708084a1c61d
hovercard-subject-tagpull_request:2036601391
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/IABTechLab/iabgpp-java/pull/61/files
twitter:imagehttps://avatars.githubusercontent.com/u/30240425?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/30240425?s=400&v=4
og:image:altToday when we make any changes to any section in Gppmodel object, its not getting reflected while we encoding back. And root cause for this issue is, dirty flag is not getting updated properly on s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefded9ab97d594702a6a4ebcef0ee4f94c91fb16da7c62cac91ee0125e9c2d58c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/IABTechLab/iabgpp-java git https://github.com/IABTechLab/iabgpp-java.git
octolytics-dimension-user_id82903538
octolytics-dimension-user_loginIABTechLab
octolytics-dimension-repository_id538620496
octolytics-dimension-repository_nwoIABTechLab/iabgpp-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id538620496
octolytics-dimension-repository_network_root_nwoIABTechLab/iabgpp-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release39cd7745159797c426e62ba2199c584d653d4b32
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/IABTechLab/iabgpp-java/pull/61/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FIABTechLab%2Fiabgpp-java%2Fpull%2F61%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FIABTechLab%2Fiabgpp-java%2Fpull%2F61%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=IABTechLab%2Fiabgpp-java
Reloadhttps://github.com/IABTechLab/iabgpp-java/pull/61/files
Reloadhttps://github.com/IABTechLab/iabgpp-java/pull/61/files
Reloadhttps://github.com/IABTechLab/iabgpp-java/pull/61/files
IABTechLabhttps://github.com/IABTechLab
iabgpp-javahttps://github.com/IABTechLab/iabgpp-java
Codehttps://github.com/IABTechLab/iabgpp-java
Issues13 (13)https://github.com/IABTechLab/iabgpp-java/issues
Pull requests4 (4)https://github.com/IABTechLab/iabgpp-java/pulls
Actionshttps://github.com/IABTechLab/iabgpp-java/actions
Projectshttps://github.com/IABTechLab/iabgpp-java/projects
Security and qualityhttps://github.com/IABTechLab/iabgpp-java/security
Insightshttps://github.com/IABTechLab/iabgpp-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FIABTechLab%2Fiabgpp-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FIABTechLab%2Fiabgpp-java%2Fissues%2Fnew%2Fchoose
iabmayankhttps://github.com/iabmayank
IABTechLab:masterhttps://github.com/IABTechLab/iabgpp-java/tree/master
naveenjr7:fixDirtyhttps://github.com/naveenjr7/iabgpp-java/tree/fixDirty
Conversation 4 https://github.com/IABTechLab/iabgpp-java/pull/61
Commits 1 https://github.com/IABTechLab/iabgpp-java/pull/61/commits
Checks 0 https://github.com/IABTechLab/iabgpp-java/pull/61/checks
Files changed https://github.com/IABTechLab/iabgpp-java/pull/61/files
Please reload this pagehttps://github.com/IABTechLab/iabgpp-java/pull/61/files
Update dirty flag on modifying section values https://github.com/IABTechLab/iabgpp-java/pull/61/files#top
Show all changes 1 commit https://github.com/IABTechLab/iabgpp-java/pull/61/files
c0fa502 Update AbstractLazilyEncodableSection.java naveenjr7 Aug 26, 2024 https://github.com/IABTechLab/iabgpp-java/pull/61/commits/c0fa5022d4157a633a529d8d163d4ac511b7dc2b
Clear filters https://github.com/IABTechLab/iabgpp-java/pull/61/files
Please reload this pagehttps://github.com/IABTechLab/iabgpp-java/pull/61/files
Please reload this pagehttps://github.com/IABTechLab/iabgpp-java/pull/61/files
iabgpp-encoder/src/main/java/com/iab/gpp/encoder/section/AbstractLazilyEncodableSection.javahttps://github.com/IABTechLab/iabgpp-java/pull/61/files#diff-23048b61c09059afd58f0fa60e297a86a20cd58eb4fe52c52f9a2e78f30d90a0
View file https://github.com/naveenjr7/iabgpp-java/blob/c0fa5022d4157a633a529d8d163d4ac511b7dc2b/iabgpp-encoder/src/main/java/com/iab/gpp/encoder/section/AbstractLazilyEncodableSection.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/IABTechLab/iabgpp-java/pull/61/{{ revealButtonHref }}
https://github.com/IABTechLab/iabgpp-java/pull/61/files#diff-23048b61c09059afd58f0fa60e297a86a20cd58eb4fe52c52f9a2e78f30d90a0
https://github.com/IABTechLab/iabgpp-java/pull/61/files#diff-23048b61c09059afd58f0fa60e297a86a20cd58eb4fe52c52f9a2e78f30d90a0
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.