René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"App Engine testrunner should exit with a non-zero exit code when tests fail","articleBody":"This doesn't seem significant enough for me to want to fill out a CLA... / please add this.\n\nI'm trying out [Bitbucket Pipelines](https://confluence.atlassian.com/bitbucket/bitbucket-pipelines-beta-792496469.html) and noticed that my builds were passing even though tests were failing. This is due to the fact that the testrunner always exits with code 0 ([someone else had a similar problem with PHP tests](https://bitbucket.org/site/master/issues/12810/pipeline-was-marked-as-passed-even-though)).\n\nI suspect the same is true for other build agents. The following patch takes care of it:\n\n```\n--- a/runner.py    Tue Sep 06 17:49:32 2016 +0200\n+++ b/runner.py    Wed Sep 07 10:56:25 2016 +0200\n@@ -76,7 +76,7 @@\n\n     # Discover and run tests.\n     suite = unittest.loader.TestLoader().discover(test_path, \"*_test.py\")\n-    unittest.TextTestRunner(verbosity=2).run(suite)\n+    return unittest.TextTestRunner(verbosity=2).run(suite)\n\n\n if __name__ == '__main__':\n@@ -88,6 +88,8 @@\n         sys.exit(1)\n     SDK_PATH = args[0]\n     TEST_PATH = args[1]\n-    main(SDK_PATH, TEST_PATH)\n+    result = main(SDK_PATH, TEST_PATH)\n+    if not result.wasSuccessful():\n+        sys.exit(1)\n\n # [END runner]\n```\n","author":{"url":"https://github.com/maltem-za","@type":"Person","name":"maltem-za"},"datePublished":"2016-09-07T14:30:31.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/503/python-docs-samples/issues/503"}