René's URL Explorer Experiment


Title: Support DTO required fields as not optional properties on interface in TS. by heymb · Pull Request #69 · FacilityApi/FacilityJavaScript · GitHub

Open Graph Title: Support DTO required fields as not optional properties on interface in TS. by heymb · Pull Request #69 · FacilityApi/FacilityJavaScript

X Title: Support DTO required fields as not optional properties on interface in TS. by heymb · Pull Request #69 · FacilityApi/FacilityJavaScript

Description: Implement minimum support for #34 for DTOS. Does not add other validation. At minimum, we could make the fields not optional in TypeScript. Update test added in #68. Run codegen since this FSD file has required fields. Update version and release notes since moving from generating all DTO fields as optional properties in TS to required fields are not optional is a breaking change.

Open Graph Description: Implement minimum support for #34 for DTOS. Does not add other validation. At minimum, we could make the fields not optional in TypeScript. Update test added in #68. Run codegen since this FS...

X Description: Implement minimum support for #34 for DTOS. Does not add other validation. At minimum, we could make the fields not optional in TypeScript. Update test added in #68. Run codegen since this FS...

Opengraph URL: https://github.com/FacilityApi/FacilityJavaScript/pull/69

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f51ea733-fab8-71a6-da64-0f40bc570bbc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB86A:2DB547:C7C53:105D59:6B00B9AF
html-safe-nonce3c50b26345c3c1878f7cf16ef3bd588d0f8545aab04d3df906733b111f740fd3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODZBOjJEQjU0NzpDN0M1MzoxMDVENTk6NkIwMEI5QUYiLCJ2aXNpdG9yX2lkIjoiNjY3NzI2MzMwMTg1ODA4MTE5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf42b03a4ad3e83818e60f8f3105e8165daf22555166d864480956c67008f24ea
hovercard-subject-tagpull_request:2004129160
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/FacilityApi/FacilityJavaScript/pull/69/files
twitter:imagehttps://avatars.githubusercontent.com/u/91144266?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/91144266?s=400&v=4
og:image:altImplement minimum support for #34 for DTOS. Does not add other validation. At minimum, we could make the fields not optional in TypeScript. Update test added in #68. Run codegen since this FS...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/FacilityApi/FacilityJavaScript git https://github.com/FacilityApi/FacilityJavaScript.git
octolytics-dimension-user_id22828021
octolytics-dimension-user_loginFacilityApi
octolytics-dimension-repository_id73533359
octolytics-dimension-repository_nwoFacilityApi/FacilityJavaScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id73533359
octolytics-dimension-repository_network_root_nwoFacilityApi/FacilityJavaScript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FFacilityApi%2FFacilityJavaScript%2Fpull%2F69%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FFacilityApi%2FFacilityJavaScript%2Fpull%2F69%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=FacilityApi%2FFacilityJavaScript
Reloadhttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files
Reloadhttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files
Reloadhttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files
FacilityApihttps://github.com/FacilityApi
FacilityJavaScripthttps://github.com/FacilityApi/FacilityJavaScript
Codehttps://github.com/FacilityApi/FacilityJavaScript
Issues6 (6)https://github.com/FacilityApi/FacilityJavaScript/issues
Pull requests6 (6)https://github.com/FacilityApi/FacilityJavaScript/pulls
Actionshttps://github.com/FacilityApi/FacilityJavaScript/actions
Security and qualityhttps://github.com/FacilityApi/FacilityJavaScript/security
Insightshttps://github.com/FacilityApi/FacilityJavaScript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FFacilityApi%2FFacilityJavaScript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FFacilityApi%2FFacilityJavaScript%2Fissues%2Fnew%2Fchoose
heymbhttps://github.com/heymb
FacilityApi:masterhttps://github.com/FacilityApi/FacilityJavaScript/tree/master
heymb:supportRequiredFieldshttps://github.com/heymb/FacilityJavaScript/tree/supportRequiredFields
Conversation 0 https://github.com/FacilityApi/FacilityJavaScript/pull/69
Commits 3 https://github.com/FacilityApi/FacilityJavaScript/pull/69/commits
Checks 0 https://github.com/FacilityApi/FacilityJavaScript/pull/69/checks
Files changed https://github.com/FacilityApi/FacilityJavaScript/pull/69/files
Please reload this pagehttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files
Support DTO required fields as not optional properties on interface in TS. https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#top
Show all changes 3 commits https://github.com/FacilityApi/FacilityJavaScript/pull/69/files
a085f10 Support generating required fields as not optional in TS Aug 2, 2024 https://github.com/FacilityApi/FacilityJavaScript/pull/69/commits/a085f109f90759db174d86eef9884d79238c4eec
ff4f6ea Run codegen since required now is not optional Aug 2, 2024 https://github.com/FacilityApi/FacilityJavaScript/pull/69/commits/ff4f6ea2a8c5a4afa1b7119c92ab29bc7e4cd898
499aa47 Update version number and release notes per contributing docs since g… Aug 5, 2024 https://github.com/FacilityApi/FacilityJavaScript/pull/69/commits/499aa473725866cd707cf2e1de6336578f898371
Clear filters https://github.com/FacilityApi/FacilityJavaScript/pull/69/files
Please reload this pagehttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files
Please reload this pagehttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files
Directory.Build.props https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-9da24614831c308827a1ae533ffea392c97638c261dd42bd0f5226baa136d16e
ReleaseNotes.md https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-b86fde319b108f5aad77b46b8f12fc209239ce28d1ff7ad97afeb7908983afc7
conformanceApiTypes.ts https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-172e939622a97d4998f09c51eb2b68fff14ff98186dccc07319aace7a59983d3
conformanceApiPlugin.ts https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-3b0d2a73c71d77299adcbabb59d1b67026247a5c6d2dea2d8db55125fec13b93
JavaScriptGenerator.cs https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-576178b24479d766dd3774c5329f82bc46df8c4997c83cadef91db766f2cc05a
JavaScriptGeneratorTests.cs https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-42a1bcd1a0883d99948c5ed5d279b8d771c986702f15a4e1e538163f10016757
Directory.Build.propshttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-9da24614831c308827a1ae533ffea392c97638c261dd42bd0f5226baa136d16e
View file https://github.com/heymb/FacilityJavaScript/blob/499aa473725866cd707cf2e1de6336578f898371/Directory.Build.props
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/FacilityApi/FacilityJavaScript/pull/69/{{ revealButtonHref }}
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-9da24614831c308827a1ae533ffea392c97638c261dd42bd0f5226baa136d16e
ReleaseNotes.mdhttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-b86fde319b108f5aad77b46b8f12fc209239ce28d1ff7ad97afeb7908983afc7
View file https://github.com/heymb/FacilityJavaScript/blob/499aa473725866cd707cf2e1de6336578f898371/ReleaseNotes.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/FacilityApi/FacilityJavaScript/pull/69/{{ revealButtonHref }}
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-b86fde319b108f5aad77b46b8f12fc209239ce28d1ff7ad97afeb7908983afc7
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-b86fde319b108f5aad77b46b8f12fc209239ce28d1ff7ad97afeb7908983afc7
conformance/src/conformanceApiTypes.tshttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-172e939622a97d4998f09c51eb2b68fff14ff98186dccc07319aace7a59983d3
View file https://github.com/heymb/FacilityJavaScript/blob/499aa473725866cd707cf2e1de6336578f898371/conformance/src/conformanceApiTypes.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/FacilityApi/FacilityJavaScript/pull/69/{{ revealButtonHref }}
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-172e939622a97d4998f09c51eb2b68fff14ff98186dccc07319aace7a59983d3
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-172e939622a97d4998f09c51eb2b68fff14ff98186dccc07319aace7a59983d3
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-172e939622a97d4998f09c51eb2b68fff14ff98186dccc07319aace7a59983d3
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-172e939622a97d4998f09c51eb2b68fff14ff98186dccc07319aace7a59983d3
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-172e939622a97d4998f09c51eb2b68fff14ff98186dccc07319aace7a59983d3
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-172e939622a97d4998f09c51eb2b68fff14ff98186dccc07319aace7a59983d3
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-172e939622a97d4998f09c51eb2b68fff14ff98186dccc07319aace7a59983d3
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-172e939622a97d4998f09c51eb2b68fff14ff98186dccc07319aace7a59983d3
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-172e939622a97d4998f09c51eb2b68fff14ff98186dccc07319aace7a59983d3
conformance/src/fastify/conformanceApiPlugin.tshttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-3b0d2a73c71d77299adcbabb59d1b67026247a5c6d2dea2d8db55125fec13b93
View file https://github.com/heymb/FacilityJavaScript/blob/499aa473725866cd707cf2e1de6336578f898371/conformance/src/fastify/conformanceApiPlugin.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/FacilityApi/FacilityJavaScript/pull/69/{{ revealButtonHref }}
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-3b0d2a73c71d77299adcbabb59d1b67026247a5c6d2dea2d8db55125fec13b93
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-3b0d2a73c71d77299adcbabb59d1b67026247a5c6d2dea2d8db55125fec13b93
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-3b0d2a73c71d77299adcbabb59d1b67026247a5c6d2dea2d8db55125fec13b93
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-3b0d2a73c71d77299adcbabb59d1b67026247a5c6d2dea2d8db55125fec13b93
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-3b0d2a73c71d77299adcbabb59d1b67026247a5c6d2dea2d8db55125fec13b93
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-3b0d2a73c71d77299adcbabb59d1b67026247a5c6d2dea2d8db55125fec13b93
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-3b0d2a73c71d77299adcbabb59d1b67026247a5c6d2dea2d8db55125fec13b93
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-3b0d2a73c71d77299adcbabb59d1b67026247a5c6d2dea2d8db55125fec13b93
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-3b0d2a73c71d77299adcbabb59d1b67026247a5c6d2dea2d8db55125fec13b93
src/Facility.CodeGen.JavaScript/JavaScriptGenerator.cshttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-576178b24479d766dd3774c5329f82bc46df8c4997c83cadef91db766f2cc05a
View file https://github.com/heymb/FacilityJavaScript/blob/499aa473725866cd707cf2e1de6336578f898371/src/Facility.CodeGen.JavaScript/JavaScriptGenerator.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/FacilityApi/FacilityJavaScript/pull/69/{{ revealButtonHref }}
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-576178b24479d766dd3774c5329f82bc46df8c4997c83cadef91db766f2cc05a
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-576178b24479d766dd3774c5329f82bc46df8c4997c83cadef91db766f2cc05a
tests/Facility.CodeGen.JavaScript.UnitTests/JavaScriptGeneratorTests.cshttps://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-42a1bcd1a0883d99948c5ed5d279b8d771c986702f15a4e1e538163f10016757
View file https://github.com/heymb/FacilityJavaScript/blob/499aa473725866cd707cf2e1de6336578f898371/tests/Facility.CodeGen.JavaScript.UnitTests/JavaScriptGeneratorTests.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/FacilityApi/FacilityJavaScript/pull/69/{{ revealButtonHref }}
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-42a1bcd1a0883d99948c5ed5d279b8d771c986702f15a4e1e538163f10016757
https://github.com/FacilityApi/FacilityJavaScript/pull/69/files#diff-42a1bcd1a0883d99948c5ed5d279b8d771c986702f15a4e1e538163f10016757
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.