| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:79641fe8-360f-b07c-bb5a-e447572dba17 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8920:1DCB8C:A3BA5:DFD99:6B00B96E |
| html-safe-nonce | 5a0857e411d7f4a2e9723c415ba95a67b40f286d55361fa29dfad8bf6a9c52fb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTIwOjFEQ0I4QzpBM0JBNTpERkQ5OTo2QjAwQjk2RSIsInZpc2l0b3JfaWQiOiI1MDczMDk2MjQ1NTk0NTA0NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3bfc510e4489b8634a26951c9f7495b0056934f530263be8d3dc456553b74cae |
| hovercard-subject-tag | pull_request:2001391543 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/FacilityApi/FacilityJavaScript/68/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e2096bd0ebd1465b195d9e2e3ec20bc08d8597f74de0e8f84c6e00f760917767/FacilityApi/FacilityJavaScript/pull/68 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e2096bd0ebd1465b195d9e2e3ec20bc08d8597f74de0e8f84c6e00f760917767/FacilityApi/FacilityJavaScript/pull/68 |
| og:image:alt | Add tests for current TS output of DTOs with "optional" or required fields (see "Required Fields" section, can't hyperlink).
Context: This issue mentions wanting support for... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | heymb |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2 |
| turbo-cache-control | no-cache |
| go-import | github.com/FacilityApi/FacilityJavaScript git https://github.com/FacilityApi/FacilityJavaScript.git |
| octolytics-dimension-user_id | 22828021 |
| octolytics-dimension-user_login | FacilityApi |
| octolytics-dimension-repository_id | 73533359 |
| octolytics-dimension-repository_nwo | FacilityApi/FacilityJavaScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 73533359 |
| octolytics-dimension-repository_network_root_nwo | FacilityApi/FacilityJavaScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5429cbfc6aca8c7b9a086a3c8f47400346f38cc9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/FacilityApi/FacilityJavaScript/pull/68#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FFacilityApi%2FFacilityJavaScript%2Fpull%2F68 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FFacilityApi%2FFacilityJavaScript%2Fpull%2F68 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=FacilityApi%2FFacilityJavaScript |
| Reload | https://github.com/FacilityApi/FacilityJavaScript/pull/68 |
| Reload | https://github.com/FacilityApi/FacilityJavaScript/pull/68 |
| Reload | https://github.com/FacilityApi/FacilityJavaScript/pull/68 |
| FacilityApi | https://github.com/FacilityApi |
| FacilityJavaScript | https://github.com/FacilityApi/FacilityJavaScript |
| Code | https://github.com/FacilityApi/FacilityJavaScript |
| Issues6 (6) | https://github.com/FacilityApi/FacilityJavaScript/issues |
| Pull requests6 (6) | https://github.com/FacilityApi/FacilityJavaScript/pulls |
| Actions | https://github.com/FacilityApi/FacilityJavaScript/actions |
| Security and quality | https://github.com/FacilityApi/FacilityJavaScript/security |
| Insights | https://github.com/FacilityApi/FacilityJavaScript/insights |
| https://github.com/FacilityApi/FacilityJavaScript |
| heymb | https://github.com/heymb |
| FacilityApi:master | https://github.com/FacilityApi/FacilityJavaScript/tree/master |
| heymb:addTestsForDataProperties | https://github.com/heymb/FacilityJavaScript/tree/addTestsForDataProperties |
| Conversation | https://github.com/FacilityApi/FacilityJavaScript/pull/68 |
| Commits1 (1) | https://github.com/FacilityApi/FacilityJavaScript/pull/68/commits |
| Checks | https://github.com/FacilityApi/FacilityJavaScript/pull/68/checks |
| Files changed | https://github.com/FacilityApi/FacilityJavaScript/pull/68/files |
| Add tests for current TS output of DTOs with "optional" and required fields. | https://github.com/FacilityApi/FacilityJavaScript/pull/68#top |
| heymb | https://github.com/heymb |
| FacilityApi:master | https://github.com/FacilityApi/FacilityJavaScript/tree/master |
| heymb:addTestsForDataProperties | https://github.com/heymb/FacilityJavaScript/tree/addTestsForDataProperties |
|
| https://github.com/heymb |
| heymb | https://github.com/heymb |
| Aug 2, 2024 | https://github.com/FacilityApi/FacilityJavaScript/pull/68#issue-2445617714 |
| Please reload this page | https://github.com/FacilityApi/FacilityJavaScript/pull/68 |
| DTOs | https://facilityapi.github.io/define/fsd#data-transfer-objects |
| fields | https://facilityapi.github.io/define/fsd#fields |
| This issue | https://github.com/FacilityApi/FacilityJavaScript/issues/34 |
| others mentioned | https://git.faithlife.dev/Logos/bible-study-builder/pull/174#discussion_r330241 |
| PR | https://github.com/heymb/FacilityJavaScript/pull/1 |
| Please reload this page | https://github.com/FacilityApi/FacilityJavaScript/pull/68 |
| Add tests for current behavior of data properties optional and required. | https://github.com/FacilityApi/FacilityJavaScript/pull/68/commits/e8acb62c25268321820eabd2fbb0ed62d24c1b94 |
| e8acb62 | https://github.com/FacilityApi/FacilityJavaScript/pull/68/commits/e8acb62c25268321820eabd2fbb0ed62d24c1b94 |
| https://github.com/heymb |
| heymb | https://github.com/heymb |
| Aug 2, 2024 | https://github.com/FacilityApi/FacilityJavaScript/pull/68#event-13745829144 |
| https://github.com/heymb |
| heymb | https://github.com/heymb |
|
Aug 2, 2024
| https://github.com/FacilityApi/FacilityJavaScript/pull/68#ref-pullrequest-2445645352 |
|
Support generating required fields as not optional in TS.
heymb/FacilityJavaScript#1
| https://github.com/heymb/FacilityJavaScript/pull/1 |
| https://github.com/heymb |
| heymb | https://github.com/heymb |
| ejball | https://github.com/ejball |
| August 2, 2024 20:04 | https://github.com/FacilityApi/FacilityJavaScript/pull/68#event-13746262232 |
| https://github.com/ejball |
| ejball | https://github.com/ejball |
|
Aug 3, 2024
| https://github.com/FacilityApi/FacilityJavaScript/pull/68#pullrequestreview-2217065281 |
|
View reviewed changes
| https://github.com/FacilityApi/FacilityJavaScript/pull/68/files/e8acb62c25268321820eabd2fbb0ed62d24c1b94 |
| https://github.com/heymb |
| heymb | https://github.com/heymb |
| 6cf4974 | https://github.com/FacilityApi/FacilityJavaScript/commit/6cf497481e4287741ee810c4cb90af64a59dc8be |
| Aug 5, 2024 | https://github.com/FacilityApi/FacilityJavaScript/pull/68#event-13765001654 |
| https://github.com/heymb |
| heymb | https://github.com/heymb |
|
Aug 5, 2024
| https://github.com/FacilityApi/FacilityJavaScript/pull/68#ref-pullrequest-2448715485 |
|
Support DTO required fields as not optional properties on interface in TS.
#69
| https://github.com/FacilityApi/FacilityJavaScript/pull/69 |
| heymb | https://github.com/heymb |
|
Aug 5, 2024
| https://github.com/FacilityApi/FacilityJavaScript/pull/68#ref-commit-265ace3 |
|
| https://github.com/heymb |
| Support DTO required fields as not optional properties on interface i… | https://github.com/FacilityApi/FacilityJavaScript/commit/265ace379b46a457c9c1b13c6d32ec8528e32b33 |
| 265ace3 | https://github.com/FacilityApi/FacilityJavaScript/commit/265ace379b46a457c9c1b13c6d32ec8528e32b33 |
| #69 | https://github.com/FacilityApi/FacilityJavaScript/pull/69 |
| #34 | https://github.com/FacilityApi/FacilityJavaScript/issues/34 |
| #68 | https://github.com/FacilityApi/FacilityJavaScript/pull/68 |
| https://facilityapi.github.io/define/fsd#fields | https://facilityapi.github.io/define/fsd#fields |
| https://facilityapi.github.io/define/fsd#data-transfer-objects | https://facilityapi.github.io/define/fsd#data-transfer-objects |
| https://www.typescriptlang.org/docs/handbook/2/objects.html#optional-properties | https://www.typescriptlang.org/docs/handbook/2/objects.html#optional-properties |
| https://github.com/heymb |
| heymb | https://github.com/heymb |
| August 6, 2024 01:09 | https://github.com/FacilityApi/FacilityJavaScript/pull/68#event-13771319787 |
| https://github.co/hiddenchars |
| https://github.com/FacilityApi/FacilityJavaScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FFacilityApi%2FFacilityJavaScript%2Fpull%2F68 |
|
| https://github.com/ejball |
|
ejball
| https://github.com/ejball |
|
| https://github.com/FacilityApi/FacilityJavaScript/pull/68/files/e8acb62c25268321820eabd2fbb0ed62d24c1b94 |
| Please reload this page | https://github.com/FacilityApi/FacilityJavaScript/pull/68 |
| Please reload this page | https://github.com/FacilityApi/FacilityJavaScript/pull/68 |
|
| https://github.com/heymb |
|
| https://github.com/ejball |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |