| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:34d692f7-4275-e60d-5238-b39d543bc224 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9C40:1C6C3E:13CED8:1AE33E:6B00BC0B |
| html-safe-nonce | 1126bb73ab91669ca3c519d1c79b809d60d3a227a4aa220765c32750f9bfcdcc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzQwOjFDNkMzRToxM0NFRDg6MUFFMzNFOjZCMDBCQzBCIiwidmlzaXRvcl9pZCI6IjQ4MjA2MTY4Nzc1ODk5Njk5MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | befab5f1b1d23fb73b367fa36c8cae4550b8680dfe177d56987fed8488959b29 |
| hovercard-subject-tag | pull_request:1649512795 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/FacilityApi/FacilityJavaScript/59/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b72cc97bde26f1cd3cf0efff9c2e5c48a2dd230b9fe9ea3705324908026e33b8/FacilityApi/FacilityJavaScript/pull/59 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b72cc97bde26f1cd3cf0efff9c2e5c48a2dd230b9fe9ea3705324908026e33b8/FacilityApi/FacilityJavaScript/pull/59 |
| og:image:alt | This PR also gets conformance tests up and running. I chose not to create an Express conformance server, but I would think it would be pretty trivial.
Conformance test methods NOT passing for the g... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mitchknife |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2 |
| turbo-cache-control | no-cache |
| go-import | github.com/FacilityApi/FacilityJavaScript git https://github.com/FacilityApi/FacilityJavaScript.git |
| octolytics-dimension-user_id | 22828021 |
| octolytics-dimension-user_login | FacilityApi |
| octolytics-dimension-repository_id | 73533359 |
| octolytics-dimension-repository_nwo | FacilityApi/FacilityJavaScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 73533359 |
| octolytics-dimension-repository_network_root_nwo | FacilityApi/FacilityJavaScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5429cbfc6aca8c7b9a086a3c8f47400346f38cc9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/FacilityApi/FacilityJavaScript/pull/59#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FFacilityApi%2FFacilityJavaScript%2Fpull%2F59 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FFacilityApi%2FFacilityJavaScript%2Fpull%2F59 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=FacilityApi%2FFacilityJavaScript |
| Reload | https://github.com/FacilityApi/FacilityJavaScript/pull/59 |
| Reload | https://github.com/FacilityApi/FacilityJavaScript/pull/59 |
| Reload | https://github.com/FacilityApi/FacilityJavaScript/pull/59 |
| FacilityApi | https://github.com/FacilityApi |
| FacilityJavaScript | https://github.com/FacilityApi/FacilityJavaScript |
| Code | https://github.com/FacilityApi/FacilityJavaScript |
| Issues6 (6) | https://github.com/FacilityApi/FacilityJavaScript/issues |
| Pull requests6 (6) | https://github.com/FacilityApi/FacilityJavaScript/pulls |
| Actions | https://github.com/FacilityApi/FacilityJavaScript/actions |
| Security and quality | https://github.com/FacilityApi/FacilityJavaScript/security |
| Insights | https://github.com/FacilityApi/FacilityJavaScript/insights |
| https://github.com/FacilityApi/FacilityJavaScript |
| mitchknife | https://github.com/mitchknife |
| FacilityApi:master | https://github.com/FacilityApi/FacilityJavaScript/tree/master |
| mitchknife:fastify | https://github.com/mitchknife/FacilityJavaScript/tree/fastify |
| Conversation | https://github.com/FacilityApi/FacilityJavaScript/pull/59 |
| Commits19 (19) | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits |
| Checks | https://github.com/FacilityApi/FacilityJavaScript/pull/59/checks |
| Files changed | https://github.com/FacilityApi/FacilityJavaScript/pull/59/files |
| Add support for Fastify server plugins. | https://github.com/FacilityApi/FacilityJavaScript/pull/59#top |
| mitchknife | https://github.com/mitchknife |
| FacilityApi:master | https://github.com/FacilityApi/FacilityJavaScript/tree/master |
| mitchknife:fastify | https://github.com/mitchknife/FacilityJavaScript/tree/fastify |
|
| https://github.com/mitchknife |
| mitchknife | https://github.com/mitchknife |
| Dec 19, 2023 | https://github.com/FacilityApi/FacilityJavaScript/pull/59#issue-2047684043 |
| Please reload this page | https://github.com/FacilityApi/FacilityJavaScript/pull/59 |
| mitchknife | https://github.com/mitchknife |
| December 15, 2023 10:37 | https://github.com/FacilityApi/FacilityJavaScript/pull/59#commits-pushed-04b7493 |
|
| https://github.com/mitchknife |
| Make failed expectations more clear in conformanceApiTests.ts. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/04b7493fb7aca8ca603d282bbbcb7f6428dca802 |
| 04b7493 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/04b7493fb7aca8ca603d282bbbcb7f6428dca802 |
|
| https://github.com/mitchknife |
| Clean up conformance test runner. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/b6f838e5672a6fcb20c1fe6798445981f0ca6085 |
| b6f838e | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/b6f838e5672a6fcb20c1fe6798445981f0ca6085 |
|
| https://github.com/mitchknife |
| Add simple working fastify app for conformance tests. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/c11db89a344ef80d47057137aa513874f4cb9fc7 |
| c11db89 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/c11db89a344ef80d47057137aa513874f4cb9fc7 |
|
| https://github.com/mitchknife |
| Add "hand rolled" ConformanceApi plugin. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/b4f1516a3c1fcf1da33a4756999d2556b178f077 |
| b4f1516 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/b4f1516a3c1fcf1da33a4756999d2556b178f077 |
|
| https://github.com/mitchknife |
| Generate fastify plugin shell. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/724ddcaf5c476b007a96d7b050ddfc936224b55a |
| 724ddca | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/724ddcaf5c476b007a96d7b050ddfc936224b55a |
|
| https://github.com/mitchknife |
| Fill out codegen for fastify plugin. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/ae6f3b9a33d7e3e036b12ce351fd180f4e0b2eea |
| ae6f3b9 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/ae6f3b9a33d7e3e036b12ce351fd180f4e0b2eea |
|
| https://github.com/mitchknife |
| Generate separate copy of types for fastify plugin. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/0901688a7cfc5746169561d08ed6e039896e54f2 |
| 0901688 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/0901688a7cfc5746169561d08ed6e039896e54f2 |
|
| https://github.com/mitchknife |
| Consolidate duplicate code into local functions. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/862cc03ff43ab1b2ddcf0d2fd1297899399cbb14 |
| 862cc03 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/862cc03ff43ab1b2ddcf0d2fd1297899399cbb14 |
|
| https://github.com/mitchknife |
| Delete handRolledPlugin.ts | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/9175554cbc812c2685acbf1de925f4477b31365c |
| 9175554 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/9175554cbc812c2685acbf1de925f4477b31365c |
|
| https://github.com/mitchknife |
| Clean up plain js support. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/a7a77ef5cfad818b93f3fe21e7724ed2b36b78b1 |
| a7a77ef | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/a7a77ef5cfad818b93f3fe21e7724ed2b36b78b1 |
|
| https://github.com/mitchknife |
| Restructure conformance folder structure. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/dd18f5a8635b8a3713c4f569944dcaab7b095ae1 |
| dd18f5a | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/dd18f5a8635b8a3713c4f569944dcaab7b095ae1 |
|
| https://github.com/mitchknife |
| Only generate fastify plugin when option is supplied. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/6470f1db36cda44256825c71e2fb197c65775cd7 |
| 6470f1d | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/6470f1db36cda44256825c71e2fb197c65775cd7 |
|
| https://github.com/mitchknife |
| Validate ConformanceTests.json before running tests. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/da680744ce95bb4a526d4903231c0bc8605bae81 |
| da68074 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/da680744ce95bb4a526d4903231c0bc8605bae81 |
|
| https://github.com/mitchknife |
| Support raw http requests in conformance tests. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/26b39c158eba0b75bff33ad6618c6e7969dc98ee |
| 26b39c1 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/26b39c158eba0b75bff33ad6618c6e7969dc98ee |
|
| https://github.com/mitchknife |
| Support case insensitive querystring keys in fastify plugin. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/c576130b3c30bd457664c36b17361b02f73636f0 |
| c576130 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/c576130b3c30bd457664c36b17361b02f73636f0 |
|
| https://github.com/mitchknife |
| Enable case insensitve routing for fastify conformance servers. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/d7bfd596ff383efb4ef782b5485653d5c36b56b0 |
| d7bfd59 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/d7bfd596ff383efb4ef782b5485653d5c36b56b0 |
|
| https://github.com/mitchknife |
| Add service error handling support to fastify plugin. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/610278928d806d12077760406d223035af8c5ae3 |
| 6102789 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/610278928d806d12077760406d223035af8c5ae3 |
|
| https://github.com/mitchknife |
| Add clarifying doc comments. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/c625c24c46f61538d1a9c597d2c4e4dceeb77b15 |
| c625c24 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/c625c24c46f61538d1a9c597d2c4e4dceeb77b15 |
|
| https://github.com/mitchknife |
| Run conformance js and ts fastify plugins together. | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/0c72936001f8deea44767d0234e7e45e95a674e1 |
| 0c72936 | https://github.com/FacilityApi/FacilityJavaScript/pull/59/commits/0c72936001f8deea44767d0234e7e45e95a674e1 |
| https://github.com/mitchknife |
| mitchknife | https://github.com/mitchknife |
| Dec 22, 2023 | https://github.com/FacilityApi/FacilityJavaScript/pull/59#issuecomment-1867116881 |
| @ejball | https://github.com/ejball |
| Please reload this page | https://github.com/FacilityApi/FacilityJavaScript/pull/59 |
| https://github.com/ejball |
| ejball | https://github.com/ejball |
| Dec 29, 2023 | https://github.com/FacilityApi/FacilityJavaScript/pull/59#issuecomment-1872249869 |
| #9 | https://github.com/FacilityApi/FacilityJavaScript/issues/9 |
| Please reload this page | https://github.com/FacilityApi/FacilityJavaScript/pull/59 |
| https://github.com/ejball |
| ejball | https://github.com/ejball |
|
Dec 29, 2023
| https://github.com/FacilityApi/FacilityJavaScript/pull/59#pullrequestreview-1799153274 |
|
View reviewed changes
| https://github.com/FacilityApi/FacilityJavaScript/pull/59/files/0c72936001f8deea44767d0234e7e45e95a674e1 |
| https://github.com/mitchknife |
| mitchknife | https://github.com/mitchknife |
| d17ad41 | https://github.com/FacilityApi/FacilityJavaScript/commit/d17ad419d8b5b2dce1bb7436a69443ccfeab254e |
| Dec 29, 2023 | https://github.com/FacilityApi/FacilityJavaScript/pull/59#event-11358319492 |
| https://github.co/hiddenchars |
| https://github.com/FacilityApi/FacilityJavaScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FFacilityApi%2FFacilityJavaScript%2Fpull%2F59 |
|
| https://github.com/ejball |
|
ejball
| https://github.com/ejball |
|
| https://github.com/FacilityApi/FacilityJavaScript/pull/59/files/0c72936001f8deea44767d0234e7e45e95a674e1 |
| Please reload this page | https://github.com/FacilityApi/FacilityJavaScript/pull/59 |
| Please reload this page | https://github.com/FacilityApi/FacilityJavaScript/pull/59 |
|
| https://github.com/mitchknife |
|
| https://github.com/ejball |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |