Title: Use a separate model for timing relationships · Issue #17 · EuroPython/programapi · GitHub
Open Graph Title: Use a separate model for timing relationships · Issue #17 · EuroPython/programapi
X Title: Use a separate model for timing relationships · Issue #17 · EuroPython/programapi
Description: To me this is mixing too many concerns: Representation of individual submissions Temporal relationship between submissions I would prefer to store the relationships (parallel, before, after, next, previous) in a separate data structure w...
Open Graph Description: To me this is mixing too many concerns: Representation of individual submissions Temporal relationship between submissions I would prefer to store the relationships (parallel, before, after, next, ...
X Description: To me this is mixing too many concerns: Representation of individual submissions Temporal relationship between submissions I would prefer to store the relationships (parallel, before, after, next, ...
Opengraph URL: https://github.com/EuroPython/programapi/issues/17
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Use a separate model for timing relationships","articleBody":"\u003e To me this is mixing too many concerns:\r\n\u003e 1. Representation of individual submissions\r\n\u003e 2. Temporal relationship between submissions\r\n\r\n\u003e I would prefer to store the relationships (parallel, before, after, next, previous) in a separate data structure which references these `PretalxSubmission` objects.\r\n\u003e Then we wouldn't have this situation where creating a \"complete\" `PretalxSubmission` object requires to steps:\r\n\r\n```python\r\nsubmission = PretalxSubmission(...) # call `__init__`, which only initialized a part of the object\r\nsubmission.set_talks_in_parallel(...) # initialize another part of the object\r\nsubmission.set_talks_after(...) # initialize yet another part of the object\r\n[...]\r\n```\r\n\r\n\u003e Field like `talks_in_parallel: list[str] | None = None` can easily cause to accidents: `my_submission.talks_in_parallel` *sometimes* contains the \"talks in parallel to my submission\", depending on *when* I access the field.\r\n\r\n\u003e That would be a non-trivial change, and the current implementation seems to work, so I'm fine with merging it as it is. But let's try to not walk this path much further, else it might get messy 🙂\r\n\r\n_Originally posted by @NMertsch in https://github.com/EuroPython/programapi/pull/6#discussion_r1623253693_\r\n ","author":{"url":"https://github.com/egeakman","@type":"Person","name":"egeakman"},"datePublished":"2024-06-01T20:43:41.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/17/programapi/issues/17"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7abf2fbb-cfe8-0d48-142d-db686915ea9a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A400:3C277B:1E5EA2B:28E354B:6972C5DD |
| html-safe-nonce | bc74bbc52fd424ed93d1777aba96f7b80daa11d2788883bc4154a0f4aae6e02c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDAwOjNDMjc3QjoxRTVFQTJCOjI4RTM1NEI6Njk3MkM1REQiLCJ2aXNpdG9yX2lkIjoiNzg3NTk1ODE5NzA1NzY2ODU3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2ed14c9f533b9cec68c5f6f009580c7e44dc4ec7466181cad4bed980468d6f96 |
| hovercard-subject-tag | issue:2329331624 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/EuroPython/programapi/17/issue_layout |
| twitter:image | https://opengraph.githubassets.com/78c373200ef55f3f42b3bbbf776a160fe7e4035d5e1e0602988296ec5c08dba3/EuroPython/programapi/issues/17 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/78c373200ef55f3f42b3bbbf776a160fe7e4035d5e1e0602988296ec5c08dba3/EuroPython/programapi/issues/17 |
| og:image:alt | To me this is mixing too many concerns: Representation of individual submissions Temporal relationship between submissions I would prefer to store the relationships (parallel, before, after, next, ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | egeakman |
| hostname | github.com |
| expected-hostname | github.com |
| None | aa656e37a6f46b81c2416d9c983f7c54e264ee31be17c0e6c9414b9f9f9c6eb4 |
| turbo-cache-control | no-preview |
| go-import | github.com/EuroPython/programapi git https://github.com/EuroPython/programapi.git |
| octolytics-dimension-user_id | 5538814 |
| octolytics-dimension-user_login | EuroPython |
| octolytics-dimension-repository_id | 797821381 |
| octolytics-dimension-repository_nwo | EuroPython/programapi |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 797821381 |
| octolytics-dimension-repository_network_root_nwo | EuroPython/programapi |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | add6bd61de5b348d2978a698a5796a7d0438e7be |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width