René's URL Explorer Experiment


Title: Fix remaining dead code and stale comments in stackwalker refactor by jbachorik · Pull Request #455 · DataDog/java-profiler · GitHub

Open Graph Title: Fix remaining dead code and stale comments in stackwalker refactor by jbachorik · Pull Request #455 · DataDog/java-profiler

X Title: Fix remaining dead code and stale comments in stackwalker refactor by jbachorik · Pull Request #455 · DataDog/java-profiler

Description: What does this PR do?: Fixes three leftover issues from the stackwalker refactor (#451): Remove Profiler::_runtime_stubs (CodeCache): the field was missed when _stubs_lock, _call_stub_begin, and _call_stub_end were removed. All stub routing moved to JitCodeCache in #451; profiler.cpp has zero remaining references to this field. Update the alignas comment on Profiler that still listed _stubs_lock after its removal. Fix grammar in HotspotSupport::checkFault: "have not been initialized" → "has not been initialized". Motivation: Follow-up from code review of #451. These were identified in the review but not addressed in the main PR's code-review commit. Additional Notes: Depends on #451. How to test the change?: No behaviour change — dead field removal and comment fixes only. Existing tests cover the surrounding code. For Datadog employees: If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance. This PR doesn't touch any of that. JIRA: [JIRA-XXXX] Unsure? Have a question? Request a review! 🤖 Generated with Claude Sonnet on behalf of @jbachorik

Open Graph Description: What does this PR do?: Fixes three leftover issues from the stackwalker refactor (#451): Remove Profiler::_runtime_stubs (CodeCache): the field was missed when _stubs_lock, _call_stub_begin, and _...

X Description: What does this PR do?: Fixes three leftover issues from the stackwalker refactor (#451): Remove Profiler::_runtime_stubs (CodeCache): the field was missed when _stubs_lock, _call_stub_begin, and _...

Opengraph URL: https://github.com/DataDog/java-profiler/pull/455

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:f69f604e-2aa6-d7eb-e365-6202d9e817f3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE956:301411:205B9CF:2BDFA00:6A65587F
html-safe-nonceb4e7b7922f765897f664a2b7cd74e60fb0e3582180131f20a1d150f2605b45bc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTU2OjMwMTQxMToyMDVCOUNGOjJCREZBMDA6NkE2NTU4N0YiLCJ2aXNpdG9yX2lkIjoiOTA3NDc0NDUwMjA4ODE5NDE3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac35ad64c0f7a983ef6573d8d0b1e5c12051d2169d312d7b04088868f4fabf7019
hovercard-subject-tagpull_request:3507689574
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf
twitter:imagehttps://avatars.githubusercontent.com/u/738413?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/738413?s=400&v=4
og:image:altWhat does this PR do?: Fixes three leftover issues from the stackwalker refactor (#451): Remove Profiler::_runtime_stubs (CodeCache): the field was missed when _stubs_lock, _call_stub_begin, and _...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/DataDog/java-profiler git https://github.com/DataDog/java-profiler.git
octolytics-dimension-user_id365230
octolytics-dimension-user_loginDataDog
octolytics-dimension-repository_id585532470
octolytics-dimension-repository_nwoDataDog/java-profiler
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id585532470
octolytics-dimension-repository_network_root_nwoDataDog/java-profiler
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release309153364422b3c499922d1a2a6404910a58ed8e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDataDog%2Fjava-profiler%2Fpull%2F455%2Fcommits%2Ff9f527fa327e9fc37314651400e8fd297552dcbf
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDataDog%2Fjava-profiler%2Fpull%2F455%2Fcommits%2Ff9f527fa327e9fc37314651400e8fd297552dcbf
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=DataDog%2Fjava-profiler
Reloadhttps://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf
Reloadhttps://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf
Reloadhttps://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf
Please reload this pagehttps://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf
DataDog https://github.com/DataDog
java-profilerhttps://github.com/DataDog/java-profiler
Notifications https://github.com/login?return_to=%2FDataDog%2Fjava-profiler
Fork 12 https://github.com/login?return_to=%2FDataDog%2Fjava-profiler
Star 33 https://github.com/login?return_to=%2FDataDog%2Fjava-profiler
Code https://github.com/DataDog/java-profiler
Issues 10 https://github.com/DataDog/java-profiler/issues
Pull requests 20 https://github.com/DataDog/java-profiler/pulls
Actions https://github.com/DataDog/java-profiler/actions
Security and quality 0 https://github.com/DataDog/java-profiler/security
Insights https://github.com/DataDog/java-profiler/pulse
Code https://github.com/DataDog/java-profiler
Issues https://github.com/DataDog/java-profiler/issues
Pull requests https://github.com/DataDog/java-profiler/pulls
Actions https://github.com/DataDog/java-profiler/actions
Security and quality https://github.com/DataDog/java-profiler/security
Insights https://github.com/DataDog/java-profiler/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FDataDog%2Fjava-profiler%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FDataDog%2Fjava-profiler%2Fissues%2Fnew%2Fchoose
jbachorikhttps://github.com/jbachorik
mainhttps://github.com/DataDog/java-profiler/tree/main
jb/refactor-stackwalk-fixeshttps://github.com/DataDog/java-profiler/tree/jb/refactor-stackwalk-fixes
Conversation 2 https://github.com/DataDog/java-profiler/pull/455
Commits 11 https://github.com/DataDog/java-profiler/pull/455/commits
Checks 89 https://github.com/DataDog/java-profiler/pull/455/checks
Files changed https://github.com/DataDog/java-profiler/pull/455/files
Please reload this pagehttps://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf
Fix remaining dead code and stale comments in stackwalker refactor https://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf#top
Show all changes 11 commits https://github.com/DataDog/java-profiler/pull/455/files
df4d238 v0 zhengyu123 Apr 2, 2026 https://github.com/DataDog/java-profiler/pull/455/commits/df4d238fdda40af059722adf14e9da0257e6216c
1088c74 v1 zhengyu123 Apr 3, 2026 https://github.com/DataDog/java-profiler/pull/455/commits/1088c74736eca467e99050cb44a20ac8fce9036f
7f303a7 v2 zhengyu123 Apr 3, 2026 https://github.com/DataDog/java-profiler/pull/455/commits/7f303a749eabf87d28354af531a93d32ee6cdd56
9a9de6c Fix VMMethod::validatedId() crash zhengyu123 Apr 7, 2026 https://github.com/DataDog/java-profiler/pull/455/commits/9a9de6cf2bfde800d9d67d6a382c778fdc3b8cf7
6a5924b Revert previous commit zhengyu123 Apr 7, 2026 https://github.com/DataDog/java-profiler/pull/455/commits/6a5924b08d3cb94bc30b901ad8c1232978a3fd40
44fb879 Fix memory ordering and add comment zhengyu123 Apr 8, 2026 https://github.com/DataDog/java-profiler/pull/455/commits/44fb8799bc7848226fb1761c053787412a12a720
a839b3c Merge branch 'main' into zgu/refactor-stackwalk zhengyu123 Apr 8, 2026 https://github.com/DataDog/java-profiler/pull/455/commits/a839b3c9601b3c85d3fea1e1f19cdcc1fb0ee9b2
b035e63 Code review zhengyu123 Apr 8, 2026 https://github.com/DataDog/java-profiler/pull/455/commits/b035e63c70e54434c866ddd6fd9c1749481080c2
f9f527f Code review zhengyu123 Apr 8, 2026 https://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf
8fabf90 Review by Opus 4.6 zhengyu123 Apr 8, 2026 https://github.com/DataDog/java-profiler/pull/455/commits/8fabf90053ee9e5042b8c69ccc3cdc211ceac60f
f92bf92 Remove dead Profiler::_runtime_stubs field and fix stale comments jbachorik Apr 9, 2026 https://github.com/DataDog/java-profiler/pull/455/commits/f92bf92206811b673c00ca7a99c7980abc6cd32a
Clear filters https://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf
Please reload this pagehttps://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf
Please reload this pagehttps://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf
jvmSupport.cpp https://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf#diff-d4c381fd76dd39e9c9997fc70638009325f15af221b70f32dd3ea4a9ffa698dc
jvmSupport.h https://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf#diff-ee5b0f5634903742ad1ac75cb3e5a421bf92747e733e9b89fe43942bdf4019c1
Prev https://github.com/DataDog/java-profiler/pull/455/commits/b035e63c70e54434c866ddd6fd9c1749481080c2
Next https://github.com/DataDog/java-profiler/pull/455/commits/8fabf90053ee9e5042b8c69ccc3cdc211ceac60f
Please reload this pagehttps://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf
https://github.com/zhengyu123
zhengyu123https://github.com/DataDog/java-profiler/commits?author=zhengyu123
https://github.com/DataDog/java-profiler/blob/main/.github/CODEOWNERS#L4
ddprof-lib/src/main/cpp/jvmSupport.cpphttps://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf#diff-d4c381fd76dd39e9c9997fc70638009325f15af221b70f32dd3ea4a9ffa698dc
View file https://github.com/DataDog/java-profiler/blob/f9f527fa327e9fc37314651400e8fd297552dcbf/ddprof-lib/src/main/cpp/jvmSupport.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/DataDog/java-profiler/pull/455/commits/{{ revealButtonHref }}
https://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf#diff-d4c381fd76dd39e9c9997fc70638009325f15af221b70f32dd3ea4a9ffa698dc
https://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf#diff-d4c381fd76dd39e9c9997fc70638009325f15af221b70f32dd3ea4a9ffa698dc
https://github.com/DataDog/java-profiler/blob/main/.github/CODEOWNERS#L4
ddprof-lib/src/main/cpp/jvmSupport.hhttps://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf#diff-ee5b0f5634903742ad1ac75cb3e5a421bf92747e733e9b89fe43942bdf4019c1
View file https://github.com/DataDog/java-profiler/blob/f9f527fa327e9fc37314651400e8fd297552dcbf/ddprof-lib/src/main/cpp/jvmSupport.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/DataDog/java-profiler/pull/455/commits/{{ revealButtonHref }}
https://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf#diff-ee5b0f5634903742ad1ac75cb3e5a421bf92747e733e9b89fe43942bdf4019c1
https://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf#diff-ee5b0f5634903742ad1ac75cb3e5a421bf92747e733e9b89fe43942bdf4019c1
Please reload this pagehttps://github.com/DataDog/java-profiler/pull/455/commits/f9f527fa327e9fc37314651400e8fd297552dcbf
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.