| Skip to content | https://github.com/DataDog/java-profiler/pull/13#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDataDog%2Fjava-profiler%2Fpull%2F13 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDataDog%2Fjava-profiler%2Fpull%2F13 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=DataDog%2Fjava-profiler |
| Reload | https://github.com/DataDog/java-profiler/pull/13 |
| Reload | https://github.com/DataDog/java-profiler/pull/13 |
| Reload | https://github.com/DataDog/java-profiler/pull/13 |
| Please reload this page | https://github.com/DataDog/java-profiler/pull/13 |
|
DataDog
| https://github.com/DataDog |
| java-profiler | https://github.com/DataDog/java-profiler |
|
Notifications
| https://github.com/login?return_to=%2FDataDog%2Fjava-profiler |
|
Fork
12
| https://github.com/login?return_to=%2FDataDog%2Fjava-profiler |
|
Star
32
| https://github.com/login?return_to=%2FDataDog%2Fjava-profiler |
|
Code
| https://github.com/DataDog/java-profiler |
|
Issues
8
| https://github.com/DataDog/java-profiler/issues |
|
Pull requests
13
| https://github.com/DataDog/java-profiler/pulls |
|
Actions
| https://github.com/DataDog/java-profiler/actions |
|
Security and quality
0
| https://github.com/DataDog/java-profiler/security |
|
Insights
| https://github.com/DataDog/java-profiler/pulse |
|
Code
| https://github.com/DataDog/java-profiler |
|
Issues
| https://github.com/DataDog/java-profiler/issues |
|
Pull requests
| https://github.com/DataDog/java-profiler/pulls |
|
Actions
| https://github.com/DataDog/java-profiler/actions |
|
Security and quality
| https://github.com/DataDog/java-profiler/security |
|
Insights
| https://github.com/DataDog/java-profiler/pulse |
| jbachorik | https://github.com/jbachorik |
| main | https://github.com/DataDog/java-profiler/tree/main |
| rgs/pr-template | https://github.com/DataDog/java-profiler/tree/rgs/pr-template |
| Conversation | https://github.com/DataDog/java-profiler/pull/13 |
| Commits1 (1) | https://github.com/DataDog/java-profiler/pull/13/commits |
| Checks | https://github.com/DataDog/java-profiler/pull/13/checks |
| Files changed | https://github.com/DataDog/java-profiler/pull/13/files |
| add PR template | https://github.com/DataDog/java-profiler/pull/13#top |
| jbachorik | https://github.com/jbachorik |
| main | https://github.com/DataDog/java-profiler/tree/main |
| rgs/pr-template | https://github.com/DataDog/java-profiler/tree/rgs/pr-template |
|
| https://github.com/richardstartin |
| richardstartin | https://github.com/richardstartin |
| Aug 23, 2023 | https://github.com/DataDog/java-profiler/pull/13#issue-1863825088 |
| Please reload this page | https://github.com/DataDog/java-profiler/pull/13 |
|
| https://github.com/richardstartin |
| add PR template | https://github.com/DataDog/java-profiler/pull/13/commits/cdcd8733feeb3fb8bebbc22f0b7463fede4b22e8 |
| cdcd873 | https://github.com/DataDog/java-profiler/pull/13/commits/cdcd8733feeb3fb8bebbc22f0b7463fede4b22e8 |
| https://github.com/richardstartin |
| richardstartin | https://github.com/richardstartin |
| jbachorik | https://github.com/jbachorik |
| Aug 23, 2023 | https://github.com/DataDog/java-profiler/pull/13#event-10173325087 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 23, 2023 | https://github.com/DataDog/java-profiler/pull/13#issuecomment-1690447969 |
| Local variable 'jni' shadows outer function | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmEntry.h#L139 |
| Local variable 'size' shadows outer function | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/callTraceStorage.cpp#L38 |
| Local variable 'prev' shadows outer function | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/callTraceStorage.cpp#L59 |
| Class 'Cleaner' has a constructor with 1 argument that is not explicit. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/classRefCache.h#L115 |
| Variable 'numRefs' is assigned a value that is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/classRefCache.cpp#L28 |
| The class 'NativeFunc' does not declare a constructor although it has private member variables which likely require initialization. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/codeCache.h#L34 |
| Local variable 'i' shadows outer variable | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/codeCache.cpp#L246 |
| Consider using std::transform algorithm instead of a raw loop. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/codeCache.cpp#L241 |
| struct member 'Tag::value' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/context.h#L27 |
| struct member 'ContextPage::capacity' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/context.h#L48 |
| struct member 'ContextPage::storage' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/context.h#L49 |
| Class 'Dictionary' has a constructor with 1 argument that is not explicit. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/dictionary.h#L65 |
| struct member 'DictRow::keys' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/dictionary.h#L34 |
| struct member 'DictRow::next' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/dictionary.h#L35 |
| Local variable 'pc_off' shadows outer variable | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/dwarf.cpp#L278 |
| Class 'WallClockEpochEvent' has a constructor with 1 argument that is not explicit. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/event.h#L80 |
| struct member 'QueueTimeEvent::_start' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/event.h#L153 |
| struct member 'QueueTimeEvent::_end' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/event.h#L154 |
| struct member 'QueueTimeEvent::_task' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/event.h#L155 |
| struct member 'QueueTimeEvent::_scheduler' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/event.h#L156 |
| struct member 'QueueTimeEvent::_origin' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/event.h#L157 |
| The class 'ObjectSampler' does not declare a constructor although it has private member variables which likely require initialization. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/objectSampler.h#L32 |
| The class 'VirtualSpaceSummary' does not declare a constructor although it has private member variables which likely require initialization. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/jvmHeap.h#L23 |
| The class 'GCHeapSummary' does not declare a constructor although it has private member variables which likely require initialization. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/jvmHeap.h#L37 |
| The class 'CollectedHeap' does not declare a constructor although it has private member variables which likely require initialization. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/jvmHeap.h#L55 |
| Class 'Element' has a constructor with 1 argument that is not explicit. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/jfrMetadata.h#L119 |
| Class 'NoField' has a constructor with 1 argument that is not explicit. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/jfrMetadata.h#L156 |
| Class 'MutexLocker' has a constructor with 1 argument that is not explicit. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/mutex.h#L51 |
| Class 'MethodList' has a constructor with 1 argument that is not explicit. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmStructs.h#L182 |
| The function 'is_nofield' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/jfrMetadata.h#L158 |
| The function 'check' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/objectSampler.h#L59 |
| The function 'start' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/objectSampler.h#L60 |
| The function 'stop' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/objectSampler.h#L61 |
| The function 'interval' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/objectSampler.h#L63 |
| Condition 'enabled()' is always false | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/tsc.h#L70 |
| Condition 'usage._maxSize==-1' is always false | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmStructs.h#L467 |
| Variable 'thread_ids' can be declared with const | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/flightRecorder.cpp#L928 |
| struct member 'CpuTime::real' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/flightRecorder.h#L55 |
| struct member 'CpuTime::user' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/flightRecorder.h#L56 |
| struct member 'CpuTime::system' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/flightRecorder.h#L57 |
| The function 'name' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/itimer.h#L38 |
| The function 'interval' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/itimer.h#L42 |
| The function 'check' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/itimer.h#L46 |
| The function 'start' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/itimer.h#L47 |
| The function 'stop' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/itimer.h#L48 |
| The function 'enableEvents' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/itimer.h#L50 |
| The function 'check' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/j9ObjectSampler.h#L25 |
| The function 'start' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/j9ObjectSampler.h#L26 |
| The function 'stop' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/j9ObjectSampler.h#L27 |
| struct member 'jvmtiStackInfoExtended::frame_buffer' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/j9Ext.h#L37 |
| The class 'J9WallClock' does not declare a constructor although it has private member variables which likely require initialization. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/j9WallClock.h#L24 |
| The function 'name' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/j9WallClock.h#L47 |
| The function 'interval' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/j9WallClock.h#L51 |
| The function 'start' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/j9WallClock.h#L59 |
| The function 'stop' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/j9WallClock.h#L60 |
| The function 'enableEvents' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/j9WallClock.h#L62 |
| The function 'name' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/wallClock.h#L66 |
| The function 'interval' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/wallClock.h#L70 |
| The function 'start' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/wallClock.h#L74 |
| The function 'stop' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/wallClock.h#L75 |
| The function 'enableEvents' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/wallClock.h#L77 |
| Condition 'max_heap==-1' is always false | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/livenessTracker.cpp#L145 |
| Condition 'max_heap==-1' is always false | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/livenessTracker.cpp#L162 |
| Condition 'level>=_level' is always true | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/log.cpp#L93 |
| The function 'rewind' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/os_macos.cpp#L58 |
| The function 'next' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/os_macos.cpp#L68 |
| The function 'size' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/os_macos.cpp#L76 |
| The function 'check' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/perfEvents.h#L46 |
| The function 'start' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/perfEvents.h#L47 |
| The function 'stop' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/perfEvents.h#L48 |
| The function 'registerThread' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/perfEvents.h#L51 |
| The function 'unregisterThread' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/perfEvents.h#L52 |
| The function 'interval' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/perfEvents.h#L53 |
| The function 'name' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/perfEvents.h#L57 |
| The function 'enableEvents' overrides a function in a base class but is not marked with a 'override' specifier. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/perfEvents.h#L67 |
| Local variable 'ml' shadows outer variable | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/profiler.cpp#L1002 |
| Local variable 'ml' shadows outer variable | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/profiler.cpp#L1201 |
| Variable 'error' is assigned a value that is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/profiler.cpp#L1059 |
| Variable 'error' is assigned a value that is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/profiler.cpp#L1068 |
| Variable 'error' is assigned a value that is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/profiler.cpp#L1078 |
| Variable 'error' is assigned a value that is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/profiler.cpp#L1264 |
| Unused private function: 'StackFrame::withinCurrentStack' | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/stackFrame.h#L29 |
| Condition 'pc>(const void*)-MIN_VALID_PC' is always true | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/stackWalker.cpp#L78 |
| Condition 'pc>(const void*)-MIN_VALID_PC' is always true | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/stackWalker.cpp#L167 |
| The scope of the variable 'prev_sp' can be reduced. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/stackWalker.cpp#L94 |
| Class 'SymbolDesc' has a constructor with 1 argument that is not explicit. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/symbols_linux.cpp#L42 |
| Class 'MemoryMapDesc' has a constructor with 1 argument that is not explicit. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/symbols_linux.cpp#L63 |
| struct member 'ASGCT_CallTrace::env' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmEntry.h#L70 |
| struct member 'ASGCT_CallTrace::frames' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmEntry.h#L72 |
| struct member 'JVMTIFunctions::unused1' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmEntry.h#L85 |
| struct member 'JVMTIFunctions::unused2' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmEntry.h#L87 |
| The scope of the variable 'delayedCounter' can be reduced. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmStructs.cpp#L606 |
| Variable 'error' is assigned a value that is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmStructs.cpp#L649 |
| Variable 'ctx' can be declared with const | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/wallClock.cpp#L63 |
| The function 'Agent_OnAttach' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmEntry.cpp#L497 |
| The function 'Agent_OnLoad' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmEntry.cpp#L478 |
| The function 'GetJ9vmThread' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/j9Ext.h#L73 |
| The function 'JNI_OnLoad' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmEntry.cpp#L528 |
| The function 'JNI_OnUnload' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmEntry.cpp#L536 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_currentTicks0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L236 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_describeDebugCounters0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L180 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_dump0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L165 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_execute0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L81 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_filterThread0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L113 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_getContextPage0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L127 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_getContextPageOffset0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L133 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_getDebugCounters0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L171 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_getMaxContextPages0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L139 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_getSamples' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L108 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_getTid0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L76 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_recordQueueEnd0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L211 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_recordSettingEvent0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L195 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_recordTrace0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L144 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_registerConstant0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L158 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_stop0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L67 |
| The function 'Java_com_datadoghq_profiler_JavaProfiler_tscFrequency0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/javaApi.cpp#L241 |
| The function 'VMObjectAlloc' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/j9ObjectSampler.cpp#L33 |
| The function '_min' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/livenessTracker.cpp#L194 |
| The function 'appendRecording' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/flightRecorder.cpp#L440 |
| The function 'arg0' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/stackFrame_aarch64.cpp#L48 |
| The function 'arg1' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/stackFrame_aarch64.cpp#L52 |
| The function 'arg3' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/stackFrame_aarch64.cpp#L60 |
| The function 'assign' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/trap.cpp#L34 |
| The function 'body' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmStructs.h#L202 |
| The function 'copyTo' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/flightRecorder.cpp#L287 |
| The function 'covers' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/trap.h#L48 |
| The function 'cpuMonitorCycle' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/flightRecorder.cpp#L410 |
| The function 'cputime' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/os_macos.cpp#L128 |
| The function 'deallocateLineNumberTable' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/flightRecorder.cpp#L55 |
| The function 'describeCounters' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/counters.h#L121 |
| The function 'fileSize' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/os_macos.cpp#L326 |
| The function 'flushJfr' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/profiler.cpp#L1157 |
| The function 'fromHandle' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmStructs.h#L240 |
| The function 'fromMethodID' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmStructs.h#L317 |
| The function 'getCounter' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/counters.h#L91 |
| The function 'getCounters' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/counters.h#L83 |
| The function 'hasClassNames' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmStructs.h#L140 |
| The function 'install' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/trap.h#L56 |
| The function 'isSystemClassLoader' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmEntry.cpp#L414 |
| The function 'is_readable_pointer' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/jvm.cpp#L8 |
| The function 'notify' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/mutex.cpp#L44 |
| The function 'ntoh64' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/os_macos.cpp#L160 |
| The function 'pair' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/trap.cpp#L52 |
| The function 'readCounter' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/perfEvents_macos.cpp#L30 |
| The function 'restartProfiler' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmEntry.cpp#L410 |
| The function 'schedPolicy' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/os_macos.cpp#L182 |
| The function 'uninstall' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/trap.h#L60 |
| The function 'units' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/itimer.h#L34 |
| The function 'updateCounter' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/engine.h#L25 |
| The function 'waitUntil' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/mutex.cpp#L39 |
| The function 'writeListSetting' is never used. | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/flightRecorder.cpp#L657 |
| Please reload this page | https://github.com/DataDog/java-profiler/pull/13 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 23, 2023 | https://github.com/DataDog/java-profiler/pull/13#issuecomment-1690448500 |
| Quantity | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/Quantity#L5 |
| https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/#L1 |
| https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/#L2 |
| https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/#L1 |
| https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/#L1 |
| dwarf.cpp | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/dwarf.cpp#L231 |
| vmStructs.cpp | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/vmStructs.cpp#L649 |
| safeAccess.h | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/safeAccess.h#L35 |
| symbols_linux.cpp | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/symbols_linux.cpp#L154 |
| dwarf.h | https://github.com/DataDog/java-profiler-library/blob/rgs/pr-template/ddprof-lib/src/main/cpp/dwarf.h#L123 |
| Please reload this page | https://github.com/DataDog/java-profiler/pull/13 |
| https://github.com/richardstartin |
| richardstartin | https://github.com/richardstartin |
| jbachorik | https://github.com/jbachorik |
| Aug 23, 2023 | https://github.com/DataDog/java-profiler/pull/13#event-10173873850 |
| https://github.com/richardstartin |
| richardstartin | https://github.com/richardstartin |
| jbachorik | https://github.com/jbachorik |
| August 23, 2023 19:39 | https://github.com/DataDog/java-profiler/pull/13#event-10173874753 |
| https://github.com/jbachorik |
| jbachorik | https://github.com/jbachorik |
|
Aug 24, 2023
| https://github.com/DataDog/java-profiler/pull/13#pullrequestreview-1592853470 |
|
View reviewed changes
| https://github.com/DataDog/java-profiler/pull/13/files/cdcd8733feeb3fb8bebbc22f0b7463fede4b22e8 |
| https://github.com/jbachorik |
| jbachorik | https://github.com/jbachorik |
| Aug 24, 2023 | https://github.com/DataDog/java-profiler/pull/13#issuecomment-1691070136 |
| Please reload this page | https://github.com/DataDog/java-profiler/pull/13 |
| https://github.com/apps/dd-devflow |
| dd-devflow | https://github.com/apps/dd-devflow |
| Aug 24, 2023 | https://github.com/DataDog/java-profiler/pull/13#issuecomment-1691070217 |
| Please reload this page | https://github.com/DataDog/java-profiler/pull/13 |
| https://github.com/apps/dd-devflow |
| dd-devflow | https://github.com/apps/dd-devflow |
|
mergequeue-status: queued
| https://github.com/DataDog/java-profiler/issues?q=state%3Aopen%20label%3A%22mergequeue-status%3A%20queued%22 |
|
mergequeue-status: in_progress
| https://github.com/DataDog/java-profiler/issues?q=state%3Aopen%20label%3A%22mergequeue-status%3A%20in_progress%22 |
|
mergequeue-status: rejected
| https://github.com/DataDog/java-profiler/issues?q=state%3Aopen%20label%3A%22mergequeue-status%3A%20rejected%22 |
|
mergequeue-status: queued
| https://github.com/DataDog/java-profiler/issues?q=state%3Aopen%20label%3A%22mergequeue-status%3A%20queued%22 |
|
mergequeue-status: in_progress
| https://github.com/DataDog/java-profiler/issues?q=state%3Aopen%20label%3A%22mergequeue-status%3A%20in_progress%22 |
| Aug 24, 2023 | https://github.com/DataDog/java-profiler/pull/13#event-10177313482 |
| https://github.com/apps/dd-devflow |
| dd-devflow | https://github.com/apps/dd-devflow |
| Aug 24, 2023 | https://github.com/DataDog/java-profiler/pull/13#issuecomment-1691086457 |
| c67894a | https://github.com/DataDog/java-profiler/commit/c67894a72c48a4f3b32ae62031685996672e0cca |
| #ci-interfaces | https://dd.slack.com/archives/C030ZQHDAJC |
| details | https://atlas.ddbuild.io/namespaces/default/workflows/c0549ad8-acf1-44d5-b441-5a5f47c40d98_46/d7b5cb5d-b1a1-4c39-ba72-47b94edd8872 |
| Please reload this page | https://github.com/DataDog/java-profiler/pull/13 |
| https://github.com/jbachorik |
| jbachorik | https://github.com/jbachorik |
| 32352f7 | https://github.com/DataDog/java-profiler/commit/32352f7cabb55b2942139c589602dc3e75250592 |
| Aug 24, 2023 | https://github.com/DataDog/java-profiler/pull/13#event-10177432626 |
| https://github.com/jbachorik |
| jbachorik | https://github.com/jbachorik |
| August 24, 2023 06:36 | https://github.com/DataDog/java-profiler/pull/13#event-10177433072 |
| jbachorik | https://github.com/jbachorik |
|
May 25, 2026
| https://github.com/DataDog/java-profiler/pull/13#ref-commit-6ef6687 |
|
| https://github.com/jbachorik |
|
| https://github.com/claude |
| fix(profiler): address code-review findings on PR | https://github.com/DataDog/java-profiler/commit/6ef668746c2ca49405f0fd9dfde58b3d16b57d22 |
| #540 | https://github.com/DataDog/java-profiler/pull/540 |
| 6ef6687 | https://github.com/DataDog/java-profiler/commit/6ef668746c2ca49405f0fd9dfde58b3d16b57d22 |
| #8 | https://github.com/DataDog/java-profiler/pull/8 |
| #7 | https://github.com/DataDog/java-profiler/pull/7 |
| #9 | https://github.com/DataDog/java-profiler/pull/9 |
| #4 | https://github.com/DataDog/java-profiler/pull/4 |
| #13 | https://github.com/DataDog/java-profiler/pull/13 |
| #2 | https://github.com/DataDog/java-profiler/issues/2 |
| #14 | https://github.com/DataDog/java-profiler/pull/14 |
| https://github.co/hiddenchars |
| https://github.com/DataDog/java-profiler/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDataDog%2Fjava-profiler%2Fpull%2F13 |
|
| https://github.com/jbachorik |
|
jbachorik
| https://github.com/jbachorik |
|
| https://github.com/DataDog/java-profiler/pull/13/files/cdcd8733feeb3fb8bebbc22f0b7463fede4b22e8 |
|
mergequeue-status: rejected
| https://github.com/DataDog/java-profiler/issues?q=state%3Aopen%20label%3A%22mergequeue-status%3A%20rejected%22 |
| Please reload this page | https://github.com/DataDog/java-profiler/pull/13 |
|
| https://github.com/richardstartin |
|
| https://github.com/jbachorik |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |