René's URL Explorer Experiment


Title: Fix incorrect use of Path.getRoot() by jbachorik · Pull Request #8751 · DataDog/dd-trace-java · GitHub

Open Graph Title: Fix incorrect use of Path.getRoot() by jbachorik · Pull Request #8751 · DataDog/dd-trace-java

X Title: Fix incorrect use of Path.getRoot() by jbachorik · Pull Request #8751 · DataDog/dd-trace-java

Description: Datadog APM client for Java. Contribute to DataDog/dd-trace-java development by creating an account on GitHub.

Open Graph Description: What Does This Do After #8714 the profiling tests started failing. The reason is that the Path.getRoot() will return null for a single element path because it considers it not having a root 🤷 Notes...

X Description: What Does This Do After #8714 the profiling tests started failing. The reason is that the Path.getRoot() will return null for a single element path because it considers it not having a root 🤷 Notes...

Opengraph URL: https://github.com/DataDog/dd-trace-java/pull/8751

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:157a4410-317c-e262-018c-70652f91f951
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC364:32F7EE:23823B:32C290:6A4CCD92
html-safe-noncee2c638f1c2c209a38ae69d0f29630d296aee8b782a9df4381ea3b65558926fb9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzY0OjMyRjdFRToyMzgyM0I6MzJDMjkwOjZBNENDRDkyIiwidmlzaXRvcl9pZCI6IjcxOTA0MzY3OTE5MjAxNTE5NTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9c2b7c874ec62518a27eabfa618a0d214eab25254205e77831aa6d8fb4e5be4a
hovercard-subject-tagpull_request:2489166593
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/DataDog/dd-trace-java/8751/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b5138e284d6ae0402151b1d1c7cda01f0d0d99131a7ad7eccbd0932e159ac4f7/DataDog/dd-trace-java/pull/8751
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b5138e284d6ae0402151b1d1c7cda01f0d0d99131a7ad7eccbd0932e159ac4f7/DataDog/dd-trace-java/pull/8751
og:image:altWhat Does This Do After #8714 the profiling tests started failing. The reason is that the Path.getRoot() will return null for a single element path because it considers it not having a root 🤷 Notes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejbachorik
hostnamegithub.com
expected-hostnamegithub.com
Noneee8a9d18044a05fe2d57b9ae797da38c8be34effb03f015f7c42e94770d28a1b
turbo-cache-controlno-cache
go-importgithub.com/DataDog/dd-trace-java git https://github.com/DataDog/dd-trace-java.git
octolytics-dimension-user_id365230
octolytics-dimension-user_loginDataDog
octolytics-dimension-repository_id89221572
octolytics-dimension-repository_nwoDataDog/dd-trace-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id89221572
octolytics-dimension-repository_network_root_nwoDataDog/dd-trace-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef84814acc6f036583fd43463f5847a846243d2a4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/DataDog/dd-trace-java/pull/8751#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDataDog%2Fdd-trace-java%2Fpull%2F8751
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDataDog%2Fdd-trace-java%2Fpull%2F8751
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=DataDog%2Fdd-trace-java
Reloadhttps://github.com/DataDog/dd-trace-java/pull/8751
Reloadhttps://github.com/DataDog/dd-trace-java/pull/8751
Reloadhttps://github.com/DataDog/dd-trace-java/pull/8751
Please reload this pagehttps://github.com/DataDog/dd-trace-java/pull/8751
DataDog https://github.com/DataDog
dd-trace-javahttps://github.com/DataDog/dd-trace-java
Notifications https://github.com/login?return_to=%2FDataDog%2Fdd-trace-java
Fork 343 https://github.com/login?return_to=%2FDataDog%2Fdd-trace-java
Star 725 https://github.com/login?return_to=%2FDataDog%2Fdd-trace-java
Code https://github.com/DataDog/dd-trace-java
Issues 250 https://github.com/DataDog/dd-trace-java/issues
Pull requests 150 https://github.com/DataDog/dd-trace-java/pulls
Actions https://github.com/DataDog/dd-trace-java/actions
Security and quality 2 https://github.com/DataDog/dd-trace-java/security
Insights https://github.com/DataDog/dd-trace-java/pulse
Code https://github.com/DataDog/dd-trace-java
Issues https://github.com/DataDog/dd-trace-java/issues
Pull requests https://github.com/DataDog/dd-trace-java/pulls
Actions https://github.com/DataDog/dd-trace-java/actions
Security and quality https://github.com/DataDog/dd-trace-java/security
Insights https://github.com/DataDog/dd-trace-java/pulse
jbachorikhttps://github.com/jbachorik
masterhttps://github.com/DataDog/dd-trace-java/tree/master
jb/temp_files_fixhttps://github.com/DataDog/dd-trace-java/tree/jb/temp_files_fix
Conversationhttps://github.com/DataDog/dd-trace-java/pull/8751
Commits2 (2)https://github.com/DataDog/dd-trace-java/pull/8751/commits
Checkshttps://github.com/DataDog/dd-trace-java/pull/8751/checks
Files changedhttps://github.com/DataDog/dd-trace-java/pull/8751/files
Fix incorrect use of Path.getRoot()https://github.com/DataDog/dd-trace-java/pull/8751#top
jbachorikhttps://github.com/jbachorik
masterhttps://github.com/DataDog/dd-trace-java/tree/master
jb/temp_files_fixhttps://github.com/DataDog/dd-trace-java/tree/jb/temp_files_fix
https://github.com/jbachorik
jbachorikhttps://github.com/jbachorik
Apr 29, 2025https://github.com/DataDog/dd-trace-java/pull/8751#issue-3028665905
Please reload this pagehttps://github.com/DataDog/dd-trace-java/pull/8751
#8714https://github.com/DataDog/dd-trace-java/pull/8714
according the contribution guidelineshttps://github.com/DataDog/dd-trace-java/blob/master/CONTRIBUTING.md#title-format
any usefull labelshttps://github.com/DataDog/dd-trace-java/blob/master/CONTRIBUTING.md#labels
linking keywordshttps://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
milestonehttps://github.com/DataDog/dd-trace-java/milestones
public documentationhttps://docs.datadoghq.com/tracing/trace_collection/library_config/java/
Please reload this pagehttps://github.com/DataDog/dd-trace-java/pull/8751
https://github.com/jbachorik
Fix incorrect use of Path.getRoot()https://github.com/DataDog/dd-trace-java/pull/8751/commits/b7ab377435891260c5a8700c05078b2cd055957e
b7ab377https://github.com/DataDog/dd-trace-java/pull/8751/commits/b7ab377435891260c5a8700c05078b2cd055957e
https://github.com/jbachorik
jbachorikhttps://github.com/jbachorik
type: bug fix https://github.com/DataDog/dd-trace-java/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%20fix%22
tag: no release notes https://github.com/DataDog/dd-trace-java/issues?q=state%3Aopen%20label%3A%22tag%3A%20no%20release%20notes%22
comp: profiling https://github.com/DataDog/dd-trace-java/issues?q=state%3Aopen%20label%3A%22comp%3A%20profiling%22
Apr 29, 2025https://github.com/DataDog/dd-trace-java/pull/8751#event-17457506062
https://github.com/jbachorik
jbachorikhttps://github.com/jbachorik
force-pushedhttps://github.com/DataDog/dd-trace-java/compare/f46900495cb466560ad37393fcb8bc40f070c53e..b7ab377435891260c5a8700c05078b2cd055957e
f469004https://github.com/DataDog/dd-trace-java/commit/f46900495cb466560ad37393fcb8bc40f070c53e
b7ab377https://github.com/DataDog/dd-trace-java/commit/b7ab377435891260c5a8700c05078b2cd055957e
Compare https://github.com/DataDog/dd-trace-java/compare/f46900495cb466560ad37393fcb8bc40f070c53e..b7ab377435891260c5a8700c05078b2cd055957e
April 29, 2025 14:57https://github.com/DataDog/dd-trace-java/pull/8751#event-17457506427
https://github.com/jbachorik
jbachorikhttps://github.com/jbachorik
code ownershttps://github.com/DataDog/dd-trace-java/blob/74633afbc675fc247e9d9ebd796b307829cb71e0/.github/CODEOWNERS#L11
April 29, 2025 14:57https://github.com/DataDog/dd-trace-java/pull/8751#event-17457506448
https://github.com/apps/pr-commenter
pr-commenterhttps://github.com/apps/pr-commenter
Apr 29, 2025https://github.com/DataDog/dd-trace-java/pull/8751#issuecomment-2839414789
Please reload this pagehttps://github.com/DataDog/dd-trace-java/pull/8751
74633afhttps://github.com/DataDog/dd-trace-java/commit/74633afbc675fc247e9d9ebd796b307829cb71e0
cf7859dhttps://github.com/DataDog/dd-trace-java/commit/cf7859dddad8df1c57b4370486d73ed4b653db79
#26https://github.com/DataDog/dd-trace-java/pull/26
#26https://github.com/DataDog/dd-trace-java/pull/26
74633afhttps://github.com/DataDog/dd-trace-java/commit/74633afbc675fc247e9d9ebd796b307829cb71e0
cf7859dhttps://github.com/DataDog/dd-trace-java/commit/cf7859dddad8df1c57b4370486d73ed4b653db79
#26https://github.com/DataDog/dd-trace-java/pull/26
#26https://github.com/DataDog/dd-trace-java/pull/26
74633afhttps://github.com/DataDog/dd-trace-java/commit/74633afbc675fc247e9d9ebd796b307829cb71e0
cf7859dhttps://github.com/DataDog/dd-trace-java/commit/cf7859dddad8df1c57b4370486d73ed4b653db79
#26https://github.com/DataDog/dd-trace-java/pull/26
#26https://github.com/DataDog/dd-trace-java/pull/26
Please reload this pagehttps://github.com/DataDog/dd-trace-java/pull/8751
https://github.com/jbachorik
Adjust testshttps://github.com/DataDog/dd-trace-java/pull/8751/commits/cf7859dddad8df1c57b4370486d73ed4b653db79
cf7859dhttps://github.com/DataDog/dd-trace-java/pull/8751/commits/cf7859dddad8df1c57b4370486d73ed4b653db79
https://github.com/mcculls
mccullshttps://github.com/mcculls
Apr 29, 2025 https://github.com/DataDog/dd-trace-java/pull/8751#pullrequestreview-2804623146
View reviewed changes https://github.com/DataDog/dd-trace-java/pull/8751/files/cf7859dddad8df1c57b4370486d73ed4b653db79
https://github.com/jbachorik
jbachorikhttps://github.com/jbachorik
37f0190https://github.com/DataDog/dd-trace-java/commit/37f0190f1943f6aa8fd8c1d45e6225d2dca8b425
Apr 29, 2025https://github.com/DataDog/dd-trace-java/pull/8751#event-17460758485
https://github.com/jbachorik
jbachorikhttps://github.com/jbachorik
April 29, 2025 18:36https://github.com/DataDog/dd-trace-java/pull/8751#event-17460759247
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
1.49.0https://github.com/DataDog/dd-trace-java/milestone/254
Apr 29, 2025https://github.com/DataDog/dd-trace-java/pull/8751#event-17460760805
https://github.co/hiddenchars
https://github.com/DataDog/dd-trace-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDataDog%2Fdd-trace-java%2Fpull%2F8751
https://github.com/mcculls
mcculls https://github.com/mcculls
https://github.com/DataDog/dd-trace-java/pull/8751/files/cf7859dddad8df1c57b4370486d73ed4b653db79
comp: profiling https://github.com/DataDog/dd-trace-java/issues?q=state%3Aopen%20label%3A%22comp%3A%20profiling%22
tag: no release notes https://github.com/DataDog/dd-trace-java/issues?q=state%3Aopen%20label%3A%22tag%3A%20no%20release%20notes%22
type: bug fix https://github.com/DataDog/dd-trace-java/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%20fix%22
1.49.0 https://github.com/DataDog/dd-trace-java/milestone/254
Please reload this pagehttps://github.com/DataDog/dd-trace-java/pull/8751
https://github.com/jbachorik
https://github.com/mcculls
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.