Title: feat(aap): update tags on inferred spans for API Gateway by florentinl · Pull Request #697 · DataDog/datadog-lambda-python · GitHub
Open Graph Title: feat(aap): update tags on inferred spans for API Gateway by florentinl · Pull Request #697 · DataDog/datadog-lambda-python
X Title: feat(aap): update tags on inferred spans for API Gateway by florentinl · Pull Request #697 · DataDog/datadog-lambda-python
Description: What does this PR do? It updates tags for API Gateway Rest Proxy and HTTP API inferred spans, to enable discovery by both the APM Endpoint Catalog and the API Gateway Catalog: From the RFC: For API Gateway v1 and v2: remove operation_name switch span_type to "web" [NOT Specified by the RFC] set "http.useragent" (instead of http.user_agent or when missing); this is the tag specified in the "Span attributes" page of APM ( and the tag that is used by the system-tests to correlate spans with requests, this helps testing this feature there and is more "conformant") For all inferred spans (necessary only for API Gateway, but works the same everywhere so might as well do it): add dd_resource_key tag to inferred spans with the event_source_arn [NOT Specified by the RFC] set the _dd.inferred_span metric, the backend filters inferred spans for the APM Catalog (and the AAP Catalog) based on this metric. It is already set by tracers for the API Gateway proxy inferred spans. Motivation This PR implements tags updates for RFC-1081. The goal is be able to use API Gateway lambda inferred spans for endpoint discovery and correlation in the AppSec API Catalog. Testing Guidelines unit tests: updated snapshot tests: updated system-tests done but not merged yet: http://github.com/DataDog/system-tests/pull/5830 Additional Notes I haven't removed apiname yet as it is not required and might break something somewhere. If a serverless reviewer can confirm that we don't need it anymore, let's remove it now. Types of Changes Bug fix New feature Breaking change (removal of operation_name and changing type of inferred spans from http to web) Misc (docs, refactoring, dependency upgrade, etc.) Check all that apply This PR's description is comprehensive This PR contains breaking changes that are documented in the description This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future This PR impacts documentation, and it has been updated (or a ticket has been logged) This PR's changes are covered by the automated tests This PR collects user input/sensitive content into Datadog This PR passes the integration tests (ask a Datadog member to run the tests)
Open Graph Description: What does this PR do? It updates tags for API Gateway Rest Proxy and HTTP API inferred spans, to enable discovery by both the APM Endpoint Catalog and the API Gateway Catalog: From the RFC: For ...
X Description: What does this PR do? It updates tags for API Gateway Rest Proxy and HTTP API inferred spans, to enable discovery by both the APM Endpoint Catalog and the API Gateway Catalog: From the RFC: For ...
Opengraph URL: https://github.com/DataDog/datadog-lambda-python/pull/697
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7b50e3f3-fbd6-4929-726e-bdf185390591 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8E9A:2010FD:10794F7:155087A:6990C8C1 |
| html-safe-nonce | 7a1209ce9c6b64ffdee02dea17ab126216418e5db695570fad07d20a1595d225 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTlBOjIwMTBGRDoxMDc5NEY3OjE1NTA4N0E6Njk5MEM4QzEiLCJ2aXNpdG9yX2lkIjoiMTA0MjA2NjU1MzYzMjI0NTk1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2858a95c2799ca1544c43b43d6022f9a6e27ed591d5190ad5ae80eb70ccc53ac |
| hovercard-subject-tag | pull_request:3075268809 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/DataDog/datadog-lambda-python/pull/697/files |
| twitter:image | https://avatars.githubusercontent.com/u/101594032?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/101594032?s=400&v=4 |
| og:image:alt | What does this PR do? It updates tags for API Gateway Rest Proxy and HTTP API inferred spans, to enable discovery by both the APM Endpoint Catalog and the API Gateway Catalog: From the RFC: For ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/DataDog/datadog-lambda-python git https://github.com/DataDog/datadog-lambda-python.git |
| octolytics-dimension-user_id | 365230 |
| octolytics-dimension-user_login | DataDog |
| octolytics-dimension-repository_id | 183265904 |
| octolytics-dimension-repository_nwo | DataDog/datadog-lambda-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 183265904 |
| octolytics-dimension-repository_network_root_nwo | DataDog/datadog-lambda-python |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width