René's URL Explorer Experiment


Title: feat(aap): update tags on inferred spans for API Gateway by florentinl · Pull Request #697 · DataDog/datadog-lambda-python · GitHub

Open Graph Title: feat(aap): update tags on inferred spans for API Gateway by florentinl · Pull Request #697 · DataDog/datadog-lambda-python

X Title: feat(aap): update tags on inferred spans for API Gateway by florentinl · Pull Request #697 · DataDog/datadog-lambda-python

Description: What does this PR do? It updates tags for API Gateway Rest Proxy and HTTP API inferred spans, to enable discovery by both the APM Endpoint Catalog and the API Gateway Catalog: From the RFC: For API Gateway v1 and v2: remove operation_name switch span_type to "web" [NOT Specified by the RFC] set "http.useragent" (instead of http.user_agent or when missing); this is the tag specified in the "Span attributes" page of APM ( and the tag that is used by the system-tests to correlate spans with requests, this helps testing this feature there and is more "conformant") For all inferred spans (necessary only for API Gateway, but works the same everywhere so might as well do it): add dd_resource_key tag to inferred spans with the event_source_arn [NOT Specified by the RFC] set the _dd.inferred_span metric, the backend filters inferred spans for the APM Catalog (and the AAP Catalog) based on this metric. It is already set by tracers for the API Gateway proxy inferred spans. Motivation This PR implements tags updates for RFC-1081. The goal is be able to use API Gateway lambda inferred spans for endpoint discovery and correlation in the AppSec API Catalog. Testing Guidelines unit tests: updated snapshot tests: updated system-tests done but not merged yet: http://github.com/DataDog/system-tests/pull/5830 Additional Notes I haven't removed apiname yet as it is not required and might break something somewhere. If a serverless reviewer can confirm that we don't need it anymore, let's remove it now. Types of Changes Bug fix New feature Breaking change (removal of operation_name and changing type of inferred spans from http to web) Misc (docs, refactoring, dependency upgrade, etc.) Check all that apply This PR's description is comprehensive This PR contains breaking changes that are documented in the description This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future This PR impacts documentation, and it has been updated (or a ticket has been logged) This PR's changes are covered by the automated tests This PR collects user input/sensitive content into Datadog This PR passes the integration tests (ask a Datadog member to run the tests)

Open Graph Description: What does this PR do? It updates tags for API Gateway Rest Proxy and HTTP API inferred spans, to enable discovery by both the APM Endpoint Catalog and the API Gateway Catalog: From the RFC: For ...

X Description: What does this PR do? It updates tags for API Gateway Rest Proxy and HTTP API inferred spans, to enable discovery by both the APM Endpoint Catalog and the API Gateway Catalog: From the RFC: For ...

Opengraph URL: https://github.com/DataDog/datadog-lambda-python/pull/697

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:fecabef1-6cfd-3fbb-2d45-849721186a84
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-id8A12:3B5BF:EDF798:130BA45:69906C9B
html-safe-nonce4028275540766da7853a72208a112661f941c935317e20f6c33dac561361ffb1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTEyOjNCNUJGOkVERjc5ODoxMzBCQTQ1OjY5OTA2QzlCIiwidmlzaXRvcl9pZCI6IjI2NzUwMzY3NDYxODY1MTc2NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac40902898d9c7bf31084e6b19c4ab76cdacf381b61938e59ea6f7afda4706c61d
hovercard-subject-tagpull_request:3075268809
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/DataDog/datadog-lambda-python/pull/697/checks
twitter:imagehttps://avatars.githubusercontent.com/u/101594032?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/101594032?s=400&v=4
og:image:altWhat does this PR do? It updates tags for API Gateway Rest Proxy and HTTP API inferred spans, to enable discovery by both the APM Endpoint Catalog and the API Gateway Catalog: From the RFC: For ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-preview
go-importgithub.com/DataDog/datadog-lambda-python git https://github.com/DataDog/datadog-lambda-python.git
octolytics-dimension-user_id365230
octolytics-dimension-user_loginDataDog
octolytics-dimension-repository_id183265904
octolytics-dimension-repository_nwoDataDog/datadog-lambda-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id183265904
octolytics-dimension-repository_network_root_nwoDataDog/datadog-lambda-python
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/DataDog/datadog-lambda-python/pull/697/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDataDog%2Fdatadog-lambda-python%2Fpull%2F697%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDataDog%2Fdatadog-lambda-python%2Fpull%2F697%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=DataDog%2Fdatadog-lambda-python
Reloadhttps://github.com/DataDog/datadog-lambda-python/pull/697/checks
Reloadhttps://github.com/DataDog/datadog-lambda-python/pull/697/checks
Reloadhttps://github.com/DataDog/datadog-lambda-python/pull/697/checks
DataDog https://github.com/DataDog
datadog-lambda-pythonhttps://github.com/DataDog/datadog-lambda-python
Notifications https://github.com/login?return_to=%2FDataDog%2Fdatadog-lambda-python
Fork 47 https://github.com/login?return_to=%2FDataDog%2Fdatadog-lambda-python
Star 97 https://github.com/login?return_to=%2FDataDog%2Fdatadog-lambda-python
Code https://github.com/DataDog/datadog-lambda-python
Issues 5 https://github.com/DataDog/datadog-lambda-python/issues
Pull requests 12 https://github.com/DataDog/datadog-lambda-python/pulls
Actions https://github.com/DataDog/datadog-lambda-python/actions
Security 0 https://github.com/DataDog/datadog-lambda-python/security
Insights https://github.com/DataDog/datadog-lambda-python/pulse
Code https://github.com/DataDog/datadog-lambda-python
Issues https://github.com/DataDog/datadog-lambda-python/issues
Pull requests https://github.com/DataDog/datadog-lambda-python/pulls
Actions https://github.com/DataDog/datadog-lambda-python/actions
Security https://github.com/DataDog/datadog-lambda-python/security
Insights https://github.com/DataDog/datadog-lambda-python/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FDataDog%2Fdatadog-lambda-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FDataDog%2Fdatadog-lambda-python%2Fissues%2Fnew%2Fchoose
florentinlhttps://github.com/florentinl
mainhttps://github.com/DataDog/datadog-lambda-python/tree/main
florentin.labelle/APPSEC-60048/apigw-inferred-span-correlationhttps://github.com/DataDog/datadog-lambda-python/tree/florentin.labelle/APPSEC-60048/apigw-inferred-span-correlation
Conversation 1 https://github.com/DataDog/datadog-lambda-python/pull/697
Commits 1 https://github.com/DataDog/datadog-lambda-python/pull/697/commits
Checks 38 https://github.com/DataDog/datadog-lambda-python/pull/697/checks
Files changed https://github.com/DataDog/datadog-lambda-python/pull/697/files
Please reload this pagehttps://github.com/DataDog/datadog-lambda-python/pull/697/checks
Please reload this pagehttps://github.com/DataDog/datadog-lambda-python/pull/697/checks
feat(aap): update tags on inferred spans for API Gateway https://github.com/DataDog/datadog-lambda-python/pull/697/checks#top
Please reload this pagehttps://github.com/DataDog/datadog-lambda-python/pull/697/checks
devflow/mergegate https://github.com/DataDog/datadog-lambda-python/pull/697/checks?check_run_id=57562660600
build on: pull_request https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244180
lint https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244180/job/57562665786?pr=697
unit-test (3.8) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244180/job/57562666001?pr=697
unit-test (3.9) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244180/job/57562665941?pr=697
unit-test (3.10) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244180/job/57562665911?pr=697
unit-test (3.11) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244180/job/57562665923?pr=697
unit-test (3.12) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244180/job/57562665942?pr=697
unit-test (3.13) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244180/job/57562665938?pr=697
unit-test (3.14) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244180/job/57562665946?pr=697
CodeQL on: pull_request https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244182
Analyze (python) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244182/job/57562665666?pr=697
Build Layers for system-Tests on: pull_request https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209
get-ddtrace-run-id https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562665698?pr=697
build (arm64, 3.9) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562675099?pr=697
build (arm64, 3.10) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562675069?pr=697
build (arm64, 3.11) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562675121?pr=697
build (arm64, 3.12) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562675092?pr=697
build (arm64, 3.13) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562675089?pr=697
build (arm64, 3.14) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562675083?pr=697
build (amd64, 3.9) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562675131?pr=697
build (amd64, 3.10) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562675084?pr=697
build (amd64, 3.11) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562675136?pr=697
build (amd64, 3.12) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562675115?pr=697
build (amd64, 3.13) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562675142?pr=697
build (amd64, 3.14) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244209/job/57562675145?pr=697
System Tests on: pull_request https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406
build https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57562666405?pr=697
system-tests / Get parameters / Get parameters https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57562795903?pr=697
system-tests / parametric https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57562838851?pr=697
system-tests / Build end-to-end (alb) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57562838553?pr=697
system-tests / Build end-to-end (alb-multi) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57562838534?pr=697
system-tests / Build end-to-end (apigw-http) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57562838585?pr=697
system-tests / Build end-to-end (apigw-rest) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57562838592?pr=697
system-tests / Build end-to-end (function-url) https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57562838543?pr=697
system-tests / End-to-end #1 / alb 1 https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57563002114?pr=697
system-tests / End-to-end #1 / alb-multi 1 https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57563001928?pr=697
system-tests / End-to-end #1 / apigw-http 1 https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57563001813?pr=697
system-tests / End-to-end #1 / apigw-rest 1 https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57563001734?pr=697
system-tests / End-to-end #1 / function-url 1 https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57563001863?pr=697
system-tests / Report failures https://github.com/DataDog/datadog-lambda-python/actions/runs/20068244406/job/57563230072?pr=697
CodeQL https://github.com/DataDog/datadog-lambda-python/pull/697/checks?check_run_id=57562778337
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.