Title: fix(http): http.url tag should contain the path by florentinl · Pull Request #663 · DataDog/datadog-lambda-python · GitHub
Open Graph Title: fix(http): http.url tag should contain the path by florentinl · Pull Request #663 · DataDog/datadog-lambda-python
X Title: fix(http): http.url tag should contain the path by florentinl · Pull Request #663 · DataDog/datadog-lambda-python
Description: What does this PR do? The http.url_details.path tag is set by the backend as described in the span attributes guide of APM. When set by this tracer, it is replaced by the backend by a value parsed from the http.url which is always /. Here is an example of a trace received from an API Gateway event where the route can be correctly determined but the path is wrongly set for this reason: The path should be appended to the http.url tag instead. Motivation In the App and API Protection security traces explorer, we show the endpoint and the path is reported incorrectly for this reason. instead of the expected: Testing Guidelines Updated snapshots Updated unit tests Tested with API Gateway events where scheme and host are extracted Tested with ALB events where http.url is only set to the path Additional Notes Types of Changes Bug fix New feature Breaking change Misc (docs, refactoring, dependency upgrade, etc.) Check all that apply This PR's description is comprehensive This PR contains breaking changes that are documented in the description This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future This PR impacts documentation, and it has been updated (or a ticket has been logged) This PR's changes are covered by the automated tests This PR collects user input/sensitive content into Datadog This PR passes the integration tests (ask a Datadog member to run the tests)
Open Graph Description: What does this PR do? The http.url_details.path tag is set by the backend as described in the span attributes guide of APM. When set by this tracer, it is replaced by the backend by a value parsed ...
X Description: What does this PR do? The http.url_details.path tag is set by the backend as described in the span attributes guide of APM. When set by this tracer, it is replaced by the backend by a value parsed ...
Opengraph URL: https://github.com/DataDog/datadog-lambda-python/pull/663
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:89ecb2ec-2991-7b49-346b-dbe81262f2e0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF70:2866B5:2F0E8:3C8ED:6991D289 |
| html-safe-nonce | 09980ac8e05f1524ea2bd3f760b97d2928823063158ad4ef6533cb3a69da1d0c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjcwOjI4NjZCNToyRjBFODozQzhFRDo2OTkxRDI4OSIsInZpc2l0b3JfaWQiOiI3NzgyOTYxOTg0NjE4NzQ2NTA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a133b06997909cb2a56174b41a80d47bc174591c0ed21dc4fe8a515e9b5faeb2 |
| hovercard-subject-tag | pull_request:2900068226 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/DataDog/datadog-lambda-python/pull/663/files |
| twitter:image | https://avatars.githubusercontent.com/u/101594032?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/101594032?s=400&v=4 |
| og:image:alt | What does this PR do? The http.url_details.path tag is set by the backend as described in the span attributes guide of APM. When set by this tracer, it is replaced by the backend by a value parsed ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/DataDog/datadog-lambda-python git https://github.com/DataDog/datadog-lambda-python.git |
| octolytics-dimension-user_id | 365230 |
| octolytics-dimension-user_login | DataDog |
| octolytics-dimension-repository_id | 183265904 |
| octolytics-dimension-repository_nwo | DataDog/datadog-lambda-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 183265904 |
| octolytics-dimension-repository_network_root_nwo | DataDog/datadog-lambda-python |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width