René's URL Explorer Experiment


Title: Refactor gm-unit: DRY up appearance modifier logic in editor_body.lua by sizzlins · Pull Request #1594 · DFHack/scripts · GitHub

Open Graph Title: Refactor gm-unit: DRY up appearance modifier logic in editor_body.lua by sizzlins · Pull Request #1594 · DFHack/scripts

X Title: Refactor gm-unit: DRY up appearance modifier logic in editor_body.lua by sizzlins · Pull Request #1594 · DFHack/scripts

Description: DFHack scripts. Contribute to DFHack/scripts development by creating an account on GitHub.

Open Graph Description: This PR is a cleanup and refactor of internal/gm-unit/editor_body.lua to remove duplicated code and follow standard DRY Created unified setModifier and getModifier methods that intelligently handle...

X Description: This PR is a cleanup and refactor of internal/gm-unit/editor_body.lua to remove duplicated code and follow standard DRY Created unified setModifier and getModifier methods that intelligently handle...

Opengraph URL: https://github.com/DFHack/scripts/pull/1594

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5dd0a4ae-7ca2-b820-d494-3d3d302fd779
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA07A:368D70:1C1CF8:248F48:6AFF8441
html-safe-nonce804ec3aa81116ab1f9d25a4a14aab9cbaff0139e8b2d93f8f2237e84dcdccd45
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDdBOjM2OEQ3MDoxQzFDRjg6MjQ4RjQ4OjZBRkY4NDQxIiwidmlzaXRvcl9pZCI6IjYwMjczNTkyODQ3MjcwOTc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac58932726d6511622e7cea83e06ec224daccbd26aea6aac118bb27449d3c6f189
hovercard-subject-tagpull_request:3924133613
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/DFHack/scripts/1594/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/300bc73dd630c388c476df5ec405fcc26ac4c1406328c663e6dce3d5d6b7df6a/DFHack/scripts/pull/1594
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/300bc73dd630c388c476df5ec405fcc26ac4c1406328c663e6dce3d5d6b7df6a/DFHack/scripts/pull/1594
og:image:altThis PR is a cleanup and refactor of internal/gm-unit/editor_body.lua to remove duplicated code and follow standard DRY Created unified setModifier and getModifier methods that intelligently handle...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesizzlins
hostnamegithub.com
expected-hostnamegithub.com
None19488db4031f00b04ea79b4c70b5dd32cfa873a8d20b3877f3896b8e2d195946
turbo-cache-controlno-cache
go-importgithub.com/DFHack/scripts git https://github.com/DFHack/scripts.git
octolytics-dimension-user_id5777323
octolytics-dimension-user_loginDFHack
octolytics-dimension-repository_id54066125
octolytics-dimension-repository_nwoDFHack/scripts
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id54066125
octolytics-dimension-repository_network_root_nwoDFHack/scripts
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7952f5285f4ba685d70c4c7540ad3cc9dc9746b8
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/DFHack/scripts/pull/1594#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDFHack%2Fscripts%2Fpull%2F1594
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDFHack%2Fscripts%2Fpull%2F1594
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=DFHack%2Fscripts
Reloadhttps://github.com/DFHack/scripts/pull/1594
Reloadhttps://github.com/DFHack/scripts/pull/1594
Reloadhttps://github.com/DFHack/scripts/pull/1594
DFHackhttps://github.com/DFHack
scriptshttps://github.com/DFHack/scripts
Codehttps://github.com/DFHack/scripts
Pull requests67 (67)https://github.com/DFHack/scripts/pulls
Actionshttps://github.com/DFHack/scripts/actions
Security and qualityhttps://github.com/DFHack/scripts/security
Insightshttps://github.com/DFHack/scripts/insights
https://github.com/DFHack/scripts
sizzlinshttps://github.com/sizzlins
DFHack:masterhttps://github.com/DFHack/scripts/tree/master
sizzlins:refactor/gm-unit-editor-bodyhttps://github.com/sizzlins/scripts/tree/refactor/gm-unit-editor-body
Conversationhttps://github.com/DFHack/scripts/pull/1594
Commits7 (7)https://github.com/DFHack/scripts/pull/1594/commits
Checkshttps://github.com/DFHack/scripts/pull/1594/checks
Files changedhttps://github.com/DFHack/scripts/pull/1594/files
Refactor gm-unit: DRY up appearance modifier logic in editor_body.luahttps://github.com/DFHack/scripts/pull/1594#top
sizzlinshttps://github.com/sizzlins
DFHack:masterhttps://github.com/DFHack/scripts/tree/master
sizzlins:refactor/gm-unit-editor-bodyhttps://github.com/sizzlins/scripts/tree/refactor/gm-unit-editor-body
https://github.com/sizzlins
sizzlinshttps://github.com/sizzlins
Jun 24, 2026https://github.com/DFHack/scripts/pull/1594#issue-4730717731
Please reload this pagehttps://github.com/DFHack/scripts/pull/1594
sizzlinshttps://github.com/sizzlins
April 25, 2026 08:51https://github.com/DFHack/scripts/pull/1594#commits-pushed-bc88106
https://github.com/sizzlins
Fix gm-unit: dynamically update size_cur when modifying body appearancehttps://github.com/DFHack/scripts/pull/1594/commits/bc88106c8cdd9669bb05d3fa400eadfd1c26aa8a
bc88106https://github.com/DFHack/scripts/pull/1594/commits/bc88106c8cdd9669bb05d3fa400eadfd1c26aa8a
https://github.com/sizzlins
Fix mixed line endings in editor_body.lua for CIhttps://github.com/DFHack/scripts/pull/1594/commits/def0dc09a8d319bad65a2286d5fce3d3e456bd6d
def0dc0https://github.com/DFHack/scripts/pull/1594/commits/def0dc09a8d319bad65a2286d5fce3d3e456bd6d
https://github.com/sizzlins
Refactor body size recalculation to use DRY functionhttps://github.com/DFHack/scripts/pull/1594/commits/4f34ab48a49149a777ca16f717c8d054caf812ac
4f34ab4https://github.com/DFHack/scripts/pull/1594/commits/4f34ab48a49149a777ca16f717c8d054caf812ac
https://github.com/sizzlins
Refactor editor_body.lua to use unified setModifier/getModifierhttps://github.com/DFHack/scripts/pull/1594/commits/fa1bccf976e27039035a7ad896140718616d71d4
fa1bccfhttps://github.com/DFHack/scripts/pull/1594/commits/fa1bccf976e27039035a7ad896140718616d71d4
https://github.com/sizzlins
sizzlinshttps://github.com/sizzlins
Jun 24, 2026 https://github.com/DFHack/scripts/pull/1594#ref-pullrequest-4326637444
Fix gm-unit: dynamically update size_cur when modifying body appearance #1582 https://github.com/DFHack/scripts/pull/1582
sizzlinshttps://github.com/sizzlins
June 24, 2026 08:11https://github.com/DFHack/scripts/pull/1594#commits-pushed-3f2f0cb
https://github.com/sizzlins
Merge branch 'DFHack:master' into refactor/gm-unit-editor-bodyhttps://github.com/DFHack/scripts/pull/1594/commits/3f2f0cbaf26cd8798c9043afdf5d2eee49204a4b
3f2f0cbhttps://github.com/DFHack/scripts/pull/1594/commits/3f2f0cbaf26cd8798c9043afdf5d2eee49204a4b
https://github.com/sizzlins
Refactor editor_body.lua to use DRY modifier objects and restrict bod…https://github.com/DFHack/scripts/pull/1594/commits/3804da07db8aa01f1fb15187bfcf8ae24e130c6c
3804da0https://github.com/DFHack/scripts/pull/1594/commits/3804da07db8aa01f1fb15187bfcf8ae24e130c6c
https://github.com/sizzlins
Fix mixed line endings for CIhttps://github.com/DFHack/scripts/pull/1594/commits/dcf55c095ba985bb37d1f71492f881a384381376
dcf55c0https://github.com/DFHack/scripts/pull/1594/commits/dcf55c095ba985bb37d1f71492f881a384381376
https://github.com/chdoc
chdochttps://github.com/chdoc
Aug 9, 2026 https://github.com/DFHack/scripts/pull/1594#pullrequestreview-4891728982
View reviewed changes https://github.com/DFHack/scripts/pull/1594/files/dcf55c095ba985bb37d1f71492f881a384381376
chdochttps://github.com/chdoc
https://github.com/DFHack/scripts/pull/1594#pullrequestreview-4891728982
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/DFHack/scripts/pull/1594
internal/gm-unit/editor_body.luahttps://github.com/DFHack/scripts/pull/1594/files/dcf55c095ba985bb37d1f71492f881a384381376#diff-a0ecae25e54e286c71cbb6e75370f226ee4e6863f3e35989f9462179536c5112
chdochttps://github.com/chdoc
Aug 9, 2026https://github.com/DFHack/scripts/pull/1594#discussion_r3744288851
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/DFHack/scripts/pull/1594
https://github.com/chdoc
chdochttps://github.com/chdoc
wait:first-contribution https://github.com/DFHack/scripts/issues?q=state%3Aopen%20label%3Await%3Afirst-contribution
Aug 11, 2026https://github.com/DFHack/scripts/pull/1594#event-29294148552
https://github.com/chdoc
chdochttps://github.com/chdoc
Aug 11, 2026https://github.com/DFHack/scripts/pull/1594#issuecomment-5256415144
Please reload this pagehttps://github.com/DFHack/scripts/pull/1594
https://github.co/hiddenchars
https://github.com/DFHack/scripts/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FDFHack%2Fscripts%2Fpull%2F1594
https://github.com/chdoc
chdoc https://github.com/chdoc
https://github.com/DFHack/scripts/pull/1594/files/dcf55c095ba985bb37d1f71492f881a384381376
Please reload this pagehttps://github.com/DFHack/scripts/pull/1594
wait:first-contribution https://github.com/DFHack/scripts/issues?q=state%3Aopen%20label%3Await%3Afirst-contribution
Please reload this pagehttps://github.com/DFHack/scripts/pull/1594
https://github.com/sizzlins
https://github.com/chdoc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.