Title: StoreFile not honored · Issue #27 · ConvertAPI/convertapi-library-ruby · GitHub
Open Graph Title: StoreFile not honored · Issue #27 · ConvertAPI/convertapi-library-ruby
X Title: StoreFile not honored · Issue #27 · ConvertAPI/convertapi-library-ruby
Description: The following code: result = ConvertApi.convert('txt', { File: document.url, StoreFile: false, RemoveHeadersFooters: true }, from_format: 'pdf') makes a call to the url with &StoreFile=true. I think the problem is here: https://github.co...
Open Graph Description: The following code: result = ConvertApi.convert('txt', { File: document.url, StoreFile: false, RemoveHeadersFooters: true }, from_format: 'pdf') makes a call to the url with &StoreFile=true. I thin...
X Description: The following code: result = ConvertApi.convert('txt', { File: document.url, StoreFile: false, RemoveHeadersFooters: true }, from_format: 'pdf') makes a call to the url with &St...
Opengraph URL: https://github.com/ConvertAPI/convertapi-library-ruby/issues/27
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"StoreFile not honored","articleBody":"The following code:\r\n```\r\n result = ConvertApi.convert('txt', { File: document.url, StoreFile: false, RemoveHeadersFooters: true }, from_format: 'pdf')\r\n```\r\nmakes a call to the url with \u0026StoreFile=true. \r\n\r\nI think the problem is here: https://github.com/ConvertAPI/convertapi-ruby/blob/88ed026ac1679829f48cb36157c4127457d18a9f/lib/convert_api/task.rb#L11\r\n\r\nI think you merge default parameters over top user parameters when you should be doing the merge the other way.\r\n\r\nThis seems like kind of a security risk having it this way especially since your documentation at: https://www.convertapi.com/pdf-to-txt#snippet=ruby clearly states that the default is false not true. ","author":{"url":"https://github.com/ramaboo","@type":"Person","name":"ramaboo"},"datePublished":"2024-03-01T19:42:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/27/convertapi-library-ruby/issues/27"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:434e1fd2-9b25-ddcd-e983-699d82d9f683 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A3DC:25AFF0:17F1D38:1ED3FE2:697FD126 |
| html-safe-nonce | 4333adf2567b183001e436b8e1bb9c34b6f5f924ed887f789d18faa0538fb815 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0RDOjI1QUZGMDoxN0YxRDM4OjFFRDNGRTI6Njk3RkQxMjYiLCJ2aXNpdG9yX2lkIjoiODYzMTA4ODIxMDE5MTA0NDkwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7fc9425d33fc7a2c1031bdabba63cfeafb27aec1d4d9e9b9d13ea330cdd8e09f |
| hovercard-subject-tag | issue:2164060298 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/ConvertAPI/convertapi-library-ruby/27/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3a996f19d36e43dba8377b1b37b31b2e397aac13ed3c51c5eb2f338a29d679b9/ConvertAPI/convertapi-library-ruby/issues/27 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3a996f19d36e43dba8377b1b37b31b2e397aac13ed3c51c5eb2f338a29d679b9/ConvertAPI/convertapi-library-ruby/issues/27 |
| og:image:alt | The following code: result = ConvertApi.convert('txt', { File: document.url, StoreFile: false, RemoveHeadersFooters: true }, from_format: 'pdf') makes a call to the url with &StoreFile=true. I thin... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ramaboo |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| go-import | github.com/ConvertAPI/convertapi-library-ruby git https://github.com/ConvertAPI/convertapi-library-ruby.git |
| octolytics-dimension-user_id | 37071453 |
| octolytics-dimension-user_login | ConvertAPI |
| octolytics-dimension-repository_id | 133849236 |
| octolytics-dimension-repository_nwo | ConvertAPI/convertapi-library-ruby |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 133849236 |
| octolytics-dimension-repository_network_root_nwo | ConvertAPI/convertapi-library-ruby |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width