René's URL Explorer Experiment


Title: Support comment in json key value by zhiyuanliang-ms · Pull Request #205 · Azure/AppConfiguration-JavaScriptProvider · GitHub

Open Graph Title: Support comment in json key value by zhiyuanliang-ms · Pull Request #205 · Azure/AppConfiguration-JavaScriptProvider

X Title: Support comment in json key value by zhiyuanliang-ms · Pull Request #205 · Azure/AppConfiguration-JavaScriptProvider

Description: Why this PR? 671 The reason why we use stripComments instead of parse from jsonc-parser is that jsonc-parser.parse is too tolerant for syntax error, it will always return a result which will bring ...

Open Graph Description: Why this PR? 671 The reason why we use stripComments instead of parse from jsonc-parser is that jsonc-parser.parse is too tolerant for syntax error, it will always return a result which will bring ...

X Description: Why this PR? 671 The reason why we use stripComments instead of parse from jsonc-parser is that jsonc-parser.parse is too tolerant for syntax error, it will always return a result which will bring ...

Opengraph URL: https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7acffbd4-2667-2965-5611-bf14ce3ecf88
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDDE:3365D:6EF5B0:923BA5:698EBD95
html-safe-nonceb53b37257d5db4643ac5b1a8bb697b7a276331f79e12620bd4ca2f41e6761493
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRERFOjMzNjVEOjZFRjVCMDo5MjNCQTU6Njk4RUJEOTUiLCJ2aXNpdG9yX2lkIjoiOTIwOTE0MjE0MTk1OTE5MTk1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb3d1486d344d857dbd9bdbc8d46d8819c488d4f02c807534621f73241cc60528
hovercard-subject-tagpull_request:2709103066
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/Azure/AppConfiguration-JavaScriptProvider/205/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/838fdbc46a8515b4a8033c3277962d0cc40078d45309facc870cf3454c8bfce7/Azure/AppConfiguration-JavaScriptProvider/pull/205
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/838fdbc46a8515b4a8033c3277962d0cc40078d45309facc870cf3454c8bfce7/Azure/AppConfiguration-JavaScriptProvider/pull/205
og:image:altWhy this PR? 671 The reason why we use stripComments instead of parse from jsonc-parser is that jsonc-parser.parse is too tolerant for syntax error, it will always return a result which will bring ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezhiyuanliang-ms
hostnamegithub.com
expected-hostnamegithub.com
Nonecb2828a801ee6b7be618f3ac76fbf55def35bbc30f053a9c41bf90210b8b72ba
turbo-cache-controlno-preview
go-importgithub.com/Azure/AppConfiguration-JavaScriptProvider git https://github.com/Azure/AppConfiguration-JavaScriptProvider.git
octolytics-dimension-user_id6844498
octolytics-dimension-user_loginAzure
octolytics-dimension-repository_id688057518
octolytics-dimension-repository_nwoAzure/AppConfiguration-JavaScriptProvider
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id688057518
octolytics-dimension-repository_network_root_nwoAzure/AppConfiguration-JavaScriptProvider
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6b91a7e6e46287d26887e3fb7a4161657bab8f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAzure%2FAppConfiguration-JavaScriptProvider%2Fpull%2F205
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAzure%2FAppConfiguration-JavaScriptProvider%2Fpull%2F205
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=Azure%2FAppConfiguration-JavaScriptProvider
Reloadhttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
Reloadhttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
Reloadhttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
Azure https://github.com/Azure
AppConfiguration-JavaScriptProviderhttps://github.com/Azure/AppConfiguration-JavaScriptProvider
Notifications https://github.com/login?return_to=%2FAzure%2FAppConfiguration-JavaScriptProvider
Fork 5 https://github.com/login?return_to=%2FAzure%2FAppConfiguration-JavaScriptProvider
Star 17 https://github.com/login?return_to=%2FAzure%2FAppConfiguration-JavaScriptProvider
Code https://github.com/Azure/AppConfiguration-JavaScriptProvider
Issues 8 https://github.com/Azure/AppConfiguration-JavaScriptProvider/issues
Pull requests 1 https://github.com/Azure/AppConfiguration-JavaScriptProvider/pulls
Actions https://github.com/Azure/AppConfiguration-JavaScriptProvider/actions
Projects 0 https://github.com/Azure/AppConfiguration-JavaScriptProvider/projects
Models https://github.com/Azure/AppConfiguration-JavaScriptProvider/models
Security 0 https://github.com/Azure/AppConfiguration-JavaScriptProvider/security
Insights https://github.com/Azure/AppConfiguration-JavaScriptProvider/pulse
Code https://github.com/Azure/AppConfiguration-JavaScriptProvider
Issues https://github.com/Azure/AppConfiguration-JavaScriptProvider/issues
Pull requests https://github.com/Azure/AppConfiguration-JavaScriptProvider/pulls
Actions https://github.com/Azure/AppConfiguration-JavaScriptProvider/actions
Projects https://github.com/Azure/AppConfiguration-JavaScriptProvider/projects
Models https://github.com/Azure/AppConfiguration-JavaScriptProvider/models
Security https://github.com/Azure/AppConfiguration-JavaScriptProvider/security
Insights https://github.com/Azure/AppConfiguration-JavaScriptProvider/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FAzure%2FAppConfiguration-JavaScriptProvider%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FAzure%2FAppConfiguration-JavaScriptProvider%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#issue-comment-box
zhiyuanliang-mshttps://github.com/zhiyuanliang-ms
mainhttps://github.com/Azure/AppConfiguration-JavaScriptProvider/tree/main
zhiyuanliang/support-jsonchttps://github.com/Azure/AppConfiguration-JavaScriptProvider/tree/zhiyuanliang/support-jsonc
Support comment in json key value https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#top
zhiyuanliang-mshttps://github.com/zhiyuanliang-ms
mainhttps://github.com/Azure/AppConfiguration-JavaScriptProvider/tree/main
zhiyuanliang/support-jsonchttps://github.com/Azure/AppConfiguration-JavaScriptProvider/tree/zhiyuanliang/support-jsonc
Conversation 7 https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
Commits 5 https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/commits
Checks 6 https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/checks
Files changed https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files
Please reload this pagehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
https://github.co/hiddenchars
https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/{{ revealButtonHref }}
https://github.com/zhiyuanliang-ms
zhiyuanliang-mshttps://github.com/zhiyuanliang-ms
Jul 31, 2025https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#issue-3279292742
Please reload this pagehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
671https://github.com/Azure/AppConfiguration-DotnetProvider/issues/671
Please reload this pagehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
zhiyuanliang-mshttps://github.com/zhiyuanliang-ms
July 31, 2025 14:34https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#commits-pushed-d274366
https://github.com/zhiyuanliang-ms
support comment in json key valuehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/commits/d274366bd63fe0ee9d2919ba2fbefa852127c87a
d274366https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/commits/d274366bd63fe0ee9d2919ba2fbefa852127c87a
https://github.com/zhiyuanliang-ms
Merge branch 'main' ofhttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/commits/6e6f299ee5c34b47b0f7c35f7fc743dd8b6667a5
https://github.com/Azure/AppConfiguration-Java…https://github.com/Azure/AppConfiguration-JavaScriptProvider
6e6f299https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/commits/6e6f299ee5c34b47b0f7c35f7fc743dd8b6667a5
…ScriptProviderhttps://github.com/Azure/AppConfiguration-JavaScriptProvider
https://github.com/RichardChen820
RichardChen820https://github.com/RichardChen820
Jul 31, 2025 https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#pullrequestreview-3074785320
View reviewed changes https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/6e6f299ee5c34b47b0f7c35f7fc743dd8b6667a5
https://github.com/rossgrambo
rossgrambohttps://github.com/rossgrambo
Jul 31, 2025 https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#pullrequestreview-3077191424
View reviewed changes https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/6e6f299ee5c34b47b0f7c35f7fc743dd8b6667a5
src/JsonKeyValueAdapter.tshttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/6e6f299ee5c34b47b0f7c35f7fc743dd8b6667a5#diff-1d1d415a019818f971568091720cc43ad1d883f97cf34e406a6c2d415fafc235
Please reload this pagehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
https://github.com/rossgrambo
rossgrambohttps://github.com/rossgrambo
Aug 1, 2025https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#issuecomment-3141674292
Please reload this pagehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
https://github.com/rossgrambo
rossgrambohttps://github.com/rossgrambo
Aug 1, 2025 https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#pullrequestreview-3077193294
View reviewed changes https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/6e6f299ee5c34b47b0f7c35f7fc743dd8b6667a5
https://github.com/zhiyuanliang-ms
zhiyuanliang-mshttps://github.com/zhiyuanliang-ms
Aug 1, 2025https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#issuecomment-3141869793
Please reload this pagehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
@rossgrambohttps://github.com/rossgrambo
Please reload this pagehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
https://github.com/zhiyuanliang-ms
update testcasehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/commits/8c838bc66a93707f749e900879ba3fd5f7de64a4
8c838bchttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/commits/8c838bc66a93707f749e900879ba3fd5f7de64a4
https://github.com/jimmyca15
jimmyca15https://github.com/jimmyca15
Aug 5, 2025 https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#pullrequestreview-3089561269
View reviewed changes https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/8c838bc66a93707f749e900879ba3fd5f7de64a4
src/JsonKeyValueAdapter.tshttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/8c838bc66a93707f749e900879ba3fd5f7de64a4#diff-1d1d415a019818f971568091720cc43ad1d883f97cf34e406a6c2d415fafc235
Please reload this pagehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
https://github.com/jimmyca15
jimmyca15https://github.com/jimmyca15
Aug 5, 2025 https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#pullrequestreview-3089561417
View reviewed changes https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/8c838bc66a93707f749e900879ba3fd5f7de64a4
https://github.com/zhiyuanliang-ms
strip comment only when normal parse failedhttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/commits/1ea1ff0a9695ef2398c486dae74c383a737db79c
1ea1ff0https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/commits/1ea1ff0a9695ef2398c486dae74c383a737db79c
https://github.com/jimmyca15
jimmyca15https://github.com/jimmyca15
Aug 6, 2025 https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#pullrequestreview-3093422105
View reviewed changes https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/1ea1ff0a9695ef2398c486dae74c383a737db79c
src/JsonKeyValueAdapter.tshttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/1ea1ff0a9695ef2398c486dae74c383a737db79c#diff-1d1d415a019818f971568091720cc43ad1d883f97cf34e406a6c2d415fafc235
Please reload this pagehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
https://github.com/jimmyca15
jimmyca15https://github.com/jimmyca15
Aug 6, 2025 https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#pullrequestreview-3093423069
View reviewed changes https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/50c755a49d270b78bdbef8e6fc2075d2a963f9f1
https://github.com/zhiyuanliang-ms
Merge branch 'main' into zhiyuanliang/support-jsonchttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/commits/50c755a49d270b78bdbef8e6fc2075d2a963f9f1
50c755ahttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/commits/50c755a49d270b78bdbef8e6fc2075d2a963f9f1
https://github.com/zhiyuanliang-ms
zhiyuanliang-mshttps://github.com/zhiyuanliang-ms
c6acf18https://github.com/Azure/AppConfiguration-JavaScriptProvider/commit/c6acf1800125b316dd9f92a7e361ba7b78845774
Aug 7, 2025https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#event-19025340315
Please reload this pagehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
https://github.com/zhiyuanliang-ms
zhiyuanliang-mshttps://github.com/zhiyuanliang-ms
August 7, 2025 02:55https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205#event-19025342088
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAzure%2FAppConfiguration-JavaScriptProvider%2Fpull%2F205
https://github.com/jimmyca15
jimmyca15 https://github.com/jimmyca15
https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/1ea1ff0a9695ef2398c486dae74c383a737db79c
https://github.com/rossgrambo
rossgrambo https://github.com/rossgrambo
https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/6e6f299ee5c34b47b0f7c35f7fc743dd8b6667a5
https://github.com/RichardChen820
RichardChen820 https://github.com/RichardChen820
https://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205/files/6e6f299ee5c34b47b0f7c35f7fc743dd8b6667a5
Please reload this pagehttps://github.com/Azure/AppConfiguration-JavaScriptProvider/pull/205
https://github.com/zhiyuanliang-ms
https://github.com/rossgrambo
https://github.com/jimmyca15
https://github.com/RichardChen820
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.