Title: createInternalActionId > actionIdCount reaching long.MaxValue · Issue #276 · AsterNET/AsterNET · GitHub
Open Graph Title: createInternalActionId > actionIdCount reaching long.MaxValue · Issue #276 · AsterNET/AsterNET
X Title: createInternalActionId > actionIdCount reaching long.MaxValue · Issue #276 · AsterNET/AsterNET
Description: Hi, We have noticed that when actionIdCount reaches long max value this can cause serious issues that include timeouts. When the count reaches max value, and then is incremented it switches to negative values and can cause collisions. Wh...
Open Graph Description: Hi, We have noticed that when actionIdCount reaches long max value this can cause serious issues that include timeouts. When the count reaches max value, and then is incremented it switches to nega...
X Description: Hi, We have noticed that when actionIdCount reaches long max value this can cause serious issues that include timeouts. When the count reaches max value, and then is incremented it switches to nega...
Opengraph URL: https://github.com/AsterNET/AsterNET/issues/276
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"createInternalActionId > actionIdCount reaching long.MaxValue","articleBody":"Hi,\r\n\r\nWe have noticed that when actionIdCount reaches long max value this can cause serious issues that include timeouts.\r\nWhen the count reaches max value, and then is incremented it switches to negative values and can cause collisions.\r\n\r\nWhat I did to fix it is change the method to the below. \r\nCould this be included in the next release please if you agree on this protection?\r\n\r\n```c#\r\nprivate string createInternalActionId()\r\n{\r\n\tlock (string.Intern(\"CONNECTIONMANAGER::createInternalActionId::actionIdCount\"))\r\n\t{\r\n\t\tif (actionIdCount >= long.MaxValue-1)\r\n\t\t{\r\n\t\t\tactionIdCount = 0;\r\n\t\t}\r\n\t\treturn this.GetHashCode() + \"_\" + (this.actionIdCount++);\r\n\t}\r\n}\r\n```","author":{"url":"https://github.com/nomz0101","@type":"Person","name":"nomz0101"},"datePublished":"2023-09-06T12:34:39Z","url":"https://github.com/AsterNET/AsterNET/issues/276"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b834e6ce-d494-ef2a-214e-1ddf953890ae |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 968A:3D53D8:FEBD86:15C862E:6AFB6352 |
| html-safe-nonce | db02d414a437930baad6555ab6d3a40f98b9b407773a43ab66602cdb0eeda350 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjhBOjNENTNEODpGRUJEODY6MTVDODYyRTo2QUZCNjM1MiIsInZpc2l0b3JfaWQiOiIzMTk0Nzc3MDczNzc2MDI2NDUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e46b3d9a6664384292f7b9fc02650feef56935d88ab242d8d46b28645a04cdf6 |
| hovercard-subject-tag | issue:1883922136 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/AsterNET/AsterNET/276/issue_layout |
| twitter:image | https://opengraph.githubassets.com/81fc1abdd78912c699d164b548cafb9600f82c2771edb431a7b563952019896e/AsterNET/AsterNET/issues/276 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/81fc1abdd78912c699d164b548cafb9600f82c2771edb431a7b563952019896e/AsterNET/AsterNET/issues/276 |
| og:image:alt | Hi, We have noticed that when actionIdCount reaches long max value this can cause serious issues that include timeouts. When the count reaches max value, and then is incremented it switches to nega... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nomz0101 |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| go-import | github.com/AsterNET/AsterNET git https://github.com/AsterNET/AsterNET.git |
| octolytics-dimension-user_id | 18189401 |
| octolytics-dimension-user_login | AsterNET |
| octolytics-dimension-repository_id | 28722690 |
| octolytics-dimension-repository_nwo | AsterNET/AsterNET |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 28722690 |
| octolytics-dimension-repository_network_root_nwo | AsterNET/AsterNET |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width