Title: Accessibility issues · Issue #73 · AssemblyScript/website · GitHub
Open Graph Title: Accessibility issues · Issue #73 · AssemblyScript/website
X Title: Accessibility issues · Issue #73 · AssemblyScript/website
Description: Loving the documentation so far (especially the emojis). But the docs site clips in a lot of places when adhering to WCAG 2.x AA font-size criteria. Also, the left sidebar/table of contents is HUGE: ⅓ the total viewport width, and about ...
Open Graph Description: Loving the documentation so far (especially the emojis). But the docs site clips in a lot of places when adhering to WCAG 2.x AA font-size criteria. Also, the left sidebar/table of contents is HUGE...
X Description: Loving the documentation so far (especially the emojis). But the docs site clips in a lot of places when adhering to WCAG 2.x AA font-size criteria. Also, the left sidebar/table of contents is HUGE...
Opengraph URL: https://github.com/AssemblyScript/website/issues/73
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Accessibility issues","articleBody":"Loving the documentation so far (especially the emojis).\r\n\r\nBut the docs site clips in a lot of places when adhering to WCAG 2.x AA font-size criteria.\r\n\r\nAlso, the left sidebar/table of contents is HUGE: ⅓ the total viewport width, and about ½ of the sidebar is empty space (because its width is set to an explicit, arbitrary width of 20em). This could be resolved by simply setting `width: fit-content` (or not setting anything at all). The rest of the site doesn't automatically adapt to use that newly available space because of various `position: fixed`s. Flexbox would resolve this (in a much more accessible and responsive way, with much, much less code):\r\n\r\n```css\r\nhtml,\r\nbody,\r\n#app,\r\n.theme-container\r\n{\r\n height: 100%;\r\n overflow: hidden;\r\n}\r\n\r\nmain {\r\n max-height: 100%;\r\n overflow-y: auto;\r\n}\r\n\r\n.theme-container {\r\n display: flex;\r\n flex-direction: row;\r\n flex-wrap: wrap;\r\n}\r\n\r\n.navbar {\r\n display: flex;\r\n flex: none;\r\n width: 100%;\r\n}\r\n\r\n.sidebar,\r\nmain\r\n{\r\n max-height: 100%;\r\n overflow-y: auto;\r\n}\r\n\r\nmain { flex: 1 }\r\n```\r\n\r\nThe above styles assume the various `position: fixed` and related properties have been removed. Also, much of those styles should be wrapped in a screen media-query to avoid print issues.\r\n\r\nBefore:\r\n\u003cimg width=\"1252\" alt=\"site before: sidebar is huge with empty space, multiple pieces of content are clipped\" src=\"https://user-images.githubusercontent.com/3012099/117514606-3bceda80-af62-11eb-8619-45837074ea30.png\">\r\n\r\nAfter:\r\n\u003cimg width=\"1252\" alt=\"site after: sidebar sizes to its contents, available space is used\" src=\"https://user-images.githubusercontent.com/3012099/117514642-53a65e80-af62-11eb-8d1b-0d37cd6e628b.png\">\r\n\r\nThe flexbox approach is also generally favourable because switching from desktop to mobile is often little more than flex-direction: column → row.\r\n\r\nI'd be happy to send a pull request.","author":{"url":"https://github.com/JakobJingleheimer","@type":"Person","name":"JakobJingleheimer"},"datePublished":"2021-05-07T22:29:36Z","url":"https://github.com/AssemblyScript/website/issues/73"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8e4c4e11-5e0b-675d-cee0-b61ffb352301 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8BFC:50BAB:184B0C:21BA78:6B0055C9 |
| html-safe-nonce | f6a8cd25ebcfba646e90d2b03c70a03eb6968077d36280511c00a218f2c72487 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkZDOjUwQkFCOjE4NEIwQzoyMUJBNzg6NkIwMDU1QzkiLCJ2aXNpdG9yX2lkIjoiNTM4NzUzMDA3NjUwODE0OTE5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ecf2f6a3ec06e0e868e17a4fca32292799673bf6eebecf26f5f4f630e13d3b82 |
| hovercard-subject-tag | issue:879855410 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/AssemblyScript/website/73/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8bf5deb48641fe2b89f6a1d59022f58214ff60b01f385062a5e273d8d3f995dc/AssemblyScript/website/issues/73 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8bf5deb48641fe2b89f6a1d59022f58214ff60b01f385062a5e273d8d3f995dc/AssemblyScript/website/issues/73 |
| og:image:alt | Loving the documentation so far (especially the emojis). But the docs site clips in a lot of places when adhering to WCAG 2.x AA font-size criteria. Also, the left sidebar/table of contents is HUGE... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JakobJingleheimer |
| hostname | github.com |
| expected-hostname | github.com |
| None | f420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb |
| turbo-cache-control | no-preview |
| go-import | github.com/AssemblyScript/website git https://github.com/AssemblyScript/website.git |
| octolytics-dimension-user_id | 28916798 |
| octolytics-dimension-user_login | AssemblyScript |
| octolytics-dimension-repository_id | 269375018 |
| octolytics-dimension-repository_nwo | AssemblyScript/website |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 269375018 |
| octolytics-dimension-repository_network_root_nwo | AssemblyScript/website |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26e00df917aba0f128135dc073ea0c5e33a70d40 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width