René's URL Explorer Experiment


Title: [Implement] Buffer.concat by jtenner · Pull Request #5 · AssemblyScript/node · GitHub

Open Graph Title: [Implement] Buffer.concat by jtenner · Pull Request #5 · AssemblyScript/node

X Title: [Implement] Buffer.concat by jtenner · Pull Request #5 · AssemblyScript/node

Description: Current problems: No good logging for that extend ArrayBufferView (opened issue with as-pect https://github.com/jtenner/as-pect/issues/132 ) No good way of comparing things that extend ArrayBufferView (opened issue with as-pect https://github.com/jtenner/as-pect/issues/133 ) expect(actual).toStrictEqual(expected); // should compare lengths and values No good way to create a buffer from scratch without a naive Buffer.from() function Could create a helper function, but that's a todo This pull request is not blocked by anything. Current questions: Should we set the length parameter to i32.MAX_VALUE? Any suggestions for optimizations? Should we do a null check on the array? (in case of uninitialized field problems?)

Open Graph Description: Current problems: No good logging for that extend ArrayBufferView (opened issue with as-pect https://github.com/jtenner/as-pect/issues/132 ) No good way of comparing things that extend ArrayBuffer...

X Description: Current problems: No good logging for that extend ArrayBufferView (opened issue with as-pect https://github.com/jtenner/as-pect/issues/132 ) No good way of comparing things that extend ArrayBuffer...

Opengraph URL: https://github.com/AssemblyScript/node/pull/5

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6eb5e4ec-9f91-b886-efdf-e87d4ded2693
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE030:C2FBA:A257:E62A:6B005FD2
html-safe-noncec24953a72c3ac9a6454eee1519052b886d9ba9a8a3b690ce5dd369ae40cf1adc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDMwOkMyRkJBOkEyNTc6RTYyQTo2QjAwNUZEMiIsInZpc2l0b3JfaWQiOiIzMzc5NjcwOTAxODU4NTI1MTM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1130624b9e8d109ce779085865752a6b33150c6af05d36f7d2f32ab697583a40
hovercard-subject-tagpull_request:299073619
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/AssemblyScript/node/pull/5/files
twitter:imagehttps://avatars.githubusercontent.com/u/3761339?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3761339?s=400&v=4
og:image:altCurrent problems: No good logging for that extend ArrayBufferView (opened issue with as-pect https://github.com/jtenner/as-pect/issues/132 ) No good way of comparing things that extend ArrayBuffer...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/AssemblyScript/node git https://github.com/AssemblyScript/node.git
octolytics-dimension-user_id28916798
octolytics-dimension-user_loginAssemblyScript
octolytics-dimension-repository_id197036299
octolytics-dimension-repository_nwoAssemblyScript/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id197036299
octolytics-dimension-repository_network_root_nwoAssemblyScript/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/AssemblyScript/node/pull/5/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAssemblyScript%2Fnode%2Fpull%2F5%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAssemblyScript%2Fnode%2Fpull%2F5%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=AssemblyScript%2Fnode
Reloadhttps://github.com/AssemblyScript/node/pull/5/files
Reloadhttps://github.com/AssemblyScript/node/pull/5/files
Reloadhttps://github.com/AssemblyScript/node/pull/5/files
AssemblyScripthttps://github.com/AssemblyScript
nodehttps://github.com/AssemblyScript/node
Codehttps://github.com/AssemblyScript/node
Issues2 (2)https://github.com/AssemblyScript/node/issues
Pull requests10 (10)https://github.com/AssemblyScript/node/pulls
Actionshttps://github.com/AssemblyScript/node/actions
Projectshttps://github.com/AssemblyScript/node/projects
Wikihttps://github.com/AssemblyScript/node/wiki
Security and qualityhttps://github.com/AssemblyScript/node/security
Insightshttps://github.com/AssemblyScript/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2FAssemblyScript%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FAssemblyScript%2Fnode%2Fissues%2Fnew%2Fchoose
jtennerhttps://github.com/jtenner
mainhttps://github.com/AssemblyScript/node/tree/main
concathttps://github.com/AssemblyScript/node/tree/concat
Conversation 14 https://github.com/AssemblyScript/node/pull/5
Commits 10 https://github.com/AssemblyScript/node/pull/5/commits
Checks 0 https://github.com/AssemblyScript/node/pull/5/checks
Files changed https://github.com/AssemblyScript/node/pull/5/files
Please reload this pagehttps://github.com/AssemblyScript/node/pull/5/files
[Implement] Buffer.concat https://github.com/AssemblyScript/node/pull/5/files#top
Show all changes 10 commits https://github.com/AssemblyScript/node/pull/5/files
ddeb2c3 [Implement] Naive Buffer.concat jtenner Jul 18, 2019 https://github.com/AssemblyScript/node/pull/5/commits/ddeb2c33796c98e054fe8b1ebbe127bb6c68ef78
6f5f8aa [Fix] Switch to Buffer[], remove excess changetype() jtenner Jul 19, 2019 https://github.com/AssemblyScript/node/pull/5/commits/6f5f8aa718e804c1d3d89361ad803127d0c4d285
5cb8ea9 [Types] Update signature jtenner Jul 19, 2019 https://github.com/AssemblyScript/node/pull/5/commits/5cb8ea9aba0fce03b01ef087ce84b563613a14cc
2a87ef8 [Cleanup] concat jtenner Jul 31, 2019 https://github.com/AssemblyScript/node/pull/5/commits/2a87ef8bac95cd2078e3b18e3d1cac1b0fcfb943
efe6ebc [Merge] from master jtenner Jul 31, 2019 https://github.com/AssemblyScript/node/pull/5/commits/efe6ebcf6ccec60ff87aec55bfb2d4f30db6de49
cd34165 fix up concat jtenner Mar 12, 2020 https://github.com/AssemblyScript/node/pull/5/commits/cd34165c6d3a871298e09eab91dd9f304ced8cb8
98b5665 add generic parameter jtenner Mar 12, 2020 https://github.com/AssemblyScript/node/pull/5/commits/98b5665041336503edfaea86a34b709ea771a6d8
c4b6c4b remove excess type jtenner Mar 12, 2020 https://github.com/AssemblyScript/node/pull/5/commits/c4b6c4bf1b7dbf1302755e6e696ec854294e3b6f
14002b4 update tests, add short path, update types to make length optional jtenner Mar 12, 2020 https://github.com/AssemblyScript/node/pull/5/commits/14002b4f1ba4759819d48650460126683fdd2029
4b03b51 update test, remove types on expect calls jtenner Mar 12, 2020 https://github.com/AssemblyScript/node/pull/5/commits/4b03b516407673a5c8558b3d5543801c6098b3e9
Clear filters https://github.com/AssemblyScript/node/pull/5/files
Please reload this pagehttps://github.com/AssemblyScript/node/pull/5/files
Please reload this pagehttps://github.com/AssemblyScript/node/pull/5/files
index.ts https://github.com/AssemblyScript/node/pull/5/files#diff-ce25df572d6523d74bce32c8d9d7594043a69675589ca95b88cd1d83ba968669
node.d.ts https://github.com/AssemblyScript/node/pull/5/files#diff-669fa8c1aaa009ed17c0c9f184f5f2dd68ce0a4e5c2d3695ac8002e2d8a710b2
package-lock.json https://github.com/AssemblyScript/node/pull/5/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
package.json https://github.com/AssemblyScript/node/pull/5/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
buffer.spec.ts https://github.com/AssemblyScript/node/pull/5/files#diff-2c04e013811b340820227338ed3e99cae9729d46f53c1b8b3999d3a096744eba
assembly/buffer/index.tshttps://github.com/AssemblyScript/node/pull/5/files#diff-ce25df572d6523d74bce32c8d9d7594043a69675589ca95b88cd1d83ba968669
View file https://github.com/AssemblyScript/node/blob/4b03b516407673a5c8558b3d5543801c6098b3e9/assembly/buffer/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/AssemblyScript/node/pull/5/{{ revealButtonHref }}
https://github.com/AssemblyScript/node/pull/5/files#diff-ce25df572d6523d74bce32c8d9d7594043a69675589ca95b88cd1d83ba968669
https://github.com/AssemblyScript/node/pull/5/files#diff-ce25df572d6523d74bce32c8d9d7594043a69675589ca95b88cd1d83ba968669
assembly/node.d.tshttps://github.com/AssemblyScript/node/pull/5/files#diff-669fa8c1aaa009ed17c0c9f184f5f2dd68ce0a4e5c2d3695ac8002e2d8a710b2
View file https://github.com/AssemblyScript/node/blob/4b03b516407673a5c8558b3d5543801c6098b3e9/assembly/node.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/AssemblyScript/node/pull/5/{{ revealButtonHref }}
https://github.com/AssemblyScript/node/pull/5/files#diff-669fa8c1aaa009ed17c0c9f184f5f2dd68ce0a4e5c2d3695ac8002e2d8a710b2
https://github.com/AssemblyScript/node/pull/5/files#diff-669fa8c1aaa009ed17c0c9f184f5f2dd68ce0a4e5c2d3695ac8002e2d8a710b2
package-lock.jsonhttps://github.com/AssemblyScript/node/pull/5/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
View file https://github.com/AssemblyScript/node/blob/4b03b516407673a5c8558b3d5543801c6098b3e9/package-lock.json
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/AssemblyScript/node/pull/5/files
package.jsonhttps://github.com/AssemblyScript/node/pull/5/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/AssemblyScript/node/blob/4b03b516407673a5c8558b3d5543801c6098b3e9/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/AssemblyScript/node/pull/5/{{ revealButtonHref }}
https://github.com/AssemblyScript/node/pull/5/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/AssemblyScript/node/pull/5/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
tests/buffer.spec.tshttps://github.com/AssemblyScript/node/pull/5/files#diff-2c04e013811b340820227338ed3e99cae9729d46f53c1b8b3999d3a096744eba
View file https://github.com/AssemblyScript/node/blob/4b03b516407673a5c8558b3d5543801c6098b3e9/tests/buffer.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/AssemblyScript/node/pull/5/{{ revealButtonHref }}
https://github.com/AssemblyScript/node/pull/5/files#diff-2c04e013811b340820227338ed3e99cae9729d46f53c1b8b3999d3a096744eba
https://github.com/AssemblyScript/node/pull/5/files#diff-2c04e013811b340820227338ed3e99cae9729d46f53c1b8b3999d3a096744eba
https://github.com/AssemblyScript/node/pull/5/files#diff-2c04e013811b340820227338ed3e99cae9729d46f53c1b8b3999d3a096744eba
https://github.com/AssemblyScript/node/pull/5/files#diff-2c04e013811b340820227338ed3e99cae9729d46f53c1b8b3999d3a096744eba
https://github.com/AssemblyScript/node/pull/5/files#diff-2c04e013811b340820227338ed3e99cae9729d46f53c1b8b3999d3a096744eba
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.