René's URL Explorer Experiment


Title: Fixed stdlib builtins not working with typedoc by torch2424 · Pull Request #1894 · AssemblyScript/assemblyscript · GitHub

Open Graph Title: Fixed stdlib builtins not working with typedoc by torch2424 · Pull Request #1894 · AssemblyScript/assemblyscript

X Title: Fixed stdlib builtins not working with typedoc by torch2424 · Pull Request #1894 · AssemblyScript/assemblyscript

Description: Hello! This is just something I noticed when working on the Fastly AS SDK. It seems like in version 0.18.13, we introduced a change in which caused a type error, as we try to assign void to an i32, and i31ref: I got the error above when running typedoc on version 0.19.1, but it works again on 0.18.12. So, I assume unreachable is the instruction that causes things to crash. So instead of returning void, I still call the function, but return a "void number" (0), which I assume is the expected behavior? With this fix, things start working again in the type system: Thanks to whoever picks up this review! 😄 🎉 cc @dcodeIO @MaxGraey 😄

Open Graph Description: Hello! This is just something I noticed when working on the Fastly AS SDK. It seems like in version 0.18.13, we introduced a change in which caused a type error, as we try to assign void to an i32,...

X Description: Hello! This is just something I noticed when working on the Fastly AS SDK. It seems like in version 0.18.13, we introduced a change in which caused a type error, as we try to assign void to an i32,...

Opengraph URL: https://github.com/AssemblyScript/assemblyscript/pull/1894

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4996551c-d914-b5b4-6017-0f169fbd51c8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB2AE:52510:63C051:858B10:6B00AC11
html-safe-nonce66d8e6fbd47530f59e9ea2ba02b9cea6a86c8aa049f952b21e11e71008ece0f7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkFFOjUyNTEwOjYzQzA1MTo4NThCMTA6NkIwMEFDMTEiLCJ2aXNpdG9yX2lkIjoiNjcyNTgzMzExNTYxODU1Mjg0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4880a8ae1083b4cbcdc54b99f147dbfcf7bbdf77468a9b383f541042c01f98e5
hovercard-subject-tagpull_request:665455108
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/AssemblyScript/assemblyscript/pull/1894/files
twitter:imagehttps://avatars.githubusercontent.com/u/1448289?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1448289?s=400&v=4
og:image:altHello! This is just something I noticed when working on the Fastly AS SDK. It seems like in version 0.18.13, we introduced a change in which caused a type error, as we try to assign void to an i32,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec0dd5f5d6f515a591019ecd66df2c4eab3379c2d3b0777568a90d8c7ae10b79e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/AssemblyScript/assemblyscript git https://github.com/AssemblyScript/assemblyscript.git
octolytics-dimension-user_id28916798
octolytics-dimension-user_loginAssemblyScript
octolytics-dimension-repository_id105138356
octolytics-dimension-repository_nwoAssemblyScript/assemblyscript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id105138356
octolytics-dimension-repository_network_root_nwoAssemblyScript/assemblyscript
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release729d8cda69b3d267995675dfbf89ff27ccf61bf6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/AssemblyScript/assemblyscript/pull/1894/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAssemblyScript%2Fassemblyscript%2Fpull%2F1894%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAssemblyScript%2Fassemblyscript%2Fpull%2F1894%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=AssemblyScript%2Fassemblyscript
Reloadhttps://github.com/AssemblyScript/assemblyscript/pull/1894/files
Reloadhttps://github.com/AssemblyScript/assemblyscript/pull/1894/files
Reloadhttps://github.com/AssemblyScript/assemblyscript/pull/1894/files
AssemblyScripthttps://github.com/AssemblyScript
assemblyscripthttps://github.com/AssemblyScript/assemblyscript
Codehttps://github.com/AssemblyScript/assemblyscript
Issues196 (196)https://github.com/AssemblyScript/assemblyscript/issues
Pull requests24 (24)https://github.com/AssemblyScript/assemblyscript/pulls
Actionshttps://github.com/AssemblyScript/assemblyscript/actions
Wikihttps://github.com/AssemblyScript/assemblyscript/wiki
Security and qualityhttps://github.com/AssemblyScript/assemblyscript/security
Insightshttps://github.com/AssemblyScript/assemblyscript/insights
Sign up for GitHub https://github.com/signup?return_to=%2FAssemblyScript%2Fassemblyscript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FAssemblyScript%2Fassemblyscript%2Fissues%2Fnew%2Fchoose
torch2424https://github.com/torch2424
mainhttps://github.com/AssemblyScript/assemblyscript/tree/main
torch2424/builtin-types-with-typedochttps://github.com/AssemblyScript/assemblyscript/tree/torch2424/builtin-types-with-typedoc
Conversation 4 https://github.com/AssemblyScript/assemblyscript/pull/1894
Commits 3 https://github.com/AssemblyScript/assemblyscript/pull/1894/commits
Checks 0 https://github.com/AssemblyScript/assemblyscript/pull/1894/checks
Files changed https://github.com/AssemblyScript/assemblyscript/pull/1894/files
Please reload this pagehttps://github.com/AssemblyScript/assemblyscript/pull/1894/files
Fixed stdlib builtins not working with typedoc https://github.com/AssemblyScript/assemblyscript/pull/1894/files#top
Show all changes 3 commits https://github.com/AssemblyScript/assemblyscript/pull/1894/files
a71387b Fixed stdlib builtins not working with typedoc torch2424 Jun 9, 2021 https://github.com/AssemblyScript/assemblyscript/pull/1894/commits/a71387bcc143dde70c4a33a4f7038139316f4ea9
c3ad406 Added the changetype instead of zero torch2424 Jun 9, 2021 https://github.com/AssemblyScript/assemblyscript/pull/1894/commits/c3ad406d7e43458b0f0cd7c8a51196864c257b82
3eacd5d Made suggested changes torch2424 Jun 9, 2021 https://github.com/AssemblyScript/assemblyscript/pull/1894/commits/3eacd5d57b7cb8b168a957f79466b96a9209a32f
Clear filters https://github.com/AssemblyScript/assemblyscript/pull/1894/files
Please reload this pagehttps://github.com/AssemblyScript/assemblyscript/pull/1894/files
Please reload this pagehttps://github.com/AssemblyScript/assemblyscript/pull/1894/files
std/assembly/builtins.tshttps://github.com/AssemblyScript/assemblyscript/pull/1894/files#diff-aa2246d6fd1978a781ccd408c020cfc434716ee70632977f3bed0e2c8515fa47
View file https://github.com/AssemblyScript/assemblyscript/blob/3eacd5d57b7cb8b168a957f79466b96a9209a32f/std/assembly/builtins.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/AssemblyScript/assemblyscript/pull/1894/{{ revealButtonHref }}
https://github.com/AssemblyScript/assemblyscript/pull/1894/files#diff-aa2246d6fd1978a781ccd408c020cfc434716ee70632977f3bed0e2c8515fa47
https://github.com/AssemblyScript/assemblyscript/pull/1894/files#diff-aa2246d6fd1978a781ccd408c020cfc434716ee70632977f3bed0e2c8515fa47
https://github.com/AssemblyScript/assemblyscript/pull/1894/files#diff-aa2246d6fd1978a781ccd408c020cfc434716ee70632977f3bed0e2c8515fa47
https://github.com/AssemblyScript/assemblyscript/pull/1894/files#diff-aa2246d6fd1978a781ccd408c020cfc434716ee70632977f3bed0e2c8515fa47
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.