Title: Alice B-field derives from FairField + stores its parameters in MagFieldParam by shahor02 · Pull Request #222 · AliceO2Group/AliceO2 · GitHub
Open Graph Title: Alice B-field derives from FairField + stores its parameters in MagFieldParam by shahor02 · Pull Request #222 · AliceO2Group/AliceO2
X Title: Alice B-field derives from FairField + stores its parameters in MagFieldParam by shahor02 · Pull Request #222 · AliceO2Group/AliceO2
Description: Hi @MohammadAlTurany, I've modified Common/Field/MagneticField to derive from FairField to fill it params into MagFieldParam inheriting from FairParGenericSet, as we discussed privately. Note that the MagneticField::FillParContainer() looks for ((FairRun*)fRun)->GetRuntimeDb()->getContainer("MagFieldParam") which it currently will not find, since current of instances of FairRun derive from Tutorial3 with hardcoded FairConstField / FairConstPar. Anyway, I understood you wanted implement yourself adding the field producer to the FairRun. I am wondering if we should not derive AliRun from FairRun, and set there all factories etc. In case you will need to create MagneticField factory, note that on top of its standard c-tor I've added MagneticField(MagFieldParam& params). Question concerning MagFieldParam::getParams(FairParamList* list) implementation: one of the parameters to store is text string, and the only method I found to retrieve it was FairParamList::fill(const Text_t*,Text_t*,const Int_t), which leads to quite heavy construct to get the length of the string, see assignment of mMapPath in MagFieldParam::getParams. Is there an easier way of dealing with text (except storing TObjString?). Also, I think this FairParamList::fill(const Text_t* name,Text_t* value,const Int_t length) method has a bug: it requires that the supplied length argument (i.e. the size of buffer for value) be > strlen(of_stored_string)-1, while to should be simply > strlen(of_stored_string) to allow for trailing \0. Cheers, Ruben
Open Graph Description: Hi @MohammadAlTurany, I've modified Common/Field/MagneticField to derive from FairField to fill it params into MagFieldParam inheriting from FairParGenericSet, as we discussed privately. Note ...
X Description: Hi @MohammadAlTurany, I've modified Common/Field/MagneticField to derive from FairField to fill it params into MagFieldParam inheriting from FairParGenericSet, as we discussed privately. N...
Opengraph URL: https://github.com/AliceO2Group/AliceO2/pull/222
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a2a904ff-ba60-00e3-77e9-4acdf2d0fd3b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF9A:A473E:40238D4:57D2858:6980CE54 |
| html-safe-nonce | 9c316d1798c57155c3237deffd10d68b598190a7bf34a7015c06c08cda5d3549 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjlBOkE0NzNFOjQwMjM4RDQ6NTdEMjg1ODo2OTgwQ0U1NCIsInZpc2l0b3JfaWQiOiI2MzMxMjM0NDg5OTIyMDE0ODA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d54926791b8b78f408beaafeeb85bf10ce0d413e3928a1953a3654f673a1d809 |
| hovercard-subject-tag | pull_request:102646430 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/AliceO2Group/AliceO2/pull/222/files |
| twitter:image | https://avatars.githubusercontent.com/u/7382029?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7382029?s=400&v=4 |
| og:image:alt | Hi @MohammadAlTurany, I've modified Common/Field/MagneticField to derive from FairField to fill it params into MagFieldParam inheriting from FairParGenericSet, as we discussed privately. Note ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | c940d5e308643c0003d2824389ea8281bcaae0a9a0d07438e3fb5e0bdc4fef12 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/AliceO2Group/AliceO2 git https://github.com/AliceO2Group/AliceO2.git |
| octolytics-dimension-user_id | 9053140 |
| octolytics-dimension-user_login | AliceO2Group |
| octolytics-dimension-repository_id | 24898648 |
| octolytics-dimension-repository_nwo | AliceO2Group/AliceO2 |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24898648 |
| octolytics-dimension-repository_network_root_nwo | AliceO2Group/AliceO2 |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bb3d0fe9b8e408797775c5db420b1ee5ff06e4d0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width