René's URL Explorer Experiment


Title: Custom member streamer for CalArray::mData by sawenzel · Pull Request #14830 · AliceO2Group/AliceO2 · GitHub

Open Graph Title: Custom member streamer for CalArray::mData by sawenzel · Pull Request #14830 · AliceO2Group/AliceO2

X Title: Custom member streamer for CalArray::mData by sawenzel · Pull Request #14830 · AliceO2Group/AliceO2

Description: This commit expands on #14427 and fixes the issue brought up in https://its.cern.ch/jira/browse/O2-4671. After debugging/testing it turns out that the approach taken via a customer streamer for std::vector does not take effect in the ROOT/IO because apparently ROOT still prefers to use the CollectionProxy for std::vector and does not employ the custom streamer. Instead, after discussion with @pcanal, this commit proposes to implement a custom stream just for the mData data member of CalArray. This is the only place where we use o2::tpc::PadFlags in IO and it fixes the problem when reading CCDB objects containing such data. I have verified that the following code o2-ccdb-downloadccdbfile -p TPC/Calib/IDC_PadStatusMap_A -t 1731274461770 -d ./ -o tpc_idc.root --no-preserve-path root tpc_idc.root gFile->Get>("ccdb_object") correctly executes the custom streamer function. Note that there is also no need to make the code ROOT version dependent. We need to fix the reading in any case and the writing will just stay the same. Concerning situations, where future classes will write data containing std::vector we should be protected by the fact that this bug has been fixed >= ROOT 6.36 in any case. This commit relates also to root-project/root#17009

Open Graph Description: This commit expands on #14427 and fixes the issue brought up in https://its.cern.ch/jira/browse/O2-4671. After debugging/testing it turns out that the approach taken via a customer streamer for std...

X Description: This commit expands on #14427 and fixes the issue brought up in https://its.cern.ch/jira/browse/O2-4671. After debugging/testing it turns out that the approach taken via a customer streamer for std...

Opengraph URL: https://github.com/AliceO2Group/AliceO2/pull/14830

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:ba064309-c0da-7f4b-274d-e36cc0509ba2
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idAEB2:154212:766077:981777:697E2E4A
html-safe-nonce15f79c8baa2fe418ba7e78c2f43dcc614d9f776b06ce1f475b1650aa1d3aace1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUIyOjE1NDIxMjo3NjYwNzc6OTgxNzc3OjY5N0UyRTRBIiwidmlzaXRvcl9pZCI6IjY5MTMxMzAwNTk0ODE4ODYyODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8de545797927ed2834d7c65339faa29234ef6a51ed988086321fcd077d0844d4
hovercard-subject-tagpull_request:3022159654
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/AliceO2Group/AliceO2/pull/14830/checks
twitter:imagehttps://avatars.githubusercontent.com/u/3536753?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3536753?s=400&v=4
og:image:altThis commit expands on #14427 and fixes the issue brought up in https://its.cern.ch/jira/browse/O2-4671. After debugging/testing it turns out that the approach taken via a customer streamer for std...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-cache
go-importgithub.com/AliceO2Group/AliceO2 git https://github.com/AliceO2Group/AliceO2.git
octolytics-dimension-user_id9053140
octolytics-dimension-user_loginAliceO2Group
octolytics-dimension-repository_id24898648
octolytics-dimension-repository_nwoAliceO2Group/AliceO2
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24898648
octolytics-dimension-repository_network_root_nwoAliceO2Group/AliceO2
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/AliceO2Group/AliceO2/pull/14830/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAliceO2Group%2FAliceO2%2Fpull%2F14830%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAliceO2Group%2FAliceO2%2Fpull%2F14830%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=AliceO2Group%2FAliceO2
Reloadhttps://github.com/AliceO2Group/AliceO2/pull/14830/checks
Reloadhttps://github.com/AliceO2Group/AliceO2/pull/14830/checks
Reloadhttps://github.com/AliceO2Group/AliceO2/pull/14830/checks
AliceO2Group https://github.com/AliceO2Group
AliceO2https://github.com/AliceO2Group/AliceO2
Notifications https://github.com/login?return_to=%2FAliceO2Group%2FAliceO2
Fork 488 https://github.com/login?return_to=%2FAliceO2Group%2FAliceO2
Star 118 https://github.com/login?return_to=%2FAliceO2Group%2FAliceO2
Code https://github.com/AliceO2Group/AliceO2
Issues 1 https://github.com/AliceO2Group/AliceO2/issues
Pull requests 17 https://github.com/AliceO2Group/AliceO2/pulls
Actions https://github.com/AliceO2Group/AliceO2/actions
Security 0 https://github.com/AliceO2Group/AliceO2/security
Insights https://github.com/AliceO2Group/AliceO2/pulse
Code https://github.com/AliceO2Group/AliceO2
Issues https://github.com/AliceO2Group/AliceO2/issues
Pull requests https://github.com/AliceO2Group/AliceO2/pulls
Actions https://github.com/AliceO2Group/AliceO2/actions
Security https://github.com/AliceO2Group/AliceO2/security
Insights https://github.com/AliceO2Group/AliceO2/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FAliceO2Group%2FAliceO2%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FAliceO2Group%2FAliceO2%2Fissues%2Fnew%2Fchoose
sawenzelhttps://github.com/sawenzel
AliceO2Group:devhttps://github.com/AliceO2Group/AliceO2/tree/dev
sawenzel:swenzel/calarray_streamerhttps://github.com/sawenzel/AliceO2/tree/swenzel/calarray_streamer
Conversation 5 https://github.com/AliceO2Group/AliceO2/pull/14830
Commits 1 https://github.com/AliceO2Group/AliceO2/pull/14830/commits
Checks 8 https://github.com/AliceO2Group/AliceO2/pull/14830/checks
Files changed https://github.com/AliceO2Group/AliceO2/pull/14830/files
Please reload this pagehttps://github.com/AliceO2Group/AliceO2/pull/14830/checks
Please reload this pagehttps://github.com/AliceO2Group/AliceO2/pull/14830/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAliceO2Group%2FAliceO2%2Fpull%2F14830%2Fchecks
Custom member streamer for CalArray::mData https://github.com/AliceO2Group/AliceO2/pull/14830/checks#top
Please reload this pagehttps://github.com/AliceO2Group/AliceO2/pull/14830/checks
Current refactorings on: pull_request_target https://github.com/AliceO2Group/AliceO2/actions/runs/19470428505
build https://github.com/AliceO2Group/AliceO2/actions/runs/19470428505/job/55715877396?pr=14830
Collect and print async labels on: pull_request_target https://github.com/AliceO2Group/AliceO2/actions/runs/19470428558
Collect and print async labels / Print labels https://github.com/AliceO2Group/AliceO2/actions/runs/19470428558/job/55715874150?pr=14830
Formatting on: pull_request_target https://github.com/AliceO2Group/AliceO2/actions/runs/19470428582
PR formatting / clang-format https://github.com/AliceO2Group/AliceO2/actions/runs/19470428582/job/55715874277?pr=14830
PR formatting / copyright headers https://github.com/AliceO2Group/AliceO2/actions/runs/19470428582/job/55715874309?pr=14830
PR formatting / line endings https://github.com/AliceO2Group/AliceO2/actions/runs/19470428582/job/55715874290?pr=14830
PR formatting / whitespace https://github.com/AliceO2Group/AliceO2/actions/runs/19470428582/job/55715874265?pr=14830
PR formatting / pragma-once https://github.com/AliceO2Group/AliceO2/actions/runs/19470428582/job/55715874263?pr=14830
Security approval on: pull_request_review https://github.com/AliceO2Group/AliceO2/actions/runs/19474501071
Security approval / Clear security message https://github.com/AliceO2Group/AliceO2/actions/runs/19474501071/job/55730648366?pr=14830
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.