René's URL Explorer Experiment


Title: fix: include cross-JOIN ON referenced columns in count subquery for MySQL by youdaoSu · Pull Request #878 · APIJSON/APIJSON · GitHub

Open Graph Title: fix: include cross-JOIN ON referenced columns in count subquery for MySQL by youdaoSu · Pull Request #878 · APIJSON/APIJSON

X Title: fix: include cross-JOIN ON referenced columns in count subquery for MySQL by youdaoSu · Pull Request #878 · APIJSON/APIJSON

Description: Summary Fix for issue #824 (multi-JOIN count pagination). When HEAD/count pagination is used with multiple JOINs, the subquery for each JOIN table only selected its own ON key (on.getKey()). If another JOIN's ON clause references a column of this table, that column was missing from the subquery, causing an Unknown column error. Example (from the issue): SELECT count(*) AS `count` FROM `Inventory` AS `Inventory` LEFT JOIN ( SELECT `code` FROM `Location_info` ) AS `Location_info` ON `Location_info`.`code` = `Inventory`.`location_code` LEFT JOIN ( SELECT `id` FROM `Warehose_info` ) AS `Warehose_info` ON `Warehose_info`.`id` = `Location_info`.`warehouse_id` Location_info's subquery only selects code, but the second ON clause references Location_info.warehouse_id. Change In AbstractSQLConfig.parseJoin (MySQL-family databases only), when building the subquery column list for a JOIN table, also collect the targetKey of any ON clause (from any JOIN in the list) whose target table/alias matches the current JOIN table. Uses a LinkedHashSet to keep insertion order and deduplicate. PostgreSQL (and other non-MySQL databases) keep their existing SELECT * fallback, which already covers this case. Tests Added AbstractSQLConfigJoinCountTest with 2 cases: PostgreSQL: subqueries fall back to SELECT * (regression guard). MySQL: Location_info subquery must include both code (its own ON key) and warehouse_id (referenced by the second JOIN's ON). Full suite: 38 tests, 0 failures. fixes #824

Open Graph Description: Summary Fix for issue #824 (multi-JOIN count pagination). When HEAD/count pagination is used with multiple JOINs, the subquery for each JOIN table only selected its own ON key (on.getKey()). If ano...

X Description: Summary Fix for issue #824 (multi-JOIN count pagination). When HEAD/count pagination is used with multiple JOINs, the subquery for each JOIN table only selected its own ON key (on.getKey()). If ano...

Opengraph URL: https://github.com/APIJSON/APIJSON/pull/878

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:18bad128-d5c8-5c14-5ad3-eae434e4ee4a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE08A:E9A8B:A60698:ED1B37:6AFCB85B
html-safe-nonce47d2b7e49c32fdefbd487f9a15da6c346c310e8633a3d16dc4f7e7dcd8fea839
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDhBOkU5QThCOkE2MDY5ODpFRDFCMzc6NkFGQ0I4NUIiLCJ2aXNpdG9yX2lkIjoiNTQwMjA5MzAwOTIzMzU1NzU5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf14bc6f407d06df77d859988821073f0ab1faf2d795f7faafa556aa14e86a935
hovercard-subject-tagpull_request:4598353973
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/APIJSON/APIJSON/pull/878/files
twitter:imagehttps://avatars.githubusercontent.com/u/244297977?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/244297977?s=400&v=4
og:image:altSummary Fix for issue #824 (multi-JOIN count pagination). When HEAD/count pagination is used with multiple JOINs, the subquery for each JOIN table only selected its own ON key (on.getKey()). If ano...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee3084aead77cbcb4f4904fba53851fa1a0546b0dec3619bd250815e72588dc6d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/APIJSON/APIJSON git https://github.com/APIJSON/APIJSON.git
octolytics-dimension-user_id41146037
octolytics-dimension-user_loginAPIJSON
octolytics-dimension-repository_id74359442
octolytics-dimension-repository_nwoAPIJSON/APIJSON
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id74359442
octolytics-dimension-repository_network_root_nwoAPIJSON/APIJSON
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5410e4bebd3e45b138c853ecef3992279d86d5af
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/APIJSON/APIJSON/pull/878/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAPIJSON%2FAPIJSON%2Fpull%2F878%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAPIJSON%2FAPIJSON%2Fpull%2F878%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=APIJSON%2FAPIJSON
Reloadhttps://github.com/APIJSON/APIJSON/pull/878/files
Reloadhttps://github.com/APIJSON/APIJSON/pull/878/files
Reloadhttps://github.com/APIJSON/APIJSON/pull/878/files
APIJSONhttps://github.com/APIJSON
APIJSONhttps://github.com/APIJSON/APIJSON
Codehttps://github.com/APIJSON/APIJSON
Issues237 (237)https://github.com/APIJSON/APIJSON/issues
Pull requestshttps://github.com/APIJSON/APIJSON/pulls
Actionshttps://github.com/APIJSON/APIJSON/actions
Wikihttps://github.com/APIJSON/APIJSON/wiki
Security and qualityhttps://github.com/APIJSON/APIJSON/security
Insightshttps://github.com/APIJSON/APIJSON/insights
Sign up for GitHub https://github.com/signup?return_to=%2FAPIJSON%2FAPIJSON%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FAPIJSON%2FAPIJSON%2Fissues%2Fnew%2Fchoose
TommyLemonhttps://github.com/TommyLemon
APIJSON:mainhttps://github.com/APIJSON/APIJSON/tree/main
youdaoSu:fix/issue-824-mysql-join-subquery-columnshttps://github.com/youdaoSu/APIJSON/tree/fix/issue-824-mysql-join-subquery-columns
Conversation 0 https://github.com/APIJSON/APIJSON/pull/878
Commits 2 https://github.com/APIJSON/APIJSON/pull/878/commits
Checks 0 https://github.com/APIJSON/APIJSON/pull/878/checks
Files changed https://github.com/APIJSON/APIJSON/pull/878/files
Please reload this pagehttps://github.com/APIJSON/APIJSON/pull/878/files
fix: include cross-JOIN ON referenced columns in count subquery for MySQL https://github.com/APIJSON/APIJSON/pull/878/files#top
Show all changes 2 commits https://github.com/APIJSON/APIJSON/pull/878/files
225cd1c fix: include cross-JOIN ON referenced columns in count subquery for M… youdaoSu Sep 22, 2026 https://github.com/APIJSON/APIJSON/pull/878/commits/225cd1c4133cc1dccc9b1f11206ffbb406851ecd
498fcf5 test: clarify JoinCountTest purpose and remove unused imports youdaoSu Sep 22, 2026 https://github.com/APIJSON/APIJSON/pull/878/commits/498fcf5a58d2e5bee51e6154bbaf76d23b5eda5a
Clear filters https://github.com/APIJSON/APIJSON/pull/878/files
Please reload this pagehttps://github.com/APIJSON/APIJSON/pull/878/files
Please reload this pagehttps://github.com/APIJSON/APIJSON/pull/878/files
AbstractSQLConfig.java https://github.com/APIJSON/APIJSON/pull/878/files#diff-122a62fcb6d18967f07dfc450569028e0705dfabe001a05e4ce57cdab134e16d
AbstractSQLConfigJoinCountTest.java https://github.com/APIJSON/APIJSON/pull/878/files#diff-03450546c7f31d7a62b4dcb35863d01221531defc5f807587164b51e946c2990
src/main/java/apijson/orm/AbstractSQLConfig.javahttps://github.com/APIJSON/APIJSON/pull/878/files#diff-122a62fcb6d18967f07dfc450569028e0705dfabe001a05e4ce57cdab134e16d
View file https://github.com/youdaoSu/APIJSON/blob/498fcf5a58d2e5bee51e6154bbaf76d23b5eda5a/src/main/java/apijson/orm/AbstractSQLConfig.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/APIJSON/APIJSON/pull/878/{{ revealButtonHref }}
https://github.com/APIJSON/APIJSON/pull/878/files#diff-122a62fcb6d18967f07dfc450569028e0705dfabe001a05e4ce57cdab134e16d
https://github.com/APIJSON/APIJSON/pull/878/files#diff-122a62fcb6d18967f07dfc450569028e0705dfabe001a05e4ce57cdab134e16d
src/test/java/apijson/orm/AbstractSQLConfigJoinCountTest.javahttps://github.com/APIJSON/APIJSON/pull/878/files#diff-03450546c7f31d7a62b4dcb35863d01221531defc5f807587164b51e946c2990
View file https://github.com/youdaoSu/APIJSON/blob/498fcf5a58d2e5bee51e6154bbaf76d23b5eda5a/src/test/java/apijson/orm/AbstractSQLConfigJoinCountTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/APIJSON/APIJSON/pull/878/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.