| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cea71ec4-45a4-757b-a684-224b8a938a35 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CEAE:314667:949D06:C02AE4:69644324 |
| html-safe-nonce | d482847977bf5c542e90ac1415d59e51ddebd2e64ef723c643d58f54528c640c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUFFOjMxNDY2Nzo5NDlEMDY6QzAyQUU0OjY5NjQ0MzI0IiwidmlzaXRvcl9pZCI6IjMyNzM1NjY2NjM5NTE1MzI4MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1a4753934aae2b917f9562036db3d5b25be3decaade732dbf08f0a5a81208991 |
| hovercard-subject-tag | pull_request:2696340294 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/AI-Hypercomputer/maxtext/2030/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b03fa2f730c968c10346a06e61e3c1fbc4e6dfc4fb6d9a4419ab9b80b611fbb8/AI-Hypercomputer/maxtext/pull/2030 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b03fa2f730c968c10346a06e61e3c1fbc4e6dfc4fb6d9a4419ab9b80b611fbb8/AI-Hypercomputer/maxtext/pull/2030 |
| og:image:alt | Description
Fix Llama4 attention flops to only count for chunk attention window size for chunk attention layers.
Tests
Comparing total_tflops, learnable_weight_tflops, attention_tflops before and a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gagika |
| hostname | github.com |
| expected-hostname | github.com |
| None | baa7d9900fdf7b27d604f36887af878d569cfbdcf97126832a5f4f0caf0c6ba5 |
| turbo-cache-control | no-preview |
| go-import | github.com/AI-Hypercomputer/maxtext git https://github.com/AI-Hypercomputer/maxtext.git |
| octolytics-dimension-user_id | 181000646 |
| octolytics-dimension-user_login | AI-Hypercomputer |
| octolytics-dimension-repository_id | 607845880 |
| octolytics-dimension-repository_nwo | AI-Hypercomputer/maxtext |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 607845880 |
| octolytics-dimension-repository_network_root_nwo | AI-Hypercomputer/maxtext |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 842eff1d11f899d02b6b3b98fa3ea4860e64b34e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/AI-Hypercomputer/maxtext/pull/2030#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAI-Hypercomputer%2Fmaxtext%2Fpull%2F2030 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAI-Hypercomputer%2Fmaxtext%2Fpull%2F2030 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=AI-Hypercomputer%2Fmaxtext |
| Reload | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
| Reload | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
| Reload | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
|
AI-Hypercomputer
| https://github.com/AI-Hypercomputer |
| maxtext | https://github.com/AI-Hypercomputer/maxtext |
|
Notifications
| https://github.com/login?return_to=%2FAI-Hypercomputer%2Fmaxtext |
|
Fork
447
| https://github.com/login?return_to=%2FAI-Hypercomputer%2Fmaxtext |
|
Star
2.1k
| https://github.com/login?return_to=%2FAI-Hypercomputer%2Fmaxtext |
|
Code
| https://github.com/AI-Hypercomputer/maxtext |
|
Issues
76
| https://github.com/AI-Hypercomputer/maxtext/issues |
|
Pull requests
179
| https://github.com/AI-Hypercomputer/maxtext/pulls |
|
Actions
| https://github.com/AI-Hypercomputer/maxtext/actions |
|
Projects
0
| https://github.com/AI-Hypercomputer/maxtext/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/AI-Hypercomputer/maxtext/security |
| Please reload this page | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
|
Insights
| https://github.com/AI-Hypercomputer/maxtext/pulse |
|
Code
| https://github.com/AI-Hypercomputer/maxtext |
|
Issues
| https://github.com/AI-Hypercomputer/maxtext/issues |
|
Pull requests
| https://github.com/AI-Hypercomputer/maxtext/pulls |
|
Actions
| https://github.com/AI-Hypercomputer/maxtext/actions |
|
Projects
| https://github.com/AI-Hypercomputer/maxtext/projects |
|
Security
| https://github.com/AI-Hypercomputer/maxtext/security |
|
Insights
| https://github.com/AI-Hypercomputer/maxtext/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FAI-Hypercomputer%2Fmaxtext%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FAI-Hypercomputer%2Fmaxtext%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/AI-Hypercomputer/maxtext/pull/2030#issue-comment-box |
| copybara-service | https://github.com/apps/copybara-service |
| main | https://github.com/AI-Hypercomputer/maxtext/tree/main |
| llama4-flops | https://github.com/AI-Hypercomputer/maxtext/tree/llama4-flops |
|
Fix Llama4 attention flops
| https://github.com/AI-Hypercomputer/maxtext/pull/2030#top |
| copybara-service | https://github.com/apps/copybara-service |
| main | https://github.com/AI-Hypercomputer/maxtext/tree/main |
| llama4-flops | https://github.com/AI-Hypercomputer/maxtext/tree/llama4-flops |
|
Conversation
4
| https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
|
Commits
1
| https://github.com/AI-Hypercomputer/maxtext/pull/2030/commits |
|
Checks
17
| https://github.com/AI-Hypercomputer/maxtext/pull/2030/checks |
|
Files changed
| https://github.com/AI-Hypercomputer/maxtext/pull/2030/files |
| Please reload this page | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
| https://github.co/hiddenchars |
| https://github.com/AI-Hypercomputer/maxtext/pull/{{ revealButtonHref }} |
|
| https://github.com/gagika |
| gagika | https://github.com/gagika |
| Jul 26, 2025 | https://github.com/AI-Hypercomputer/maxtext/pull/2030#issue-3264801030 |
| Please reload this page | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
| https://diff.googleplex.com/#key=wo0bVmy9wbUc | https://diff.googleplex.com/#key=wo0bVmy9wbUc |
| Please reload this page | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
| https://github.com/gagika |
| gagika | https://github.com/gagika |
| July 27, 2025 19:39 | https://github.com/AI-Hypercomputer/maxtext/pull/2030#event-18841348031 |
| https://github.com/gagika |
| gagika | https://github.com/gagika |
| A9isha | https://github.com/A9isha |
| RissyRan | https://github.com/RissyRan |
| SurbhiJainUSC | https://github.com/SurbhiJainUSC |
| aireenmei | https://github.com/aireenmei |
| bvandermoon | https://github.com/bvandermoon |
| gobbleturk | https://github.com/gobbleturk |
| hengtaoguo | https://github.com/hengtaoguo |
| khatwanimohit | https://github.com/khatwanimohit |
| richjames0 | https://github.com/richjames0 |
| shralex | https://github.com/shralex |
| vipannalla | https://github.com/vipannalla |
| yangyuwei | https://github.com/yangyuwei |
| code owners | https://github.com/AI-Hypercomputer/maxtext/blob/e969faabbb571285a51545530f34d8f0a9f237e9/.github/CODEOWNERS#L1 |
| July 27, 2025 19:39 | https://github.com/AI-Hypercomputer/maxtext/pull/2030#event-18841348071 |
| https://github.com/gagika |
| gagika | https://github.com/gagika |
| gobbleturk | https://github.com/gobbleturk |
| shralex | https://github.com/shralex |
| NuojCheng | https://github.com/NuojCheng |
| Jul 27, 2025 | https://github.com/AI-Hypercomputer/maxtext/pull/2030#event-18841348538 |
| https://github.com/RissyRan |
| RissyRan | https://github.com/RissyRan |
|
Jul 28, 2025
| https://github.com/AI-Hypercomputer/maxtext/pull/2030#pullrequestreview-3063996948 |
|
View reviewed changes
| https://github.com/AI-Hypercomputer/maxtext/pull/2030/files |
| RissyRan | https://github.com/RissyRan |
| https://github.com/AI-Hypercomputer/maxtext/pull/2030#pullrequestreview-3063996948 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
| https://github.com/gobbleturk |
| gobbleturk | https://github.com/gobbleturk |
|
Jul 28, 2025
| https://github.com/AI-Hypercomputer/maxtext/pull/2030#pullrequestreview-3064093521 |
|
View reviewed changes
| https://github.com/AI-Hypercomputer/maxtext/pull/2030/files |
| MaxText/maxtext_utils.py | https://github.com/AI-Hypercomputer/maxtext/pull/2030/files#diff-42b892aaeaab0d6e847530e0399cf0c215fa17efddfdbbe09b69a1c043f57c1f |
| gobbleturk | https://github.com/gobbleturk |
| Jul 28, 2025 | https://github.com/AI-Hypercomputer/maxtext/pull/2030#discussion_r2237490272 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
| gagika | https://github.com/gagika |
| Jul 28, 2025 | https://github.com/AI-Hypercomputer/maxtext/pull/2030#discussion_r2237687822 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
| https://github.com/gobbleturk |
| gobbleturk | https://github.com/gobbleturk |
|
Jul 28, 2025
| https://github.com/AI-Hypercomputer/maxtext/pull/2030#pullrequestreview-3064094682 |
|
View reviewed changes
| https://github.com/AI-Hypercomputer/maxtext/pull/2030/files |
| gobbleturk | https://github.com/gobbleturk |
| https://github.com/AI-Hypercomputer/maxtext/pull/2030#pullrequestreview-3064094682 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
pull ready
| https://github.com/AI-Hypercomputer/maxtext/issues?q=state%3Aopen%20label%3A%22pull%20ready%22 |
| Jul 28, 2025 | https://github.com/AI-Hypercomputer/maxtext/pull/2030#event-18862095054 |
|
| https://github.com/gagika |
| Fix Llama4 attention flops | https://github.com/AI-Hypercomputer/maxtext/pull/2030/commits/43f5406c4fff2b1c9f694f513b8874b0fab75efd |
| 43f5406 | https://github.com/AI-Hypercomputer/maxtext/pull/2030/commits/43f5406c4fff2b1c9f694f513b8874b0fab75efd |
| https://github.com/gagika |
| gagika | https://github.com/gagika |
| force-pushed | https://github.com/AI-Hypercomputer/maxtext/compare/22d6db6867a473345232962eb11c049c2cb2be26..43f5406c4fff2b1c9f694f513b8874b0fab75efd |
| 22d6db6 | https://github.com/AI-Hypercomputer/maxtext/commit/22d6db6867a473345232962eb11c049c2cb2be26 |
| 43f5406 | https://github.com/AI-Hypercomputer/maxtext/commit/43f5406c4fff2b1c9f694f513b8874b0fab75efd |
|
Compare
| https://github.com/AI-Hypercomputer/maxtext/compare/22d6db6867a473345232962eb11c049c2cb2be26..43f5406c4fff2b1c9f694f513b8874b0fab75efd |
| July 28, 2025 19:36 | https://github.com/AI-Hypercomputer/maxtext/pull/2030#event-18863401036 |
| https://github.com/apps/copybara-service |
| copybara-service | https://github.com/apps/copybara-service |
| 9cabaf6 | https://github.com/AI-Hypercomputer/maxtext/commit/9cabaf63730840242fbf689327e8c6663f660c23 |
| Jul 28, 2025 | https://github.com/AI-Hypercomputer/maxtext/pull/2030#event-18865423759 |
| Please reload this page | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
| https://github.com/apps/copybara-service |
| copybara-service | https://github.com/apps/copybara-service |
| July 28, 2025 22:35 | https://github.com/AI-Hypercomputer/maxtext/pull/2030#event-18865423847 |
|
[BUG] Inaccurate FLOPs Calculation for Causal and Specialized Attention
NVIDIA-NeMo/NeMo#14376
| https://github.com/NVIDIA-NeMo/NeMo/issues/14376 |
|
[BUG] Inaccurate FLOPs Calculation for Models with Specialized Attention
NVIDIA/Megatron-LM#1725
| https://github.com/NVIDIA/Megatron-LM/issues/1725 |
|
Attention flops calculation doesn't reflect causal masking
#1972
| https://github.com/AI-Hypercomputer/maxtext/issues/1972 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FAI-Hypercomputer%2Fmaxtext%2Fpull%2F2030 |
|
| https://github.com/RissyRan |
|
RissyRan
| https://github.com/RissyRan |
|
| https://github.com/AI-Hypercomputer/maxtext/pull/2030/files/22d6db6867a473345232962eb11c049c2cb2be26 |
|
| https://github.com/gobbleturk |
|
gobbleturk
| https://github.com/gobbleturk |
|
| https://github.com/AI-Hypercomputer/maxtext/pull/2030/files/22d6db6867a473345232962eb11c049c2cb2be26 |
|
| https://github.com/khatwanimohit |
|
khatwanimohit
| https://github.com/khatwanimohit |
|
| https://github.com/bvandermoon |
|
bvandermoon
| https://github.com/bvandermoon |
|
| https://github.com/vipannalla |
|
vipannalla
| https://github.com/vipannalla |
|
| https://github.com/richjames0 |
|
richjames0
| https://github.com/richjames0 |
|
| https://github.com/shralex |
|
shralex
| https://github.com/shralex |
|
| https://github.com/yangyuwei |
|
yangyuwei
| https://github.com/yangyuwei |
|
| https://github.com/SurbhiJainUSC |
|
SurbhiJainUSC
| https://github.com/SurbhiJainUSC |
|
| https://github.com/hengtaoguo |
|
hengtaoguo
| https://github.com/hengtaoguo |
|
| https://github.com/A9isha |
|
A9isha
| https://github.com/A9isha |
|
| https://github.com/aireenmei |
|
aireenmei
| https://github.com/aireenmei |
|
| https://github.com/shralex |
|
shralex
| https://github.com/shralex |
|
| https://github.com/gobbleturk |
|
gobbleturk
| https://github.com/gobbleturk |
|
| https://github.com/NuojCheng |
|
NuojCheng
| https://github.com/NuojCheng |
|
pull ready
| https://github.com/AI-Hypercomputer/maxtext/issues?q=state%3Aopen%20label%3A%22pull%20ready%22 |
| Please reload this page | https://github.com/AI-Hypercomputer/maxtext/pull/2030 |
|
| https://github.com/gagika |
|
| https://github.com/RissyRan |
|
| https://github.com/gobbleturk |
|
| https://github.com/shralex |
|
| https://github.com/NuojCheng |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |