Title: [BUG] Ocean variables missing time_bnds, failing CMIP6 compliance check (ATTR004/VAR004) · Issue #454 · ACCESS-NRI/ACCESS-MOPPy · GitHub
Open Graph Title: [BUG] Ocean variables missing time_bnds, failing CMIP6 compliance check (ATTR004/VAR004) · Issue #454 · ACCESS-NRI/ACCESS-MOPPy
X Title: [BUG] Ocean variables missing time_bnds, failing CMIP6 compliance check (ATTR004/VAR004) · Issue #454 · ACCESS-NRI/ACCESS-MOPPy
Description: Summary After CMORisation, all ocean variables (Omon + Oyr) produce output files whose time coordinate carries the attribute bounds = "time_bounds", yet no time_bounds (or time_bnds) variable exists in the file. The compliance-checker th...
Open Graph Description: Summary After CMORisation, all ocean variables (Omon + Oyr) produce output files whose time coordinate carries the attribute bounds = "time_bounds", yet no time_bounds (or time_bnds) variable exist...
X Description: Summary After CMORisation, all ocean variables (Omon + Oyr) produce output files whose time coordinate carries the attribute bounds = "time_bounds", yet no time_bounds (or time_bnds) vari...
Opengraph URL: https://github.com/ACCESS-NRI/ACCESS-MOPPy/issues/454
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[BUG] Ocean variables missing time_bnds, failing CMIP6 compliance check (ATTR004/VAR004)","articleBody":"## Summary\n\nAfter CMORisation, all ocean variables (Omon + Oyr) produce output files whose\n`time` coordinate carries the attribute `bounds = \"time_bounds\"`, yet no\n`time_bounds` (or `time_bnds`) variable exists in the file. The compliance-checker\ntherefore reports a **HIGH**-severity error `ATTR004/VAR004`: the variable\nreferenced by `time:bounds` does not exist in the file.\n\n## Affected scope\n\n13 files affected (all Omon + Oyr variables):\n\n| Table | Variables |\n|-------|-----------|\n| Omon | intpp, mlotst, so, thetao, tos, uo, vo, zos |\n| Oyr | detoc, dissic, no3, o2, talk |\n\nAtmosphere (Amon) variables are unaffected — they follow a separate, already-working\ncode path.\n\n## Root cause\n\nThree compounding issues:\n\n1. **Naming mismatch**: the raw MOM model files contain a `time_bounds(time, nv)`\n variable with `time:bounds = \"time_bounds\"`. The code, however, expects the\n CMOR-convention name `time_bnds` (`_get_required_bounds_variables` builds the\n name as `input_dim + \"_bnds\"`).\n\n2. **Dropped during loading**: `_preprocess` in `load_dataset` keeps only\n `required_vars \u0026 ds.data_vars`. `required_vars` contains `time_bnds`, while the\n file has `time_bounds`, so the raw `time_bounds` is silently dropped — yet the\n `bounds = \"time_bounds\"` attribute on the `time` coordinate is preserved and\n written to the output file.\n\n3. **Bounds calculation disabled**: in `ocean.py` the call\n `calculate_missing_bounds_variables(required_bounds)` was double-commented out,\n and the method was defined only on `Atmosphere_CMORiser` — `Ocean_CMORiser` did\n not have it at all.\n\nNet result: the output file has a dangling `time:bounds` attribute with no\ncorresponding bounds variable.\n\n## Relevant code locations\n\n- `src/access_moppy/ocean.py` — the commented-out bounds calculation call\n- `src/access_moppy/atmosphere.py` — `calculate_missing_bounds_variables` (originally defined only here)\n- `src/access_moppy/base.py` — `load_dataset` / `_preprocess`\n- `src/access_moppy/vocabulary_processors.py` — `_get_required_bounds_variables`\n\n## Expected behaviour\n\nOcean output files should contain a `time_bnds(time, bnds)` variable with\n`time:bounds = \"time_bnds\"`, and `bnds` should be a pure dimension with no index\nvalues — consistent with atmosphere output and passing the compliance check.\n","author":{"url":"https://github.com/rhaegar325","@type":"Person","name":"rhaegar325"},"datePublished":"2026-06-23T06:21:34.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/454/ACCESS-MOPPy/issues/454"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:54f8003b-a293-c776-144f-795eb5a60e42 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D590:138C8D:917DA:CEA54:6A4BBC99 |
| html-safe-nonce | 35eb7ace773adc1ca29c29ec88266277c0dc402d1c8344541aeed63498f49cb5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTkwOjEzOEM4RDo5MTdEQTpDRUE1NDo2QTRCQkM5OSIsInZpc2l0b3JfaWQiOiI4MDk1MTY5NDM2NjE5MzU3MzM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ea5ce5a2faed24fe111fd98f21006563afc54670252a4bb483013613ffdbf313 |
| hovercard-subject-tag | issue:4723201488 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/ACCESS-NRI/ACCESS-MOPPy/454/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5e194eae0f95f8d52d76a7a48fa5fbb7aea5ac56c350e36affaa852a01ffc5ed/ACCESS-NRI/ACCESS-MOPPy/issues/454 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5e194eae0f95f8d52d76a7a48fa5fbb7aea5ac56c350e36affaa852a01ffc5ed/ACCESS-NRI/ACCESS-MOPPy/issues/454 |
| og:image:alt | Summary After CMORisation, all ocean variables (Omon + Oyr) produce output files whose time coordinate carries the attribute bounds = "time_bounds", yet no time_bounds (or time_bnds) variable exist... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rhaegar325 |
| hostname | github.com |
| expected-hostname | github.com |
| None | ae1c14875555a1dd92bdef45baa6dd9aa796df891e4e471989f7117fe3139fc1 |
| turbo-cache-control | no-preview |
| go-import | github.com/ACCESS-NRI/ACCESS-MOPPy git https://github.com/ACCESS-NRI/ACCESS-MOPPy.git |
| octolytics-dimension-user_id | 105186864 |
| octolytics-dimension-user_login | ACCESS-NRI |
| octolytics-dimension-repository_id | 955620939 |
| octolytics-dimension-repository_nwo | ACCESS-NRI/ACCESS-MOPPy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 955620939 |
| octolytics-dimension-repository_network_root_nwo | ACCESS-NRI/ACCESS-MOPPy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b15c57117aeff522995a9578e1185f6c45d6c562 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width