Title: MessagingRSocket incorrectly tries to release entire input stream on channel interaction · Issue #24741 · spring-projects/spring-framework · GitHub
Open Graph Title: MessagingRSocket incorrectly tries to release entire input stream on channel interaction · Issue #24741 · spring-projects/spring-framework
X Title: MessagingRSocket incorrectly tries to release entire input stream on channel interaction · Issue #24741 · spring-projects/spring-framework
Description: The issue was discovered in Spring Security tests after a recent fix in Reactor Core to the switchOnFirst operator which now properly detects and flags the scenario. In an RSocket channel interaction, a Spring server responder fails to f...
Open Graph Description: The issue was discovered in Spring Security tests after a recent fix in Reactor Core to the switchOnFirst operator which now properly detects and flags the scenario. In an RSocket channel interacti...
X Description: The issue was discovered in Spring Security tests after a recent fix in Reactor Core to the switchOnFirst operator which now properly detects and flags the scenario. In an RSocket channel interacti...
Opengraph URL: https://github.com/spring-projects/spring-framework/issues/24741
X: @github
Domain: github-redirect.dependabot.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"MessagingRSocket incorrectly tries to release entire input stream on channel interaction ","articleBody":"The issue was discovered in Spring Security tests after a recent fix in Reactor Core to the `switchOnFirst` operator which now properly detects and flags the scenario.\r\n\r\nIn an RSocket channel interaction, a Spring server responder fails to find a matching route and in that scenarios the exception occurs. The server handles this with `switchOnFirst` and in the end, if input stream wasn't subscribed to (e.g. because there was no matching handler), it subscribes in order to release the payloads resulting in:\r\n\r\n```\r\nreactor.core.Exceptions$ErrorCallbackNotImplemented: java.util.concurrent.CancellationException: FluxSwitchOnFirst has already been cancelled\r\nCaused by: java.util.concurrent.CancellationException: FluxSwitchOnFirst has already been cancelled\r\n\tat reactor.core.publisher.FluxSwitchOnFirst$SwitchOnFirstMain.subscribe(FluxSwitchOnFirst.java:348) ~[reactor-core-3.3.4.BUILD-SNAPSHOT.jar:3.3.4.BUILD-SNAPSHOT]\r\n\tat reactor.core.publisher.Flux.subscribe(Flux.java:8260) ~[reactor-core-3.3.4.BUILD-SNAPSHOT.jar:3.3.4.BUILD-SNAPSHOT]\r\n\tat reactor.core.publisher.Flux.subscribeWith(Flux.java:8424) ~[reactor-core-3.3.4.BUILD-SNAPSHOT.jar:3.3.4.BUILD-SNAPSHOT]\r\n\tat reactor.core.publisher.Flux.subscribe(Flux.java:8231) ~[reactor-core-3.3.4.BUILD-SNAPSHOT.jar:3.3.4.BUILD-SNAPSHOT]\r\n\tat reactor.core.publisher.Flux.subscribe(Flux.java:8158) ~[reactor-core-3.3.4.BUILD-SNAPSHOT.jar:3.3.4.BUILD-SNAPSHOT]\r\n\tat reactor.core.publisher.Flux.subscribe(Flux.java:8101) ~[reactor-core-3.3.4.BUILD-SNAPSHOT.jar:3.3.4.BUILD-SNAPSHOT]\r\n\tat org.springframework.messaging.rsocket.annotation.support.MessagingRSocket.lambda$handleAndReply$5(MessagingRSocket.java:177) ~[spring-messaging-5.2.4.RELEASE.jar:5.2.4.RELEASE]\r\n```\r\n\r\nWe shouldn't subscribe to the entire input which in a channel interaction can be quite long. In any case only the first payload is received at that point, and it's the only one that needs releasing.\r\n","author":{"url":"https://github.com/rstoyanchev","@type":"Person","name":"rstoyanchev"},"datePublished":"2020-03-20T09:55:38.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/24741/spring-framework/issues/24741"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0e08874f-781e-f73d-402a-486ad4d127bf |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D30C:1AD21C:2FAAD10:4018606:6A6541E0 |
| html-safe-nonce | 5ad92c7e3e7c1a1aa252fb4a7d14002b0ddeddbb73bff080bf8f712071ea138b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzBDOjFBRDIxQzoyRkFBRDEwOjQwMTg2MDY6NkE2NTQxRTAiLCJ2aXNpdG9yX2lkIjoiMTI3MzU0ODg4NDEyNTQ5OTg3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7dc02952467b81b7d660341c283daf961ced32ff4abc02c3f488b1c72e65eacd |
| hovercard-subject-tag | issue:584956806 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/spring-projects/spring-framework/24741/issue_layout |
| twitter:image | https://opengraph.githubassets.com/04926e68b9e4cdd170ea68fecde3d70e7428cb4c98d5939fe1eb48a83f5dcb0d/spring-projects/spring-framework/issues/24741 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/04926e68b9e4cdd170ea68fecde3d70e7428cb4c98d5939fe1eb48a83f5dcb0d/spring-projects/spring-framework/issues/24741 |
| og:image:alt | The issue was discovered in Spring Security tests after a recent fix in Reactor Core to the switchOnFirst operator which now properly detects and flags the scenario. In an RSocket channel interacti... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rstoyanchev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b |
| turbo-cache-control | no-preview |
| go-import | github.com/spring-projects/spring-framework git https://github.com/spring-projects/spring-framework.git |
| octolytics-dimension-user_id | 317776 |
| octolytics-dimension-user_login | spring-projects |
| octolytics-dimension-repository_id | 1148753 |
| octolytics-dimension-repository_nwo | spring-projects/spring-framework |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1148753 |
| octolytics-dimension-repository_network_root_nwo | spring-projects/spring-framework |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 309153364422b3c499922d1a2a6404910a58ed8e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width