René's URL Explorer Experiment


Title: tls: fix authorized state on no-cert TLS1.3 client cert resumption by pimterry · Pull Request #64677 · nodejs/node · GitHub

Open Graph Title: tls: fix authorized state on no-cert TLS1.3 client cert resumption by pimterry · Pull Request #64677 · nodejs/node

X Title: tls: fix authorized state on no-cert TLS1.3 client cert resumption by pimterry · Pull Request #64677 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Previously if you used TLS 1.3 and the server requested a client cert, but the client didn't send one, and you used rejectUnauthorized: false (e.g. to manually verify state with some extra cond...

X Description: Previously if you used TLS 1.3 and the server requested a client cert, but the client didn't send one, and you used rejectUnauthorized: false (e.g. to manually verify state with some extra ...

Opengraph URL: https://github.com/nodejs/node/pull/64677

X: @github

direct link

Domain: Github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5695a8cd-8bce-b6c2-9b70-915bfe212ccc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE666:2FD50E:3DEDB3:58722C:6A61CA14
html-safe-nonce647a3864d9a9f6ee9bba31acf3fe5116703d175acbbeea793c4c942bb94fccc7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjY2OjJGRDUwRTozREVEQjM6NTg3MjJDOjZBNjFDQTE0IiwidmlzaXRvcl9pZCI6Ijc3MDcwNDMxNjM0NTU3MzYzNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac91f82d4ef59a59ea8eebecc6db459d291303a06ac48b0390217a7681ede635db
hovercard-subject-tagpull_request:4109149465
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64677/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d5a22314b85228ea2c0d964cc6cb73b6fca660a9a70d98309b7c1f69c54b2112/nodejs/node/pull/64677
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d5a22314b85228ea2c0d964cc6cb73b6fca660a9a70d98309b7c1f69c54b2112/nodejs/node/pull/64677
og:image:altPreviously if you used TLS 1.3 and the server requested a client cert, but the client didn't send one, and you used rejectUnauthorized: false (e.g. to manually verify state with some extra cond...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepimterry
hostnamegithub.com
expected-hostnamegithub.com
Noneb2de8c74e5e61e893155ba46ee41bc66170c1644cb795adefa8386d490f7781c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released1866027ded575df8a15c731dd8b9986c9483ceb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://Github.com/nodejs/node/pull/64677#start-of-content
https://Github.com/
Sign in https://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64677
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64677
Sign up https://Github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://Github.com/nodejs/node/pull/64677
Reloadhttps://Github.com/nodejs/node/pull/64677
Reloadhttps://Github.com/nodejs/node/pull/64677
Please reload this pagehttps://Github.com/nodejs/node/pull/64677
nodejs https://Github.com/nodejs
nodehttps://Github.com/nodejs/node
Please reload this pagehttps://Github.com/nodejs/node/pull/64677
Notifications https://Github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://Github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://Github.com/login?return_to=%2Fnodejs%2Fnode
Code https://Github.com/nodejs/node
Issues 1.3k https://Github.com/nodejs/node/issues
Pull requests 1.1k https://Github.com/nodejs/node/pulls
Actions https://Github.com/nodejs/node/actions
Projects https://Github.com/nodejs/node/projects
Security and quality 0 https://Github.com/nodejs/node/security
Insights https://Github.com/nodejs/node/pulse
Code https://Github.com/nodejs/node
Issues https://Github.com/nodejs/node/issues
Pull requests https://Github.com/nodejs/node/pulls
Actions https://Github.com/nodejs/node/actions
Projects https://Github.com/nodejs/node/projects
Security and quality https://Github.com/nodejs/node/security
Insights https://Github.com/nodejs/node/pulse
pimterryhttps://Github.com/pimterry
nodejs:mainhttps://Github.com/nodejs/node/tree/main
pimterry:fix-tls-1.3-client-cert-resumehttps://Github.com/pimterry/node/tree/fix-tls-1.3-client-cert-resume
Conversationhttps://Github.com/nodejs/node/pull/64677
Commits1 (1)https://Github.com/nodejs/node/pull/64677/commits
Checkshttps://Github.com/nodejs/node/pull/64677/checks
Files changedhttps://Github.com/nodejs/node/pull/64677/files
tls: fix authorized state on no-cert TLS1.3 client cert resumptionhttps://Github.com/nodejs/node/pull/64677#top
pimterryhttps://Github.com/pimterry
nodejs:mainhttps://Github.com/nodejs/node/tree/main
pimterry:fix-tls-1.3-client-cert-resumehttps://Github.com/pimterry/node/tree/fix-tls-1.3-client-cert-resume
https://Github.com/pimterry
pimterryhttps://Github.com/pimterry
Jul 22, 2026https://Github.com/nodejs/node/pull/64677#issue-4950123515
herehttps://github.com/nodejs/node/blob/2deb0a1b0f542c4b7fedc16dda1149c65e546f0d/deps/ncrypto/ncrypto.cc#L4100-L4106
#35317https://github.com/nodejs/node/issues/35317
@bnoordhuishttps://github.com/bnoordhuis
#64584https://github.com/nodejs/node/pull/64584
#64584https://github.com/nodejs/node/pull/64584
Please reload this pagehttps://Github.com/nodejs/node/pull/64677
https://Github.com/nodejs-github-bot
nodejs-github-bothttps://Github.com/nodejs-github-bot
Jul 22, 2026https://Github.com/nodejs/node/pull/64677#issuecomment-5047621808
Please reload this pagehttps://Github.com/nodejs/node/pull/64677
https://Github.com/nodejs-github-bot
nodejs-github-bothttps://Github.com/nodejs-github-bot
needs-ci https://Github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tls https://Github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Jul 22, 2026https://Github.com/nodejs/node/pull/64677#event-28332292091
https://Github.com/pimterry
pimterryhttps://Github.com/pimterry
Jul 22, 2026 https://Github.com/nodejs/node/pull/64677#ref-issue-707448399
Reloading page bypasses TLS client authentication #35317 https://Github.com/nodejs/node/issues/35317
https://Github.com/pimterry
pimterryhttps://Github.com/pimterry
force-pushedhttps://Github.com/nodejs/node/compare/005f950b3dd3069d02077e4fb36bf7c0f2433775..8ec1d601dc98de5c6e324d4f1920a201b494d9dc
005f950https://Github.com/nodejs/node/commit/005f950b3dd3069d02077e4fb36bf7c0f2433775
8ec1d60https://Github.com/nodejs/node/commit/8ec1d601dc98de5c6e324d4f1920a201b494d9dc
Compare https://Github.com/nodejs/node/compare/005f950b3dd3069d02077e4fb36bf7c0f2433775..8ec1d601dc98de5c6e324d4f1920a201b494d9dc
July 22, 2026 14:59https://Github.com/nodejs/node/pull/64677#event-28333046605
https://Github.com/pimterry
tls: fix authorized state on no-cert TLS1.3 client cert resumptionhttps://Github.com/nodejs/node/pull/64677/commits/428a444aa0c5f845848f461710d41ed23408fb63
428a444https://Github.com/nodejs/node/pull/64677/commits/428a444aa0c5f845848f461710d41ed23408fb63
https://Github.com/pimterry
pimterryhttps://Github.com/pimterry
force-pushedhttps://Github.com/nodejs/node/compare/8ec1d601dc98de5c6e324d4f1920a201b494d9dc..428a444aa0c5f845848f461710d41ed23408fb63
8ec1d60https://Github.com/nodejs/node/commit/8ec1d601dc98de5c6e324d4f1920a201b494d9dc
428a444https://Github.com/nodejs/node/commit/428a444aa0c5f845848f461710d41ed23408fb63
Compare https://Github.com/nodejs/node/compare/8ec1d601dc98de5c6e324d4f1920a201b494d9dc..428a444aa0c5f845848f461710d41ed23408fb63
July 22, 2026 17:13https://Github.com/nodejs/node/pull/64677#event-28339524085
https://Github.com/pimterry
pimterryhttps://Github.com/pimterry
Jul 22, 2026https://Github.com/nodejs/node/pull/64677#issuecomment-5050428097
Please reload this pagehttps://Github.com/nodejs/node/pull/64677
https://Github.com/apps/codecov
codecovhttps://Github.com/apps/codecov
Jul 22, 2026https://Github.com/nodejs/node/pull/64677#issuecomment-5051299132
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64677?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
fbab458https://app.codecov.io/gh/nodejs/node/commit/fbab4586118ccd225d06706fe6502e063354b765?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
428a444https://app.codecov.io/gh/nodejs/node/commit/428a444aa0c5f845848f461710d41ed23408fb63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64677?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/tls/wrap.jshttps://app.codecov.io/gh/nodejs/node/pull/64677?src=pr&el=tree&filepath=lib%2Finternal%2Ftls%2Fwrap.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Rscy93cmFwLmpz
33 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64677/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://Github.com/nodejs/node/pull/64677
https://github.co/hiddenchars
https://Github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://Github.com/join?source=comment-repo
Sign in to commenthttps://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64677
needs-ci https://Github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tls https://Github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Reloading page bypasses TLS client authentication https://github.com/nodejs/node/issues/35317
Please reload this pagehttps://Github.com/nodejs/node/pull/64677
https://Github.com/pimterry
https://Github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.