René's URL Explorer Experiment


Title: url: handle unparsable serialized URLs in setters by mcollina · Pull Request #64651 · nodejs/node · GitHub

Open Graph Title: url: handle unparsable serialized URLs in setters by mcollina · Pull Request #64651 · nodejs/node

X Title: url: handle unparsable serialized URLs in setters by mcollina · Pull Request #64651 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: URL updates reparse the stored serialized URL. Return failure when that parse does not succeed so property setters leave the URL unchanged. Add coverage for URL values that are accepted initially b...

X Description: URL updates reparse the stored serialized URL. Return failure when that parse does not succeed so property setters leave the URL unchanged. Add coverage for URL values that are accepted initially b...

Opengraph URL: https://github.com/nodejs/node/pull/64651

X: @github

direct link

Domain: Github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:20400e15-62c0-f1dc-3410-46dc79380761
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC0A:AAE15:E2CB1F:1401429:6A61CE1E
html-safe-nonce62337f2510c90b26b016971b0f4be18161746d6e69d2b798d315a5389b2818ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzBBOkFBRTE1OkUyQ0IxRjoxNDAxNDI5OjZBNjFDRTFFIiwidmlzaXRvcl9pZCI6IjgwMTYzNTEwODMwMjI2MzQ1MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf0af20f8bdf0f9e03e4299261c4a90f12ab771dd155d41511c1547d0e96937dd
hovercard-subject-tagpull_request:4099727212
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64651/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/abd703f6f1d2c88310ae322132189a651e01d5d74af8c653774c337018c2ba1f/nodejs/node/pull/64651
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/abd703f6f1d2c88310ae322132189a651e01d5d74af8c653774c337018c2ba1f/nodejs/node/pull/64651
og:image:altURL updates reparse the stored serialized URL. Return failure when that parse does not succeed so property setters leave the URL unchanged. Add coverage for URL values that are accepted initially b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcollina
hostnamegithub.com
expected-hostnamegithub.com
Noneb2de8c74e5e61e893155ba46ee41bc66170c1644cb795adefa8386d490f7781c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released1866027ded575df8a15c731dd8b9986c9483ceb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://Github.com/nodejs/node/pull/64651#start-of-content
https://Github.com/
Sign in https://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64651
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64651
Sign up https://Github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://Github.com/nodejs/node/pull/64651
Reloadhttps://Github.com/nodejs/node/pull/64651
Reloadhttps://Github.com/nodejs/node/pull/64651
Please reload this pagehttps://Github.com/nodejs/node/pull/64651
nodejs https://Github.com/nodejs
nodehttps://Github.com/nodejs/node
Please reload this pagehttps://Github.com/nodejs/node/pull/64651
Notifications https://Github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://Github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://Github.com/login?return_to=%2Fnodejs%2Fnode
Code https://Github.com/nodejs/node
Issues 1.3k https://Github.com/nodejs/node/issues
Pull requests 1.1k https://Github.com/nodejs/node/pulls
Actions https://Github.com/nodejs/node/actions
Projects https://Github.com/nodejs/node/projects
Security and quality 0 https://Github.com/nodejs/node/security
Insights https://Github.com/nodejs/node/pulse
Code https://Github.com/nodejs/node
Issues https://Github.com/nodejs/node/issues
Pull requests https://Github.com/nodejs/node/pulls
Actions https://Github.com/nodejs/node/actions
Projects https://Github.com/nodejs/node/projects
Security and quality https://Github.com/nodejs/node/security
Insights https://Github.com/nodejs/node/pulse
mcollinahttps://Github.com/mcollina
nodejs:mainhttps://Github.com/nodejs/node/tree/main
mcollina:url-handle-unparsable-href-updateshttps://Github.com/mcollina/node/tree/url-handle-unparsable-href-updates
Conversationhttps://Github.com/nodejs/node/pull/64651
Commits1 (1)https://Github.com/nodejs/node/pull/64651/commits
Checkshttps://Github.com/nodejs/node/pull/64651/checks
Files changedhttps://Github.com/nodejs/node/pull/64651/files
url: handle unparsable serialized URLs in settershttps://Github.com/nodejs/node/pull/64651#top
mcollinahttps://Github.com/mcollina
nodejs:mainhttps://Github.com/nodejs/node/tree/main
mcollina:url-handle-unparsable-href-updateshttps://Github.com/mcollina/node/tree/url-handle-unparsable-href-updates
https://Github.com/mcollina
mcollinahttps://Github.com/mcollina
Jul 21, 2026https://Github.com/nodejs/node/pull/64651#issue-4939077181
Please reload this pagehttps://Github.com/nodejs/node/pull/64651
Please reload this pagehttps://Github.com/nodejs/node/pull/64651
https://Github.com/nodejs-github-bot
nodejs-github-bothttps://Github.com/nodejs-github-bot
Jul 21, 2026https://Github.com/nodejs/node/pull/64651#issuecomment-5034305822
Please reload this pagehttps://Github.com/nodejs/node/pull/64651
https://Github.com/nodejs-github-bot
nodejs-github-bothttps://Github.com/nodejs-github-bot
c++ https://Github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://Github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
whatwg-url https://Github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Jul 21, 2026https://Github.com/nodejs/node/pull/64651#event-28269407719
https://Github.com/mcollina
url: handle unparsable serialized URLs in settershttps://Github.com/nodejs/node/pull/64651/commits/985563fa7fa1753a2b91a0f013fb0e09ba55d013
985563fhttps://Github.com/nodejs/node/pull/64651/commits/985563fa7fa1753a2b91a0f013fb0e09ba55d013
https://Github.com/mcollina
mcollinahttps://Github.com/mcollina
force-pushedhttps://Github.com/nodejs/node/compare/0fee8e85b6df8221575c977c82e47b42fd141f63..985563fa7fa1753a2b91a0f013fb0e09ba55d013
0fee8e8https://Github.com/nodejs/node/commit/0fee8e85b6df8221575c977c82e47b42fd141f63
985563fhttps://Github.com/nodejs/node/commit/985563fa7fa1753a2b91a0f013fb0e09ba55d013
Compare https://Github.com/nodejs/node/compare/0fee8e85b6df8221575c977c82e47b42fd141f63..985563fa7fa1753a2b91a0f013fb0e09ba55d013
July 21, 2026 13:19https://Github.com/nodejs/node/pull/64651#event-28270666567
https://Github.com/apps/codecov
codecovhttps://Github.com/apps/codecov
Jul 21, 2026https://Github.com/nodejs/node/pull/64651#issuecomment-5035780022
Please reload this pagehttps://Github.com/nodejs/node/pull/64651
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64651?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
4bec191https://app.codecov.io/gh/nodejs/node/commit/4bec1915dccb161c5d93075ab587b7ba2dd94389?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
985563fhttps://app.codecov.io/gh/nodejs/node/commit/985563fa7fa1753a2b91a0f013fb0e09ba55d013?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64651?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_url.cchttps://app.codecov.io/gh/nodejs/node/pull/64651?src=pr&el=tree&filepath=src%2Fnode_url.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfdXJsLmNj
34 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64651/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://Github.com/nodejs/node/pull/64651
https://Github.com/jasnell
jasnellhttps://Github.com/jasnell
Jul 21, 2026 https://Github.com/nodejs/node/pull/64651#pullrequestreview-4749827726
View reviewed changes https://Github.com/nodejs/node/pull/64651/files/985563fa7fa1753a2b91a0f013fb0e09ba55d013
test/parallel/test-whatwg-url-custom-setters.jshttps://Github.com/nodejs/node/pull/64651/files/985563fa7fa1753a2b91a0f013fb0e09ba55d013#diff-d44d32ca2c49bf7a9984fb01eefcaed25adc548378c168c555c359a7eea21bf0
jasnellhttps://Github.com/jasnell
Jul 21, 2026https://Github.com/nodejs/node/pull/64651#discussion_r3626425442
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://Github.com/nodejs/node/pull/64651
mcollinahttps://Github.com/mcollina
Jul 22, 2026https://Github.com/nodejs/node/pull/64651#discussion_r3628727198
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://Github.com/nodejs/node/pull/64651
jasnellhttps://Github.com/jasnell
Jul 22, 2026https://Github.com/nodejs/node/pull/64651#discussion_r3630932845
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://Github.com/nodejs/node/pull/64651
https://Github.com/jasnell
jasnellhttps://Github.com/jasnell
Jul 21, 2026 https://Github.com/nodejs/node/pull/64651#pullrequestreview-4749828344
View reviewed changes https://Github.com/nodejs/node/pull/64651/files/985563fa7fa1753a2b91a0f013fb0e09ba55d013
https://github.co/hiddenchars
https://Github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://Github.com/join?source=comment-repo
Sign in to commenthttps://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64651
https://Github.com/jasnell
jasnell https://Github.com/jasnell
https://Github.com/nodejs/node/pull/64651/files/985563fa7fa1753a2b91a0f013fb0e09ba55d013
c++ https://Github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://Github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
whatwg-url https://Github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Please reload this pagehttps://Github.com/nodejs/node/pull/64651
https://Github.com/mcollina
https://Github.com/nodejs-github-bot
https://Github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.