René's URL Explorer Experiment


Title: No ES6 Map support? · Issue #138 · msgpack/msgpack-javascript · GitHub

Open Graph Title: No ES6 Map support? · Issue #138 · msgpack/msgpack-javascript

X Title: No ES6 Map support? · Issue #138 · msgpack/msgpack-javascript

Description: If I run the following test program with msgpack-javascript 2.1.0: import { encode, decode } from "@msgpack/msgpack" const map = new Map() map.set("a", 1) map.set("b", 2) map.set("c", 3) const encoded = encode(map,{initialBufferSize:128}...

Open Graph Description: If I run the following test program with msgpack-javascript 2.1.0: import { encode, decode } from "@msgpack/msgpack" const map = new Map() map.set("a", 1) map.set("b", 2) map.set("c", 3) const enco...

X Description: If I run the following test program with msgpack-javascript 2.1.0: import { encode, decode } from "@msgpack/msgpack" const map = new Map() map.set("a", 1) map.set("b",...

Opengraph URL: https://github.com/msgpack/msgpack-javascript/issues/138

X: @github

direct link

Domain: Github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"No ES6 Map support?","articleBody":"If I run the following test program with msgpack-javascript 2.1.0:\r\n```\r\nimport { encode, decode } from \"@msgpack/msgpack\"\r\nconst map = new Map()\r\nmap.set(\"a\", 1)\r\nmap.set(\"b\", 2)\r\nmap.set(\"c\", 3)\r\nconst encoded = encode(map,{initialBufferSize:128})\r\nconst decoded = decode(encoded)\r\nconsole.log({map, encoded, decoded})\r\n```\r\nThe output is:\r\n\r\n\u003cimg width=\"380\" alt=\"Screen Shot 2020-10-04 at 11 40 42 PM\" src=\"https://user-images.githubusercontent.com/277318/95038024-16f84900-069b-11eb-8f49-30e91fb5d580.png\"\u003e\r\n\r\nConclusion: Asking msgpack-javascript to encode a Map causes it to encode it as if it were an empty object.\r\n\r\nSupporting Maps in some capacity would be good because if anything it is better to store Maps in msgpack than to store objects. Sometimes deserializing in JavaScript can cause problems or even security flaws if keys overwrite \"special\" javascript objects like `hasOwnProperty` or `__proto__`. [Here is an example of such a problem](https://medium.com/intrinsic/javascript-prototype-poisoning-vulnerabilities-in-the-wild-7bc15347c96). I suspect msgpack-javascript itself will not have any such security flaws, but it is easy for client code to have such security flaws and the security issues can be sidestepped by using Maps instead of objects. ","author":{"url":"https://github.com/mcclure","@type":"Person","name":"mcclure"},"datePublished":"2020-10-05T03:46:04.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/138/msgpack-javascript/issues/138"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a1d602f3-c78a-5c8f-f23f-cdc8149ff937
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id822A:115551:A55EC2:EADCCF:6A633C5C
html-safe-nonceb464207edd1535494bf9b40414dfbfedd471901337b886db22ae99f733e1bc45
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjJBOjExNTU1MTpBNTVFQzI6RUFEQ0NGOjZBNjMzQzVDIiwidmlzaXRvcl9pZCI6IjE2NjA2Njg0NTk5MDU5MjQxODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac28013fa054d71f978e414b7dd17019972d0a19fe0f85d53ab7a84103968295a9
hovercard-subject-tagissue:714486879
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/msgpack/msgpack-javascript/138/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7b7bf08a87a6a2cfc06377ea26e4af7c7af5d414a91b0a6c55a95da9b8e49604/msgpack/msgpack-javascript/issues/138
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7b7bf08a87a6a2cfc06377ea26e4af7c7af5d414a91b0a6c55a95da9b8e49604/msgpack/msgpack-javascript/issues/138
og:image:altIf I run the following test program with msgpack-javascript 2.1.0: import { encode, decode } from "@msgpack/msgpack" const map = new Map() map.set("a", 1) map.set("b", 2) map.set("c", 3) const enco...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemcclure
hostnamegithub.com
expected-hostnamegithub.com
None59e55daad7174ca59d63c6974d58276ccb5477442e550bebb3c035e1bef11c94
turbo-cache-controlno-preview
go-importgithub.com/msgpack/msgpack-javascript git https://github.com/msgpack/msgpack-javascript.git
octolytics-dimension-user_id198264
octolytics-dimension-user_loginmsgpack
octolytics-dimension-repository_id2761854
octolytics-dimension-repository_nwomsgpack/msgpack-javascript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id2761854
octolytics-dimension-repository_network_root_nwomsgpack/msgpack-javascript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release990295d92a4cc7b63fbbd83a046217cd7d77d49c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://Github.com/msgpack/msgpack-javascript/issues/138#start-of-content
https://Github.com/
Sign in https://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-javascript%2Fissues%2F138
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-javascript%2Fissues%2F138
Sign up https://Github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=msgpack%2Fmsgpack-javascript
Reloadhttps://Github.com/msgpack/msgpack-javascript/issues/138
Reloadhttps://Github.com/msgpack/msgpack-javascript/issues/138
Reloadhttps://Github.com/msgpack/msgpack-javascript/issues/138
Please reload this pagehttps://Github.com/msgpack/msgpack-javascript/issues/138
msgpack https://Github.com/msgpack
msgpack-javascripthttps://Github.com/msgpack/msgpack-javascript
Notifications https://Github.com/login?return_to=%2Fmsgpack%2Fmsgpack-javascript
Fork 178 https://Github.com/login?return_to=%2Fmsgpack%2Fmsgpack-javascript
Star 1.6k https://Github.com/login?return_to=%2Fmsgpack%2Fmsgpack-javascript
Code https://Github.com/msgpack/msgpack-javascript
Issues 18 https://Github.com/msgpack/msgpack-javascript/issues
Pull requests 5 https://Github.com/msgpack/msgpack-javascript/pulls
Discussions https://Github.com/msgpack/msgpack-javascript/discussions
Actions https://Github.com/msgpack/msgpack-javascript/actions
Security and quality 0 https://Github.com/msgpack/msgpack-javascript/security
Insights https://Github.com/msgpack/msgpack-javascript/pulse
Code https://Github.com/msgpack/msgpack-javascript
Issues https://Github.com/msgpack/msgpack-javascript/issues
Pull requests https://Github.com/msgpack/msgpack-javascript/pulls
Discussions https://Github.com/msgpack/msgpack-javascript/discussions
Actions https://Github.com/msgpack/msgpack-javascript/actions
Security and quality https://Github.com/msgpack/msgpack-javascript/security
Insights https://Github.com/msgpack/msgpack-javascript/pulse
No ES6 Map support?https://Github.com/msgpack/msgpack-javascript/issues/138#top
https://github.com/mcclure
mcclurehttps://github.com/mcclure
on Oct 5, 2020https://github.com/msgpack/msgpack-javascript/issues/138#issue-714486879
https://user-images.githubusercontent.com/277318/95038024-16f84900-069b-11eb-8f49-30e91fb5d580.png
Here is an example of such a problemhttps://medium.com/intrinsic/javascript-prototype-poisoning-vulnerabilities-in-the-wild-7bc15347c96
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.