René's URL Explorer Experiment


Title: perf: use interned name in `generic_getattr_opt` by sharifhsn · Pull Request #8129 · RustPython/RustPython · GitHub

Open Graph Title: perf: use interned name in `generic_getattr_opt` by sharifhsn · Pull Request #8129 · RustPython/RustPython

X Title: perf: use interned name in `generic_getattr_opt` by sharifhsn · Pull Request #8129 · RustPython/RustPython

Description: Closes #xxxx This PR follows our AI policy Summary generic_getattr_opt looked up the instance dict by name_str.as_wtf8(), which required recomputing the SipHash from the raw bytes on every attribute access. Now name_str: &Py implements DictKey, which returns the hash PyStr already caches, and adds a pointer-equality fast path for the key compare, which is much faster than using .as_wtf8(). Benchmarks vs main, median: attribute-read loop -17.3%, pystone -3.0%, OOP method loop -7.9%; neutral on non-attribute code. Assisted-by: Claude:claude-opus-4-8 Summary by CodeRabbit Refactor Optimized attribute lookup performance by improving the efficiency of dictionary lookups during attribute resolution.

Open Graph Description: Closes #xxxx This PR follows our AI policy Summary generic_getattr_opt looked up the instance dict by name_str.as_wtf8(), which required recomputing the SipHash from the raw bytes on every attr...

X Description: Closes #xxxx This PR follows our AI policy Summary generic_getattr_opt looked up the instance dict by name_str.as_wtf8(), which required recomputing the SipHash from the raw bytes on every attr...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8129

X: @github

direct link

Domain: Github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f8d87e22-09ed-4c1f-7eb2-d3f14e454985
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC78:1A456E:2A419CC:3A74C3F:6A632B3F
html-safe-nonce7430b9146bc5e5bcfdd9070dfbab3fc42fd8039abec12753078957b97f0b8ebd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzc4OjFBNDU2RToyQTQxOUNDOjNBNzRDM0Y6NkE2MzJCM0YiLCJ2aXNpdG9yX2lkIjoiNzY1MzE0NzEzNDk4MTc3ODIzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8fa1f309c3ce4e782ac413015f1dea0b726659cb9b273a2534c6a8e7490db2d8
hovercard-subject-tagpull_request:3887869717
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8129/files
twitter:imagehttps://avatars.githubusercontent.com/u/61516383?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/61516383?s=400&v=4
og:image:altCloses #xxxx This PR follows our AI policy Summary generic_getattr_opt looked up the instance dict by name_str.as_wtf8(), which required recomputing the SipHash from the raw bytes on every attr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None30c644d502bce6cd2e59f9000b4744f2b64819abea8e8f959b18e3ad793125aa
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release331492a48ebd91d66ef2de38e1901bb911c9fe9b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://Github.com/RustPython/RustPython/pull/8129/files#start-of-content
https://Github.com/
Sign in https://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8129%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8129%2Ffiles
Sign up https://Github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://Github.com/RustPython/RustPython/pull/8129/files
Reloadhttps://Github.com/RustPython/RustPython/pull/8129/files
Reloadhttps://Github.com/RustPython/RustPython/pull/8129/files
Please reload this pagehttps://Github.com/RustPython/RustPython/pull/8129/files
RustPython https://Github.com/RustPython
RustPythonhttps://Github.com/RustPython/RustPython
Notifications https://Github.com/login?return_to=%2FRustPython%2FRustPython
Fork 1.5k https://Github.com/login?return_to=%2FRustPython%2FRustPython
Star 22.2k https://Github.com/login?return_to=%2FRustPython%2FRustPython
Code https://Github.com/RustPython/RustPython
Issues 294 https://Github.com/RustPython/RustPython/issues
Pull requests 105 https://Github.com/RustPython/RustPython/pulls
Discussions https://Github.com/RustPython/RustPython/discussions
Actions https://Github.com/RustPython/RustPython/actions
Projects https://Github.com/RustPython/RustPython/projects
Models https://Github.com/RustPython/RustPython/models
Wiki https://Github.com/RustPython/RustPython/wiki
Security and quality 0 https://Github.com/RustPython/RustPython/security
Insights https://Github.com/RustPython/RustPython/pulse
Code https://Github.com/RustPython/RustPython
Issues https://Github.com/RustPython/RustPython/issues
Pull requests https://Github.com/RustPython/RustPython/pulls
Discussions https://Github.com/RustPython/RustPython/discussions
Actions https://Github.com/RustPython/RustPython/actions
Projects https://Github.com/RustPython/RustPython/projects
Models https://Github.com/RustPython/RustPython/models
Wiki https://Github.com/RustPython/RustPython/wiki
Security and quality https://Github.com/RustPython/RustPython/security
Insights https://Github.com/RustPython/RustPython/pulse
Sign up for GitHub https://Github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://Github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
sharifhsnhttps://Github.com/sharifhsn
RustPython:mainhttps://Github.com/RustPython/RustPython/tree/main
sharifhsn:perf/getattr-cached-hashhttps://Github.com/sharifhsn/RustPython/tree/perf/getattr-cached-hash
Conversation 3 https://Github.com/RustPython/RustPython/pull/8129
Commits 1 https://Github.com/RustPython/RustPython/pull/8129/commits
Checks 25 https://Github.com/RustPython/RustPython/pull/8129/checks
Files changed 1 https://Github.com/RustPython/RustPython/pull/8129/files
perf: use interned name in generic_getattr_opt https://Github.com/RustPython/RustPython/pull/8129/files#top
Show all changes 1 commit https://Github.com/RustPython/RustPython/pull/8129/files
dd4ad34 perf: look up instance __dict__ by the interned name (cached hash) in… sharifhsn Jun 15, 2026 https://Github.com/RustPython/RustPython/pull/8129/commits/dd4ad34b30375b8d4133f00e102d22eb9f2657ae
Clear filters https://Github.com/RustPython/RustPython/pull/8129/files
Please reload this pagehttps://Github.com/RustPython/RustPython/pull/8129/files
Please reload this pagehttps://Github.com/RustPython/RustPython/pull/8129/files
crates/vm/src/protocol/object.rshttps://Github.com/RustPython/RustPython/pull/8129/files#diff-e15b9e7d637d4c91a7e282e6a4d8fa79bd36b67b3453ada8136d66895a3ee75d
View file https://Github.com/RustPython/RustPython/blob/dd4ad34b30375b8d4133f00e102d22eb9f2657ae/crates/vm/src/protocol/object.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://Github.com/RustPython/RustPython/pull/8129/{{ revealButtonHref }}
https://Github.com/RustPython/RustPython/pull/8129/files#diff-e15b9e7d637d4c91a7e282e6a4d8fa79bd36b67b3453ada8136d66895a3ee75d
https://Github.com/RustPython/RustPython/pull/8129/files#diff-e15b9e7d637d4c91a7e282e6a4d8fa79bd36b67b3453ada8136d66895a3ee75d
https://Github.com/RustPython/RustPython/pull/8129/files#diff-e15b9e7d637d4c91a7e282e6a4d8fa79bd36b67b3453ada8136d66895a3ee75d
Please reload this pagehttps://Github.com/RustPython/RustPython/pull/8129/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.