René's URL Explorer Experiment


Title: Fix start_tls() loses buffer data and hangs when upgrading the connection by fizzi01 · Pull Request #708 · MagicStack/uvloop · GitHub

Open Graph Title: Fix start_tls() loses buffer data and hangs when upgrading the connection by fizzi01 · Pull Request #708 · MagicStack/uvloop

X Title: Fix start_tls() loses buffer data and hangs when upgrading the connection by fizzi01 · Pull Request #708 · MagicStack/uvloop

Description: Ultra fast asyncio event loop. Contribute to MagicStack/uvloop development by creating an account on GitHub.

Open Graph Description: This PR fixes a critical issue where buffered data in StreamReader is lost when upgrading a connection to TLS using StreamWriter.start_tls() or loop.start_tls(), causing the call to hang indefinite...

X Description: This PR fixes a critical issue where buffered data in StreamReader is lost when upgrading a connection to TLS using StreamWriter.start_tls() or loop.start_tls(), causing the call to hang indefinite...

Opengraph URL: https://github.com/MagicStack/uvloop/pull/708

X: @github

direct link

Domain: Github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9d4ac31c-b2aa-3a62-4ac6-734adda08d71
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBFA:9FC89:6EB06F:9C183C:6A624464
html-safe-nonce282a3d53a6926b6b02f012a78d041cf2bb85128bdd919dd3fd417705ba3ed3da
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkZBOjlGQzg5OjZFQjA2Rjo5QzE4M0M6NkE2MjQ0NjQiLCJ2aXNpdG9yX2lkIjoiMzkzMzk0MTI1NDY0NTIzNjgzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacddb79012a5115790a2525624030ba6b12974edff0aefb6c390e3bf28b1544c27
hovercard-subject-tagpull_request:3113989725
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/MagicStack/uvloop/708/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/15f0da97dab3e454ec8ed1a550e2f3786aa035be90a632a556a2932c3e222973/MagicStack/uvloop/pull/708
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/15f0da97dab3e454ec8ed1a550e2f3786aa035be90a632a556a2932c3e222973/MagicStack/uvloop/pull/708
og:image:altThis PR fixes a critical issue where buffered data in StreamReader is lost when upgrading a connection to TLS using StreamWriter.start_tls() or loop.start_tls(), causing the call to hang indefinite...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefizzi01
hostnamegithub.com
expected-hostnamegithub.com
None5d6ba65d73ecc4e3394fe318d2b2f98e6f8eed4878b5421b938e20d30bde267b
turbo-cache-controlno-cache
go-importgithub.com/MagicStack/uvloop git https://github.com/MagicStack/uvloop.git
octolytics-dimension-user_id14324950
octolytics-dimension-user_loginMagicStack
octolytics-dimension-repository_id45766550
octolytics-dimension-repository_nwoMagicStack/uvloop
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45766550
octolytics-dimension-repository_network_root_nwoMagicStack/uvloop
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2dadc56fd5989b76a8ae7304e3aa56d0b485e5dc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://Github.com/MagicStack/uvloop/pull/708#start-of-content
https://Github.com/
Sign in https://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMagicStack%2Fuvloop%2Fpull%2F708
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMagicStack%2Fuvloop%2Fpull%2F708
Sign up https://Github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=MagicStack%2Fuvloop
Reloadhttps://Github.com/MagicStack/uvloop/pull/708
Reloadhttps://Github.com/MagicStack/uvloop/pull/708
Reloadhttps://Github.com/MagicStack/uvloop/pull/708
Please reload this pagehttps://Github.com/MagicStack/uvloop/pull/708
MagicStack https://Github.com/MagicStack
uvloophttps://Github.com/MagicStack/uvloop
Notifications https://Github.com/login?return_to=%2FMagicStack%2Fuvloop
Fork 612 https://Github.com/login?return_to=%2FMagicStack%2Fuvloop
Star 11.9k https://Github.com/login?return_to=%2FMagicStack%2Fuvloop
Code https://Github.com/MagicStack/uvloop
Issues 126 https://Github.com/MagicStack/uvloop/issues
Pull requests 30 https://Github.com/MagicStack/uvloop/pulls
Actions https://Github.com/MagicStack/uvloop/actions
Projects https://Github.com/MagicStack/uvloop/projects
Wiki https://Github.com/MagicStack/uvloop/wiki
Security and quality 0 https://Github.com/MagicStack/uvloop/security
Insights https://Github.com/MagicStack/uvloop/pulse
Code https://Github.com/MagicStack/uvloop
Issues https://Github.com/MagicStack/uvloop/issues
Pull requests https://Github.com/MagicStack/uvloop/pulls
Actions https://Github.com/MagicStack/uvloop/actions
Projects https://Github.com/MagicStack/uvloop/projects
Wiki https://Github.com/MagicStack/uvloop/wiki
Security and quality https://Github.com/MagicStack/uvloop/security
Insights https://Github.com/MagicStack/uvloop/pulse
fizzi01https://Github.com/fizzi01
MagicStack:masterhttps://Github.com/MagicStack/uvloop/tree/master
fizzi01:fixhttps://Github.com/fizzi01/uvloop/tree/fix
Conversationhttps://Github.com/MagicStack/uvloop/pull/708
Commits8 (8)https://Github.com/MagicStack/uvloop/pull/708/commits
Checkshttps://Github.com/MagicStack/uvloop/pull/708/checks
Files changedhttps://Github.com/MagicStack/uvloop/pull/708/files
Fix start_tls() loses buffer data and hangs when upgrading the connectionhttps://Github.com/MagicStack/uvloop/pull/708#top
fizzi01https://Github.com/fizzi01
MagicStack:masterhttps://Github.com/MagicStack/uvloop/tree/master
fizzi01:fixhttps://Github.com/fizzi01/uvloop/tree/fix
https://Github.com/fizzi01
fizzi01https://Github.com/fizzi01
Dec 18, 2025https://Github.com/MagicStack/uvloop/pull/708#issue-3743395957
Please reload this pagehttps://Github.com/MagicStack/uvloop/pull/708
python/cpython#142352https://github.com/python/cpython/issues/142352
python/cpython#142354https://github.com/python/cpython/pull/142354
#707https://github.com/MagicStack/uvloop/issues/707
Please reload this pagehttps://Github.com/MagicStack/uvloop/pull/708
https://Github.com/fizzi01
Transfer buffered data from old protocol to SSL layer in start_tls()https://Github.com/MagicStack/uvloop/pull/708/commits/1b7c5dd3644eb7102db85ad581b5f509186c3964
1b7c5ddhttps://Github.com/MagicStack/uvloop/pull/708/commits/1b7c5dd3644eb7102db85ad581b5f509186c3964
https://Github.com/fizzi01
fizzi01https://Github.com/fizzi01
Dec 18, 2025https://Github.com/MagicStack/uvloop/pull/708#event-21645175294
https://Github.com/fizzi01
fizzi01https://Github.com/fizzi01
Dec 18, 2025https://Github.com/MagicStack/uvloop/pull/708#issuecomment-3671357836
Please reload this pagehttps://Github.com/MagicStack/uvloop/pull/708
Please reload this pagehttps://Github.com/MagicStack/uvloop/pull/708
https://Github.com/fizzi01
fizzi01https://Github.com/fizzi01
December 18, 2025 18:41https://Github.com/MagicStack/uvloop/pull/708#event-21651292389
https://Github.com/fantix
fantixhttps://Github.com/fantix
Dec 18, 2025https://Github.com/MagicStack/uvloop/pull/708#issuecomment-3672166871
Please reload this pagehttps://Github.com/MagicStack/uvloop/pull/708
https://Github.com/fizzi01
fizzi01https://Github.com/fizzi01
Dec 19, 2025https://Github.com/MagicStack/uvloop/pull/708#issuecomment-3673873824
Please reload this pagehttps://Github.com/MagicStack/uvloop/pull/708
Please reload this pagehttps://Github.com/MagicStack/uvloop/pull/708
https://Github.com/fizzi01
Fix wrong return behavior when missing _stream_reader in protocolhttps://Github.com/MagicStack/uvloop/pull/708/commits/20189edc181c5deb5c481c0c7ad68ab0cf5016ed
20189edhttps://Github.com/MagicStack/uvloop/pull/708/commits/20189edc181c5deb5c481c0c7ad68ab0cf5016ed
https://Github.com/fizzi01
fizzi01https://Github.com/fizzi01
December 19, 2025 07:43https://Github.com/MagicStack/uvloop/pull/708#event-21664447232
fizzi01https://Github.com/fizzi01
December 19, 2025 14:20https://Github.com/MagicStack/uvloop/pull/708#commits-pushed-f8fa0cf
https://Github.com/fizzi01
Resolve flake8 warnings in test utilitieshttps://Github.com/MagicStack/uvloop/pull/708/commits/f8fa0cf9ed37a57fea1170f6973c200987c2d38c
f8fa0cfhttps://Github.com/MagicStack/uvloop/pull/708/commits/f8fa0cf9ed37a57fea1170f6973c200987c2d38c
https://Github.com/fizzi01
Simplify logichttps://Github.com/MagicStack/uvloop/pull/708/commits/8d77cee0272518b1eaa63492e96fb3fc108e54c9
8d77ceehttps://Github.com/MagicStack/uvloop/pull/708/commits/8d77cee0272518b1eaa63492e96fb3fc108e54c9
https://Github.com/fizzi01
Skip test for Python versions before 3.11https://Github.com/MagicStack/uvloop/pull/708/commits/a40e9c632c95beb87ef2054b20e884c4d0811137
a40e9c6https://Github.com/MagicStack/uvloop/pull/708/commits/a40e9c632c95beb87ef2054b20e884c4d0811137
https://Github.com/fizzi01
Fix skip testhttps://Github.com/MagicStack/uvloop/pull/708/commits/0460bebe66d23d299ecdd07c1728554b5bda5557
0460bebhttps://Github.com/MagicStack/uvloop/pull/708/commits/0460bebe66d23d299ecdd07c1728554b5bda5557
https://Github.com/fizzi01
Resolve flake8 error againhttps://Github.com/MagicStack/uvloop/pull/708/commits/b0e3501d58b5e88432d0f288734c9994dc8758d6
b0e3501https://Github.com/MagicStack/uvloop/pull/708/commits/b0e3501d58b5e88432d0f288734c9994dc8758d6
https://Github.com/fizzi01
Improve testhttps://Github.com/MagicStack/uvloop/pull/708/commits/ef3f0208349facf6e4a146fb1a7a35611878d9f0
ef3f020https://Github.com/MagicStack/uvloop/pull/708/commits/ef3f0208349facf6e4a146fb1a7a35611878d9f0
https://Github.com/fizzi01
fizzi01https://Github.com/fizzi01
Jan 28, 2026https://Github.com/MagicStack/uvloop/pull/708#issuecomment-3812265646
@fantixhttps://github.com/fantix
Please reload this pagehttps://Github.com/MagicStack/uvloop/pull/708
https://github.co/hiddenchars
https://Github.com/MagicStack/uvloop/pull/{{ revealButtonHref }}
Sign up for freehttps://Github.com/join?source=comment-repo
Sign in to commenthttps://Github.com/login?return_to=https%3A%2F%2Fgithub.com%2FMagicStack%2Fuvloop%2Fpull%2F708
start_tls() loses buffered data and doesn't work when upgrading a stream https://github.com/MagicStack/uvloop/issues/707
Please reload this pagehttps://Github.com/MagicStack/uvloop/pull/708
https://Github.com/fizzi01
https://Github.com/fantix
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.